Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp824071imw; Thu, 14 Jul 2022 11:25:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1urDxshpz4GqwunDSCgGKRo18M3hQKyAY3wg5aX/7GAIp2q1RRGDxRY5DGreip38gH/xJQw X-Received: by 2002:a17:907:60cc:b0:72b:40a8:a5b with SMTP id hv12-20020a17090760cc00b0072b40a80a5bmr9689453ejc.379.1657823149373; Thu, 14 Jul 2022 11:25:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657823149; cv=none; d=google.com; s=arc-20160816; b=vPjKOot4xiq9IUNu99q5PnUQItkV3PiOzeSEqrUBQqURyiqEIz+9LfA92pxqxuS9ZL q2rj8vqtaeAdszX0/mzOzs5jnoYKxGZxjfnb1n7CTHaZZOcl0xubT/FoUINnHhdFLK1N UsYC8aTeEpKZBYcBgVGmmGdJCpirXYeD6kPAM7shNahI2Ld3ju7AtkGbHuc3eb5jmlXv nQPzgLuEihvOAvL6maSqIn62PKl/Dg7LW6YTrxMF7U12loYGeFo9+Y7SWudlfDsNd9QZ 8mI5ThkKvCIEvyyKI/DF6KDif4hUVcIeIvbV021vadYFzBrsbL5H0XpTwFr5VaiMvOaI eilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=G08/a/pbJZDDjGajLXg2XNCLHOrFCVzdDZWMH0QX/iY=; b=DqZRSXsousezj6iVmhxwxyFD6+pg+RH7TuynKhpr+breVGCu5FgzqXesjQ5NVnLCDh qOwjE9VUIiub5kCZecR6Y3dMtP4QcP8BNrq7JzxnsVCIfyQ548csd/fEvbL3QjvBLgKJ 62q6vzyGNkXTfkRgHE3u6s8i7BJJF2Es9zBLJjhfI8get6sbgEq0IzRnUM6dP+oARGtB Jv9rSHSPIUFU1wG2ScaSeDBkJKd3l6XMydmy9wZyj/t+0DPVpCPEE0OEpKbNC0q9BF3B ROGClTEk8616DHjikPNjxl7lRJwcWUu61ZMY2YC4lYuc7tKY+B9pKkSlYqS5JPY8euV5 Hq9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bbzrVmFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk31-20020a1709077f9f00b006fed9affed0si3749449ejc.528.2022.07.14.11.25.22; Thu, 14 Jul 2022 11:25:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bbzrVmFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239339AbiGNRiT (ORCPT + 99 others); Thu, 14 Jul 2022 13:38:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbiGNRiS (ORCPT ); Thu, 14 Jul 2022 13:38:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9074B5F10C; Thu, 14 Jul 2022 10:38:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F00662109; Thu, 14 Jul 2022 17:38:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 175A1C34114; Thu, 14 Jul 2022 17:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657820296; bh=I+JR2vuCoo4TsjHs0xtWLheVFBc/lFgWZka+PVI97jQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bbzrVmFt3ESKn/syjc7nTkCggq0bopPdVbbmq6nlS92dKqrK2/qGOnmisoEfRQ8GZ AAR7H0Ds1HMwIiG8VgxpHikOq/nBat8+2JphE78F7BJeg8mfhS83ZQcpKXD27Jk4M5 AyHok7VHNCwSqxjkvERpnvvIoeUZtldhsJqnK/W6yKBHEK1t/mhyz9OPhAMABT4C6z KQGC/OyNAalN8pYU0yV25thSq+OChMn6DNW3SlJpDR8sFNByaSR6RkEodACoj3D7jL 3wKWSsVyA7CGJWrw98Ix3x/hcIuDfuQnLKQGZTDqQ1pXk49Fh0BK0sUByEMnjoW9N8 FV/Dw0mSH8Dmw== Date: Thu, 14 Jul 2022 10:38:14 -0700 From: Josh Poimboeuf To: Peter Zijlstra Cc: Thadeu Lima de Souza Cascardo , Pawan Gupta , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com Subject: Re: [PATCH] x86/bugs: Switch to "auto" when "ibrs" selected on Enhanced IBRS parts Message-ID: <20220714173814.p5kdyimu6ho7zjt5@treble> References: <0456b35fb9ef957d9a9138e0913fb1a3fd445dff.1657747493.git.pawan.kumar.gupta@linux.intel.com> <20220714160106.c6efowo6ptsu72ne@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 07:03:32PM +0200, Peter Zijlstra wrote: > On Thu, Jul 14, 2022 at 09:01:06AM -0700, Josh Poimboeuf wrote: > > > > Yeah this; if the user asks for IBRS, we should give him IBRS. I hate > > > the 'I know better, let me change that for you' mentality. > > > > eIBRS CPUs don't even have legacy IBRS so I don't see how this is even > > possible. > > You can still WRMSR a lot on them. Might not make sense but it 'works'. Even in Intel documentation, eIBRS is often referred to as IBRS. It wouldn't be surprising for a user to consider spectre_v2=ibrs to mean "use eIBRS". I'm pretty sure there's nobody out there that wants spectre_v2=ibrs to mean "make it slower and possibly less secure because it's being used contrary to the spec". -- Josh