Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1fbf7cf-1bb7-6583-3713-7dbd58a4898e@denx.de>
Date:   Thu, 14 Jul 2022 21:02:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2 3/4] dmaengine: stm32-dma: add support to trigger STM32
 MDMA
Content-Language: en-US
To:     Amelie Delaunay <amelie.delaunay@foss.st.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Vinod Koul <vkoul@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc:     linux-doc@vger.kernel.org, dmaengine@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220713142148.239253-1-amelie.delaunay@foss.st.com>
 <20220713142148.239253-4-amelie.delaunay@foss.st.com>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <20220713142148.239253-4-amelie.delaunay@foss.st.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/13/22 16:21, Amelie Delaunay wrote:

[...]

> diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
> index adb25a11c70f..3916295fe154 100644
> --- a/drivers/dma/stm32-dma.c
> +++ b/drivers/dma/stm32-dma.c
> @@ -142,6 +142,8 @@
>   #define STM32_DMA_DIRECT_MODE_GET(n)	(((n) & STM32_DMA_DIRECT_MODE_MASK) >> 2)
>   #define STM32_DMA_ALT_ACK_MODE_MASK	BIT(4)
>   #define STM32_DMA_ALT_ACK_MODE_GET(n)	(((n) & STM32_DMA_ALT_ACK_MODE_MASK) >> 4)
> +#define STM32_DMA_MDMA_STREAM_ID_MASK	GENMASK(19, 16)
> +#define STM32_DMA_MDMA_STREAM_ID_GET(n) (((n) & STM32_DMA_MDMA_STREAM_ID_MASK) >> 16)

Try FIELD_GET() from include/linux/bitfield.h

[...]

> @@ -1630,6 +1670,20 @@ static int stm32_dma_probe(struct platform_device *pdev)
>   		chan->id = i;
>   		chan->vchan.desc_free = stm32_dma_desc_free;
>   		vchan_init(&chan->vchan, dd);
> +
> +		chan->mdma_config.ifcr = res->start;
> +		chan->mdma_config.ifcr += (chan->id & 4) ? STM32_DMA_HIFCR : STM32_DMA_LIFCR;
> +
> +		chan->mdma_config.tcf = STM32_DMA_TCI;
> +		/*
> +		 * bit0 of chan->id represents the need to left shift by 6
> +		 * bit1 of chan->id represents the need to extra left shift by 16
> +		 * TCIF0, chan->id = b0000; TCIF4, chan->id = b0100: left shift by 0*6 + 0*16
> +		 * TCIF1, chan->id = b0001; TCIF5, chan->id = b0101: left shift by 1*6 + 0*16
> +		 * TCIF2, chan->id = b0010; TCIF6, chan->id = b0110: left shift by 0*6 + 1*16
> +		 * TCIF3, chan->id = b0011; TCIF7, chan->id = b0111: left shift by 1*6 + 1*16
> +		 */
> +		chan->mdma_config.tcf <<= (6 * (chan->id & 0x1) + 16 * ((chan->id & 0x2) >> 1));

Some sort of symbolic macros instead of open-coded constants could help 
readability here.

[...]