Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 13:13:41 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>
CC:     Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V13 8/9] cxl/port: Retry reading CDAT on failure
Message-ID: <YtB49QRceabLTV/7@iweiny-desk3>
References: <20220705154932.2141021-1-ira.weiny@intel.com>
 <20220705154932.2141021-9-ira.weiny@intel.com>
 <62d043d8bd04c_16fb9729422@dwillia2-xfh.jf.intel.com.notmuch>
 <YtB3GySfcm5CfG01@iweiny-desk3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YtB3GySfcm5CfG01@iweiny-desk3>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M2AW4Q/c8QOiEpk9lvtVFh8+ZeKQQwTKwyHfk15am4yBgp79IojmqNBsARh4?=
 =?us-ascii?Q?XUi3QkRFZtETO7yCQp1iZRHT7yHCCMc6pw8oJMWt4qqMTRiCLQ6qFAtfE+MY?=
 =?us-ascii?Q?HT1xJmYfM222s11xuF09UaQO9JU+q7eQi5O7fsNjIlUpu7uw0m0SqTxyNTfn?=
 =?us-ascii?Q?CIyR4TW2Bu15Deqyk2vzQJ8nnUr4McjDN5AcYNfI0LFL9vNmPpJhCZn9rSWN?=
 =?us-ascii?Q?GB7+Zbt2auzxEqVv4eYBnFR2aVBcR9oWik/jdY0TLF08TW3Dqf6ieZDCJy23?=
 =?us-ascii?Q?rCGeVs80rRiJRla/vq1JvVjTGwpePyCKXCkdJZYi1kqY8+KtBn1LJpUQHgKA?=
 =?us-ascii?Q?d5NIds0kwlDmUDr2v2lNuPBVve7w387JDbmnCacWM+X3Ca5tziRwHB2qOU79?=
 =?us-ascii?Q?2Ch+musU7k6L0p2F6p44qIMXs2u10KyOmIVw9psMb4w/Rw3d7ReJBOHkGPFm?=
 =?us-ascii?Q?bMiMFIvXKsjoB3B+7kUe9vLrAjp/slzXvX2Sw859UDn/ADU6zbFkZSsWtzwm?=
 =?us-ascii?Q?gZLN56IHdL7a7i4NpU7ZjPEun53bK4WvOpO3ufvy4WSjyeRDwe/6+jlqaE1W?=
 =?us-ascii?Q?thJWcJvEHArB+r4aJjr79+L6PXvK1MSoiZ2MnR/ldVMyQrYcvFVTwfa/McSZ?=
 =?us-ascii?Q?Ypvqmsw1y8ynpdO7rxwTJcurH+6r6vrIM0Pf2gO4mvULS3b7GbSSIlQTivA1?=
 =?us-ascii?Q?mGvQXPKPrcYKFMdRyzaTWZSjb1wIYrxcbOsfwHDJ/8ZZBl2ow1qVndRB1L7h?=
 =?us-ascii?Q?Bp6YJDr4qHD4ZQ6yrcjvkC6j5SJn++PfIHVCoGNCkis8fKzQTSL11G7EQ1x7?=
 =?us-ascii?Q?DaKoqlc7EQSxhxdD+4HPuI49UlEIzP62lqHX7jD6TMPTxB1s8h86j6blCqsu?=
 =?us-ascii?Q?9nljGRcRvgDjsGQtzJTHHOuze7/19mkCqM2OZhl3GbYcKsE/xd+EyGQQcBv/?=
 =?us-ascii?Q?TLMPvfV9cgNGpStDx9kG8hng+6WAILf5w7jPutWFhsW7u9M0S7FMyPzyXbSo?=
 =?us-ascii?Q?1fAbhTE134wB0wxo85bjynXN570BL6g75y1TpLi/Ar1koUTuTssco1Fua+oK?=
 =?us-ascii?Q?/1VYgKfsycfqZrO31Tf/2lnDxFbFEKj6z4YJlK2m3T8DFU8txdUFV//VVApP?=
 =?us-ascii?Q?EYYBoakrJWc0DtfkJV0BRhRWkmObfTwsoWKGMqq9GU34NWzKzfkM/AI260xa?=
 =?us-ascii?Q?Mv5IM+1XyXx4uITt1T6Vgy5xsIgLNg78u8zSh2/EhORzej6dkaPJjAU/j1Zt?=
 =?us-ascii?Q?/Bt7WKofdBUIuBxjMoofwkOFnxjC+Ru+nsY99oDBFxBOpWxkpwASnderBDeg?=
 =?us-ascii?Q?zvRewxZGYWPKLMJ2dR+WZxNoupiBdRSOn4ols4cDfatW3alqDbvIqcRMHkJv?=
 =?us-ascii?Q?SYVjgXONFJLOzrHA45jb0Aw18lYppLc5Zsprof+dwDafCzSei0irIuT4b9HE?=
 =?us-ascii?Q?WcYSAagiwYXjFrWz6f6an57jt9ogsTnSjSw4UaUcGYt6L0joeoxrl+LsbDv4?=
 =?us-ascii?Q?TtuooV445u7lOOSZ/UZpZYzXVFQzRRvJXihwSbMVJbkcp4d+22McW4q6/APd?=
 =?us-ascii?Q?4VgJjPuIBRMCCyYMbciSTJNfvRmWTn5ey7ynY/eQSwXGYztJdmKyJGUJO50b?=
 =?us-ascii?Q?U4QYdd4BSlz8lwHOoh5swnk0QWMe1gzENDfsTIiLEhl5HvK8tDjEYZ1sjOAJ?=
 =?us-ascii?Q?JUIPiA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a563e8e-aeb0-4b34-7e6a-08da65d55cd6
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 20:13:48.9002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bzbnxb/BaJWwXGIjPoeTyqP7U3dBBVyJmHGt2x5PtUuuvzARvZaRgNQVGunRK1pOX7I5dewUrBNjnCbTsIrFDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1926
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 14, 2022 at 01:05:47PM -0700, Ira wrote:
> On Thu, Jul 14, 2022 at 09:27:04AM -0700, Dan Williams wrote:
> > ira.weiny@ wrote:
> > > From: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > The CDAT read may fail for a number of reasons but mainly it is possible
> > > to get different parts of a valid state.  The checksum in the CDAT table
> > > protects against this.
> > 
> > I don't know what "different parts of a valid state" means.
> 
> This text is stale but given what I know about how other entities may be
> issuing queries without the kernel knowledge I'm not 100% sure that the data
> read back will always be valid.
> 
> Regardless, this has already caught a bug in QEMU.
> 
> So I'm inclined to leave this check in because the checksum is there and should
> can be validated if only to detect broken hardware.
> 
> I can update the commit message to clarify this.

Oh wait I thought this was the 'is valid' patch.

I can remove the retries if that was all you were concerned about.

Ira

> 
> Ira
> 
> >
> > The CDAT
> > should not be changing as it is being read unless someone is issuing a
> > set-partition while the DOE operation is happening. Rather than
> > arbitrary retries, block out set-partition while CDAT is being read.
> > 
> > You can use {set,clear}_exclusive_cxl_commands() to temporarily lock out
> > set-partition while the CDAT read is happening.
> > 
> > ...and since this series is only for enabling