Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 13:23:45 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Guenter Roeck <linux@roeck-us.net>,
        Richard Weinberger <richard@nod.at>
CC:     Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        <linux-um@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Dan Williams <dan.j.williams@intel.com>,
        "Christoph Hellwig" <hch@lst.de>, <jane.chu@oracle.com>
Subject: RE: [PATCH] um: Replace to_phys() and to_virt() with less generic
 function names
Message-ID: <62d07b5120291_16fb97294fb@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220714184600.3981953-1-linux@roeck-us.net>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220714184600.3981953-1-linux@roeck-us.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGQ0UUZDTHFBT3RjUjJvZW85dytwc3FVNisxbXF0Um1WbUorbTlBWEhoelBL?=
 =?utf-8?B?MVRxQWhrZi9Id1d0NWlnL05NZ2FodHVSNGk5Zk5xVjRvR0M0Uk41QnJSeTlV?=
 =?utf-8?B?REhpR3JNcVo1OU5waXRlajdBWWdteE9qT1EzWGZIT3BYcDFwMHhmZExTZzF2?=
 =?utf-8?B?cFltOVphcGNMM0RBSlo4MGpTUnhiSXBNVkJiU2lnZWhDTVBrbmcrNHFVbmRz?=
 =?utf-8?B?bkxGWFZBc2d2Zi9hOS9tamo0MzFQK2ppTk9FTHk2Y3F3Nlo0cjRSN3Q2NW95?=
 =?utf-8?B?SjdPR1pQMTh3ODhYUW84TTBoNFVqT0ZycXlLUC94cFdYWE9iSm1RaXpQOHhM?=
 =?utf-8?B?WUVnUmhpYTd6Y21OdkJpeTNZRHMxdk9JSS8wVlZTKzhBekFwQXBmNmhqcjN0?=
 =?utf-8?B?MVllSXNZYTJSMWlyMGh4Vlh0Q3p2YnpETjU1aW5pNzJjQ2xoNlgyQ0tFb09Q?=
 =?utf-8?B?azZrem9QWkU4c0RQQ3VteVo5RitGSGI3MGxJQzNFQ1ZOMTV5TTFhWE5iR2kz?=
 =?utf-8?B?WDRzUUYzOTZUZ3dvZlFJam5OTG0yaWtocjZMbHBQYkhBck5rOTVSc2RJdndm?=
 =?utf-8?B?Wk14S1NRZ1c4WnQvYmt3Z09oeFQyQy9DRmNCNWhSYnRhUWZQQkFPM0JRa1dW?=
 =?utf-8?B?M0lieDhtbHQ3NHdaanVnT2FYMTg5NnRpemhaZUR6cmlsaEhacnovZ2tjbjEv?=
 =?utf-8?B?S2sxK0krcVAwelIzaFBCT21xY3ZyMHpoQjMzZ2tFUHhydUxrTU5NN0ZyRW1G?=
 =?utf-8?B?Z3B2REpNL2dNcStBSC9WeDFiSmJrRFNTTk5XVzFBZzgyTW40a3lUSk52elZL?=
 =?utf-8?B?bjZjUEI3S2U5d2tZODJHN2h0a29zUHZ1aFp3eXN5OGxXeithT2VaTitaZ08v?=
 =?utf-8?B?UGY4SEVzd1lLUFRRazV6My80Y21ISkpiSkgyUi93bVhFbFZTM0gxd1Bvajdp?=
 =?utf-8?B?NFJMWXZldG1taUw1ODlPU0JJUG5ROW5qK0g3UGFOaXg4a2JIcWt0eXA3M0JQ?=
 =?utf-8?B?aGd0MWo2ZG0vQWNiTXhEb1NrNUdLUDJyVU1NSXhzWURmQTgybnNabjBySXZP?=
 =?utf-8?B?RkdFakthWVg5VkJZMGx3OW1md2crVmFKZTh2Y2F6WCt3SW45Vm5pRlUrM0JZ?=
 =?utf-8?B?QUpGazdaZm9HYTBDbitQem0weXVtazBaMDdrenZZM2c2c1ZqSkgvVEU1dDVu?=
 =?utf-8?B?K29LbnBramRwNUozZy9NZ2l2Rkl4RldORnp2bnhja2wrTDlCS0cwejltV2s2?=
 =?utf-8?B?ZkhJZ0pGT093RDVGcFd5SVJRRmp6MXUzdXN4Ly9ZekFUeU96dmIwMjErNVln?=
 =?utf-8?B?S0s3SGpsd01nZHN5UkZySi95SDVPM1M0bUxQWkVSUytmaDBvN2hpYWg3c3lY?=
 =?utf-8?B?dmVLZ3h3OFowbnlrTlhZMUtRTkFILzRzOVdsUEpLUE9NVU1NcEFuZ1R1MGps?=
 =?utf-8?B?R2diRC9VTXZTWHpybUE5LzR6TVVkUGNmRW9NUWRtY2x2d29NTFNaaVB2ZWxu?=
 =?utf-8?B?THk0OGxGVFFaVFZHZW1vQThreE4vS25lV1VKaGQ1bXdxdHVFRU01OGp6UHhj?=
 =?utf-8?B?MERsaWFpakV2a29UM3F3MFlySUFYYTRvQW9wb2RkQVBoYlJzekIxdFZST0Uv?=
 =?utf-8?B?c0pEUW1mejB0MXZpcDc0bkczU3dDQUx3azE1czBkcm5DbnpuZ3JiQkNOZ2Z5?=
 =?utf-8?B?TkxOZEYvUnFvNG51TVNMRjlIQ2FtTmZMOElKcm15aVJzSFVRR2Jwd29rcnVs?=
 =?utf-8?B?SDVzeGN2d3BUSzNTV1RKZFhUYVFSVHk5SnEyVjQ4cEF3cXhTbXg5QnVNcS9V?=
 =?utf-8?B?N3R3RXVaNmhDbHBodmpPK1VOcmFSSFdTMlYrZ3RhMjFORlFubjRVR2RKaHcz?=
 =?utf-8?B?Zks1WXRPRHJqMGtLOG5EWWFpSS9hanpqaTJVU09lSkdhZGdjUEhkcE0yQnVl?=
 =?utf-8?B?cHR4SFJHbS84dGdBY1JXdGMvM3VPTCtMZUdraVEyL0czMDI3aisrQTJaRXpy?=
 =?utf-8?B?MkQ4L0c3QzhZemJHQi9kS09GTXRoelRPYkw0MFVjbXlPY29ucFJEYzlMcis0?=
 =?utf-8?B?S3BRNW9Cc3ZTalRaQjJoc0FDZjZIUHhiNEF3UnU5a2J0SVpSNU9uYk1aZzNi?=
 =?utf-8?B?UTZhQ2NOTlVlNkk0ZVF2MEFQeGMyVGdNQTBqWGJnYWxqUEFJOW44K1BiRGc4?=
 =?utf-8?B?NXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6eec1cb5-b892-48da-e729-08da65d6c1dd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 20:23:47.7548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AQp09Bga8oXHDLnZWS1DNe6BM7q+fNSo/kOTIGuK0DsNbgQ6EmXKzDa/U65X4RyRPKOlI2BVhOX610PMk6j19/+fKNn5deGVTRjHiwvRws0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3497
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[ add Jane ]

Guenter Roeck wrote:
> to_virt() and to_phys() are very generic and may be defined by drivers.
> As it turns out, commit 9409c9b6709e ("pmem: refactor pmem_clear_poison()")
> did exactly that. This results in build errors such as the following
> when trying to build um:allmodconfig.
> 
> drivers/nvdimm/pmem.c: In function ‘pmem_dax_zero_page_range’:
> ./arch/um/include/asm/page.h:105:20: error:
> 			too few arguments to function ‘to_phys’
>   105 | #define __pa(virt) to_phys((void *) (unsigned long) (virt))
>       |                    ^~~~~~~
> 
> Use less generic function names for the um specific to_phys() and to_virt()
> functions to fix the problem and to avoid similar problems in the future.
> 
> Fixes: 9409c9b6709e ("pmem: refactor pmem_clear_poison()")
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Christoph Hellwig <hch@lst.de>

Acked-by: Dan Williams <dan.j.williams@intel.com>

Jane had sent a pmem local fixup, that I was about to push to linux-next:

https://lore.kernel.org/nvdimm/20220630182802.3250449-1-jane.chu@oracle.com/

...but I like this one too, lets do both.

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  arch/um/include/asm/page.h      | 4 ++--
>  arch/um/include/shared/mem.h    | 4 ++--
>  arch/um/os-Linux/skas/process.c | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)