Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp934267imw; Thu, 14 Jul 2022 13:46:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uu7TODs3wd+ml+cqUKhlF/2SfEkCX77XnG53RCbTRVB7WndZ8YWCnL4UKkSddGb5njVOHh X-Received: by 2002:a05:6402:5388:b0:435:71b:5d44 with SMTP id ew8-20020a056402538800b00435071b5d44mr14209265edb.364.1657831609250; Thu, 14 Jul 2022 13:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657831609; cv=none; d=google.com; s=arc-20160816; b=SYnXTFec8JzwJSQk0CMfzZSnYpeZ84hReOIOa/xcUkpnVJBy32pbt4oPsaPEPooel7 3QC7yhcH36G+rPOYMdCMRoyZheB3zQjeLH/IxYqBVDplRjWk4ubrda2dWcrp2ZPdQGaY r8qEExdf8n6mHN4sif3DWcrjbrSXa49hIcxnG90R1zrg893D0t5wDHAQtptjQxxeFhxh UZDE+JRSh4N1YUc5jfzOC+6StlH5FGkCpfTvx8FL4CKfSAtKdsEWhDl2m37M+/Fm4rQ/ Ngp13IWA0VqsLfNH0VXEHiWpUrBUQO2TG3DPqGQ2dyF0pvDvVRVmHrlKS+F77rBJvs7w ilpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=l5kqjDQxPDfnO/p1iTyqBq5xMARQy02hbfQd6S9DIxo=; b=IONwfmEJoNFQYmghmlksyAwG++OQlpB/ZRVDEf6vzX+5QVPn1ibO62kLqQdUeTCcTc WYo9u7fZs1HclvAhAc9BL1i/IUhboc6yLsmBAWKHjscsxP7H1TV8pCUXF3Zf1Oz3Ent9 D4PBi2oVWcMROnaHCpFRkVWli09LIBRiMMw9qlZXEnPmmZFUgjbwbZFMSOHZNWDxCZu6 kS0Nf6l3uHNuZYOkwaIilwN6TWdzwJitSLig5QDKFcG+Tj63STBrjUXkN2fI4mDoitBu OnZ+XSiuZ5VfIG+Iqvcz//h47Zd0kYyLPhYFvVHgjU5dQuv4KsgBbT3XSKIdZivJobIT OLDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=AqJOSaWT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n13-20020a05640205cd00b0043a9602cb14si3624229edx.385.2022.07.14.13.46.24; Thu, 14 Jul 2022 13:46:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=AqJOSaWT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240835AbiGNUpZ (ORCPT + 99 others); Thu, 14 Jul 2022 16:45:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240614AbiGNUpW (ORCPT ); Thu, 14 Jul 2022 16:45:22 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 448D15464C for ; Thu, 14 Jul 2022 13:45:21 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id b12so1589573ilh.4 for ; Thu, 14 Jul 2022 13:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l5kqjDQxPDfnO/p1iTyqBq5xMARQy02hbfQd6S9DIxo=; b=AqJOSaWTPWW4l7m2eAwfo/OBadcln3Rf8X/B99A4tzqg31Qcnc5bc22CJit/vgjfth W2FwUX2BxbbaDgU0hCy05bI62PAzNPis1M/PjZunq0MA/frWB5cZ4l6/BwJNQgneT931 +38C0bEI9HaZTFnT5FFoBjVKvVyIFYxfNcE08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l5kqjDQxPDfnO/p1iTyqBq5xMARQy02hbfQd6S9DIxo=; b=vos/NR1rJBel3aD9CjYPo1V10hZQBvSWOSDXdHOsqmKOk9hdpVQpOUjdnCm1Q3KrBa q9UCqxdTMYwq8sJTBr+lMWJ/ZUn5/ihmp3t81GUwr10Omm1g0G2SCWfLyLliXINKxPl7 BZKHW/m8TM3s5hSEl3zWinwDrk0GVwqPDO/9XvybrSW0P1P5dFtQHR1RA7PSsQjYCQ/L Dn1/Szlh69eglz6JWCZh1eTq2NoHu6NoUfaugQCXmxHAB3c0W2bNklo47mSXI+jNGSo/ xW9YYkDa00M3lw9HfjOz6CCF+ldKo1qg8ze1ALw+fjre+ORAiFdy9hUPtU6oL4P4QhnA tFQg== X-Gm-Message-State: AJIora/CD1vHd9XBl3cbpPQsgbXISzpJLEOMkohxK2sppNNbV51pi1FX 4RLSAt9TfS0xCasG6UbOHMHi3Q== X-Received: by 2002:a05:6e02:1a45:b0:2dc:27a6:7651 with SMTP id u5-20020a056e021a4500b002dc27a67651mr5508056ilv.102.1657831520566; Thu, 14 Jul 2022 13:45:20 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id p123-20020a022981000000b0033eb2f2ccfasm1147979jap.43.2022.07.14.13.45.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 13:45:19 -0700 (PDT) Subject: Re: [PATCH] Makefile: replace headers_install with headers for kselftest To: Guillaume Tucker , Masahiro Yamada , Michal Marek , Nick Desaulniers , Shuah Khan , Kees Cook Cc: Anders Roxell , Tim.Bird@sony.com, kernel@collabora.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: From: Shuah Khan Message-ID: Date: Thu, 14 Jul 2022 14:45:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/22 12:33 AM, Guillaume Tucker wrote: > Replace headers_install with headers as kselftest uses the header > files from within the kernel tree rather than from a system-wide > installation. > > We can still run this directly: > > $ make O=build kselftest-all > > and when building from the selftests directory: > > $ make O=build headers > $ make O=build -C tools/testing/selftests all > > Signed-off-by: Guillaume Tucker > Reported-by: Masahiro Yamada > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index fb2f3bb53a6b..5c934d16664c 100644 > --- a/Makefile > +++ b/Makefile > @@ -1347,10 +1347,10 @@ tools/%: FORCE > # Kernel selftest > > PHONY += kselftest > -kselftest: headers_install > +kselftest: headers > $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests > > -kselftest-%: headers_install FORCE > +kselftest-%: headers FORCE > $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $* > > PHONY += kselftest-merge > Thank you for taking care of this. This will go through kbuild? Acked-by: Shuah Khan thanks, -- Shuah