Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 13:44:25 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V13 8/9] cxl/port: Retry reading CDAT on failure
Message-ID: <62d08029504b6_1643dc294cc@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220705154932.2141021-1-ira.weiny@intel.com>
 <20220705154932.2141021-9-ira.weiny@intel.com>
 <62d043d8bd04c_16fb9729422@dwillia2-xfh.jf.intel.com.notmuch>
 <YtB3GySfcm5CfG01@iweiny-desk3>
 <YtB49QRceabLTV/7@iweiny-desk3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YtB49QRceabLTV/7@iweiny-desk3>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7SOAtdeVMgIvpbS17xl53jvR1oN/pdgc80lwNy5WXqqBju/xHewEaaLrqOLh?=
 =?us-ascii?Q?9G9kbkUSY24az0myoa4+HcA5V7SHZLLGmq+hG3hlh32v/y2gg9P9f8fPYZQY?=
 =?us-ascii?Q?u03v/JyS2uZAQ/mJqrVRp3dGifWRBnVXmgyUVEeOEVUeUjz8Bh0ZZWpaCRAl?=
 =?us-ascii?Q?Bxt+/NWIyWXOkWiNa5ZVOeWcV83PHY6uAjvgT6pI1nIbAgRUrkwFQKSNXtn+?=
 =?us-ascii?Q?VxOye26QzJC2V/DORxtbMxI6Cwux6S6+8CcTjI4BDOaCOVuUoDryHEupBFEY?=
 =?us-ascii?Q?F7EDggiVR47rLP5xsemyC0dwWHdK/BrDReBFhs/0X3MWn4Y7WHLzhikS2NmX?=
 =?us-ascii?Q?5tLgvsfaqmEfDrEw3+Loaq2PQV8SiMoIPFbYezcGI/HxxXWQT/PcWqSSw9KA?=
 =?us-ascii?Q?PFlJ7BIoQ2QZp0gVLRLgKxgSvw6QVyhWHtg1fUeEYR7C6ZFIo7XdUsluf2RZ?=
 =?us-ascii?Q?b0ccbIAZvpRTXBg+Q37o+PGxtvxPPtbnazEHx6KgVXY7m+yRcG2uCgAshau+?=
 =?us-ascii?Q?hxuAPVdAG28jqrdMZLbyYfogE/HkLY6CjxRbHLHrcM3z/A1vL2QEpc7Hl5jC?=
 =?us-ascii?Q?CZQjK5ZTY9VaXhkdaqBH3uOigVl0/x9KCgBHyoqpRhPuhhXFUIKJTcurX2Hw?=
 =?us-ascii?Q?3TrP/Yq7piKYN6IXM/q+zzD8O87XE6SM3WwgqUQyUTosey7WIGlaneAqHkPB?=
 =?us-ascii?Q?7Emqthz6qnwWm44AJ/CXJOM+ZUsPKp8SRg3HQgCFLC/eyfq5si7P58wMiivp?=
 =?us-ascii?Q?SnyMfSm8jfAsy4Y2sGgsT9rDawvaQU2Asn8cVO4ZLZfPn2KMeQ8lH4mcYLoP?=
 =?us-ascii?Q?Yl3kXoyiLcQc3HStAb3Ph2BclcU8DUvN9KogeCVIuMgkcv0JqKNKyPVHvOby?=
 =?us-ascii?Q?CLLDlCLluO35dN8EMhmlRSLhe7GCawc0ljdqkrs/WSk6vjjwMwI+TjhkVuO8?=
 =?us-ascii?Q?Ww5yl+qUI709hoknf/7dGKb1KFy9nc9hD5Yzi9nff1upIrvaOCwzWgmyjCra?=
 =?us-ascii?Q?nr8zlXK1uZpWIJjAZmL9pH5zxCyTmxb43+zqcRCADZp8zChiiFympaCeCZR2?=
 =?us-ascii?Q?X5EvIikNl2lA7cfwjxhqBLHwOjjeidwyz671Ert8BPtLIIsaEEpND44SA+2t?=
 =?us-ascii?Q?JnBNRTEgnx4GQbXG++QUFDyK8I327ZUThCkTMzj2ngrYp6Y8BujY00om9sj/?=
 =?us-ascii?Q?mD6VSjwHcaH+oxkTzVFuEsD6bFAvf8oFEvVQCprBe5nr0LiuTT8pcQ1xyMcf?=
 =?us-ascii?Q?d8gRAt9Ysgl11on5YsLvdLcn+pYM5OlyAKhM9CD+8iImWT8fSj+PwwWKaMjr?=
 =?us-ascii?Q?D5JiolH3bpQEggZ4VpZegdsyypeOmGtXYzrJ6g4SGNOx7vF6+MOil/Npgz2D?=
 =?us-ascii?Q?uAofuZ2r64p6Nm+I1D6ISD3ty5kz7elGwwQb3Q6dVI+14ROXFxcJO6FKNSWD?=
 =?us-ascii?Q?8hjMM1/SvjOjZ6TI+cCE9nHibJQEQMhBH801E9y1+h3kLJI5wByW5CNYOZja?=
 =?us-ascii?Q?urXzCNmGLeEsO7QQhMbddu5SBU9G6Xj+5S0G/FdeefLCjqeP2gxTH4o7p0RT?=
 =?us-ascii?Q?4HQsW1kfEM+pc+m6dFhRnjH39lj6zrBTvuWjR2LTxl31g1R3cPACRbeT263M?=
 =?us-ascii?Q?8w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f09f4355-67f9-4adb-f027-08da65d9a524
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 20:44:28.4473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f65eSNaUONnBsIdZqZBY7pSwT68Wnh0yPtx3usqtDzZwvJunTbim6Si50gJJYeZhCx/BirZRn9wGKgne7OuvEPLG4YvNh077mxibC3l/azE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6512
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ira Weiny wrote:
> On Thu, Jul 14, 2022 at 01:05:47PM -0700, Ira wrote:
> > On Thu, Jul 14, 2022 at 09:27:04AM -0700, Dan Williams wrote:
> > > ira.weiny@ wrote:
> > > > From: Ira Weiny <ira.weiny@intel.com>
> > > > 
> > > > The CDAT read may fail for a number of reasons but mainly it is possible
> > > > to get different parts of a valid state.  The checksum in the CDAT table
> > > > protects against this.
> > > 
> > > I don't know what "different parts of a valid state" means.
> > 
> > This text is stale but given what I know about how other entities may be
> > issuing queries without the kernel knowledge I'm not 100% sure that the data
> > read back will always be valid.
> > 
> > Regardless, this has already caught a bug in QEMU.
> > 
> > So I'm inclined to leave this check in because the checksum is there and should
> > can be validated if only to detect broken hardware.
> > 
> > I can update the commit message to clarify this.
> 
> Oh wait I thought this was the 'is valid' patch.
> 
> I can remove the retries if that was all you were concerned about.
> 

I was concerned that this patch was trying to accommodate CDAT changes
while the retrieval is running which should be obviated by not allowing
set-partition while the CDAT retrieval is running. So I want to see
single-shot CDAT retrieval underneath set-partition protection.