Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp983112imw; Thu, 14 Jul 2022 14:50:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u1QmPCwGoT/eQRapcQpA4CDYuzaM98rcaPJusaCuPtF4ZSCnuJyby4tCPh4272hKAhe7a4 X-Received: by 2002:a17:907:28c9:b0:72b:7165:20c2 with SMTP id en9-20020a17090728c900b0072b716520c2mr10500917ejc.120.1657835431530; Thu, 14 Jul 2022 14:50:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657835431; cv=none; d=google.com; s=arc-20160816; b=j6VKnC3CR8K9lE7W3q+owU9J0fT6gxigD2GRBJr2fv9VulvkGh8GnVE4FfJ2cAOjRT qO9MtqP6wSUX14s1bIZc0cuz+v/tHpU0thYuL81a1u4C1VRzLOO9AZPiHJ4c7HHR6n1y /M4lQy1h2VaIZvZaVREh+DVFm4VVXs8FAmFuhg8m6FZz1JPiXrYyXdzfQFxsHe7eTWNl gfKmofTI6g03FY9iebUT23gqAodELtedeLiEqFUu4fvDpF2Nu4FKRbb8nIvgLCvtn8Lx 41tt22uzPFQLc4/RfKz8uXRZCDYmDJ47Cx6cOUhRXbQ7VJ+Piom4lhw1jIBgSWAmeer4 ssMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SVKG5QHIIPG6I/Emt4JAztLbMcvzDeRb700HJXrRrIA=; b=mv1ELjxHHDVfjTyJNA23GeZLmd167Y1/rmZuhp+wAKQzcsGkZNpRniea718JMes/1b QtJqf6vMR2V4aVjitADNhJRILT5z3/QOAu3YK7/kkCVbODxhDwuRoOqGwWBGTlnpVT1z CJo48FCDSSUxsJONbsVUb/3F947QzexcHn/zBURQtV9AkFYu/gYlCS3mASNc/Kp0Ejuh SQBnKe4Vf4BFACbCbWYnhVbyBo96EIm9xGfLBBPSq4sbopO+Ogzu6uvt7VGKojsgdgHT aeWIXW6NRWTb96puuQ9itTBm84rLD8U9CxFubPb2w6t7iXVX0Hrb776rzGHCwvFkEhkn fWyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMaYBh8E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du22-20020a17090772d600b007121245807esi4278776ejc.708.2022.07.14.14.49.41; Thu, 14 Jul 2022 14:50:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMaYBh8E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240949AbiGNVa3 (ORCPT + 99 others); Thu, 14 Jul 2022 17:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240877AbiGNVaK (ORCPT ); Thu, 14 Jul 2022 17:30:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0704C6EE92; Thu, 14 Jul 2022 14:30:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B36C8B8295D; Thu, 14 Jul 2022 21:30:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAECAC34115; Thu, 14 Jul 2022 21:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657834206; bh=pGm0dsNASTYMf22ud+Wu7McUirHoIf7rEXRhC4vp9qA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IMaYBh8EsSajCKtn5/TqeXYalivBUf6PZbpfG7e0JeKW2C9/2EGF2wGihOgv3byEx 6e06ZJCjE8fYREe3JS363dDB98jnUFQK3xqzbfc4pyxDuBY2Nvvip+89OyrgU6D8fB jGuwUzExoDmHyLLtSV1xAkLEHzP/gTCokcOdl6YzTySRvv/CfqOVesKXoNkSg5ocuE +I02B2a+BNiPztvpW62iP0T/+blURoDpWwKm9iyAiezO9XXYnX/rxp09i24ZENhCnn n6x05JW7a00mUXf97nSoM6rnPTpB5GM6a3Nd1BQBpETyQI4hO+HN8WZF0H/aKMWwlF lT9IzoMQ2Tknw== Date: Thu, 14 Jul 2022 14:30:05 -0700 From: Jakub Kicinski To: Nathan Chancellor , Peter Zijlstra , Borislav Petkov Cc: Linus Torvalds , x86@kernel.org, Nick Desaulniers , Josh Poimboeuf , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2] x86/speculation: Use DECLARE_PER_CPU for x86_spec_ctrl_current Message-ID: <20220714143005.73c71cf8@kernel.org> In-Reply-To: <20220713152436.2294819-1-nathan@kernel.org> References: <20220713152436.2294819-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jul 2022 08:24:37 -0700 Nathan Chancellor wrote: > Clang warns: > > arch/x86/kernel/cpu/bugs.c:58:21: error: section attribute is specified on redeclared variable [-Werror,-Wsection] > DEFINE_PER_CPU(u64, x86_spec_ctrl_current); > ^ > arch/x86/include/asm/nospec-branch.h:283:12: note: previous declaration is here > extern u64 x86_spec_ctrl_current; > ^ > 1 error generated. > > The declaration should be using DECLARE_PER_CPU instead so all > attributes stay in sync. > > Cc: stable@vger.kernel.org > Fixes: fc02735b14ff ("KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS") > Reported-by: kernel test robot > Signed-off-by: Nathan Chancellor Hi, sorry to bother, any idea on the ETA for this fix getting into Linus's tree? I'm trying to figure out if we should wait with forwarding the networking trees or this will take a while.