To: "H. Peter Anvin" <hpa@zytor.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] document Acked-by:
In-Reply-To: Your message of "Thu, 31 May 2007 23:10:42 PDT."
             <465FB862.207@zytor.com>
From: Valdis.Kletnieks@vt.edu
References: <200706010209.l51299kN000531@shell0.pdx.osdl.net> <28278.1180675923@turing-police.cc.vt.edu>
            <465FB862.207@zytor.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1180718845_9513P";
	 micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date: Fri, 01 Jun 2007 13:27:25 -0400
Message-ID: <11341.1180718845@turing-police.cc.vt.edu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1780
Lines: 47

--==_Exmh_1180718845_9513P
Content-Type: text/plain; charset=us-ascii

On Thu, 31 May 2007 23:10:42 PDT, "H. Peter Anvin" said:
> Valdis.Kletnieks@vt.edu wrote:
> > On Thu, 31 May 2007 19:09:10 PDT, akpm@linux-foundation.org said:
> > 
> >> +If a person was not directly involved in the preparation or handling of a
> >> +patch but wishes to signify and record their approval of it then they can
> >> +arrange to have an Acked-by: line added to the patch's changelog.
> >> +
> >> +Acked-by: is often used by the maintainer of the affected code when that
> >> +maintainer neither wrote, merged nor forwarded the patch themselves.
> > 
> > Do we want to add verbiage saying that an Acked-By: is also useful when it
> > comes from somebody (likely the original reporter) who has actually tested the
> > patch?
> 
> I'd rather see a Tested-By: for that.
> 
> There is a difference between a maintainer ack and a tester ok.

OK by me.  Half the time when a -mm breaks for me, it's an obvious one-liner
I can S-o-b: myself, the other half the time somebody else has a fix that
I keep thinking I should stick *something* on once I confirm it's fixed.

Do Linus/Andrew/major maintainers want Tested-By:'s for patches?


--==_Exmh_1180718845_9513P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFGYFb9cC3lWbTT17ARAqZaAKC5zRlcC0vVKuMjSA9J6Q6K6UTTDgCgiEMh
DcY1RAOcTK7Xf3xd63/IMOY=
=S7F1
-----END PGP SIGNATURE-----

--==_Exmh_1180718845_9513P--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/