Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1076448imw; Thu, 14 Jul 2022 17:01:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u8wZtS+F0WfjraTniJCOzCVPdZCSGaCAgJcX2F9jFaIIkwdIU2Nb5iEvYY3aXpSGoRXsXl X-Received: by 2002:a05:6871:109:b0:10c:179:7c91 with SMTP id y9-20020a056871010900b0010c01797c91mr8459312oab.144.1657843299630; Thu, 14 Jul 2022 17:01:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657843299; cv=none; d=google.com; s=arc-20160816; b=B26d1p0zQc5+zBCyy+1MQJ+4AvoOQhYJ75e2cG7yZuypJmZ5DO+9nwUa6djNF/jnSM nO41x9kTtfvg+0+jc2COtM9c1DxX7perqalqTI3pGf8aKCsmi+iSZu1MQTGFfuHPHid4 Toi6ZPic51kaii+cZz+Vz0eh679hYWhBYP5WZgB6e+DP9LSwkCzIQegR/6iz5+paeUnG dR3WnvFdSH/LX/W57vj6O2RdgIApX/F1ndaFEsdGZEw709h59hvSk1lNFJ1k5KcF1Wfq Pn36v+JTGdmPHZeAsMrHv2zsWT3YZDbrZh4vw2AUGgua6ZcEWhv5sZX9lBJCEGuan4VR fQ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ArMm7bihRHrCkL0t5dtMG1zcZquQWN7QEHZ+TFDtUwE=; b=B9tV07LWryMiMlAKqNqLXerjfWu1yBkQiBV7u6xKfJtWUEiIhquEOjJRczRGbHd5Qg LyUDWQXDdXok2YFF2jV8fIJTrUSzbsVcC6vrn7DpbEm+Z69kJZybNVvmNSsUOKUTg8A4 vC0kIqKiyLPIyKVmd3KWbFtlvxWjmuMQQrZcHJjFxJI5rOLUE7xmvjHUoI6hae7WOWtr CGmMpczYsdd0L1GLgwMY0iZyUxSk9kVNikkTrkipqk8zY+zBVKQM6sT5Uphle/JMjgKt AY6qnoUHCHkCR0uQhbWzsoYXPyB51vQOmFq+zsO9kCJiuV3aUpoeKu6NQaOXCNXA5RIg FlNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cX8oqWAF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x28-20020a056870b41c00b000f333413e16si2557140oap.95.2022.07.14.17.01.14; Thu, 14 Jul 2022 17:01:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cX8oqWAF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239839AbiGNXnm (ORCPT + 99 others); Thu, 14 Jul 2022 19:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbiGNXnl (ORCPT ); Thu, 14 Jul 2022 19:43:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A602663E8; Thu, 14 Jul 2022 16:43:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F13E362060; Thu, 14 Jul 2022 23:43:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05823C34114; Thu, 14 Jul 2022 23:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657842217; bh=QJ+IA9Z/8wyG4jgJreze8fyxTn9U2vb4t27Z3sdzMDY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cX8oqWAFRrj/tEPy2fsqVXI3GU0FK4m3n24q8tNLzNieR9jrp5/CGlSy7P0UOvoN7 t1j2BOL9ThC1b0Cj3aD5OWLpvtfW626dBrQthneyasT6gmq5Or1bekuNpjFIWaJht9 9XYOk0AY5JQ4sBnOnBgTkXeGhsFdIX2cNEgXzQYNGknagJS9APj0UvbKv6PFvusNMW upWO6m7pUVv5+R9e0Y0uM+0hQ/uTjy9o+QfGBlfonw2FNEu9drPt0Py991FszxEmJL de2LGPk4YShy8P2o5NP69VIqmkbelFQkyzco0HEtPxenaWBHbpMNvkzV3rX1FZ7FnF fJwDVP4d9CptQ== Date: Thu, 14 Jul 2022 16:43:36 -0700 From: Jakub Kicinski To: Ben Dooks Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee , Jude Onyenegecha , Nicolas Ferre , Claudiu Beznea , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH] net: macb: fixup sparse warnings on __be16 ports Message-ID: <20220714164336.0f2768a2@kernel.org> In-Reply-To: <20220714084305.209425-1-ben.dooks@sifive.com> References: <20220714084305.209425-1-ben.dooks@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2022 09:43:05 +0100 Ben Dooks wrote: > - htons(fs->h_u.tcp_ip4_spec.psrc), htons(fs->h_u.tcp_ip4_spec.pdst)); > + be16_to_cpu(fs->h_u.tcp_ip4_spec.psrc), > + be16_to_cpu(fs->h_u.tcp_ip4_spec.pdst)); There are some spaces on this line, please use tabs, checkpatch will be able to help you validate.