Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Uladzislau Rezki <urezki@gmail.com>
CC:     Christoph Hellwig <hch@infradead.org>, Song Liu <song@kernel.org>,
        bpf <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "mhiramat@kernel.org" <mhiramat@kernel.org>,
        "naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "anil.s.keshavamurthy@intel.com" <anil.s.keshavamurthy@intel.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "dave@stgolabs.net" <dave@stgolabs.net>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        Kernel Team <Kernel-team@fb.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which
 allocates RO+X memory
Thread-Topic: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which
 allocates RO+X memory
Thread-Index: AQHYlpK25UY5kW1ND0S/krM8qG//OK18E8oAgABfaYCAANKuAIAACKAAgADf3wCAAGbogA==
Date:   Fri, 15 Jul 2022 00:24:15 +0000
Message-ID: <54BB27F6-13A4-4EA6-8775-05BF5D8E2BC8@fb.com>
References: <20220713071846.3286727-1-song@kernel.org>
 <20220713071846.3286727-2-song@kernel.org> <Ys6ZkDUhRZcmvPYy@infradead.org>
 <BE896037-B79C-4B38-B777-96002C5861F5@fb.com>
 <Ys+aVKFJaQd130Pn@infradead.org>
 <8AC2399B-F3B2-4F91-B18C-D9D3D5085471@fb.com> <YtBdSYbCyGJeIHHO@pc636>
In-Reply-To: <YtBdSYbCyGJeIHHO@pc636>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bATYgzxWWDQZpGSmgF3VvhRguZO0bHYhzOgOMRIKoXbIjV1okcjDTEsHR7cq?=
 =?us-ascii?Q?xY2R892aWuDwyvdzckc0quKIe8NKDJU1RiThZZAUaMPWiAnl4/qStCx4YKcN?=
 =?us-ascii?Q?4UHM4I3PrSpkK9/wwfG0EyfhyymZvJ74k8dkKziC8RkWe6bObQzcK6nMVFsn?=
 =?us-ascii?Q?RLd28Abx0XkBp7WbSFyxYWzLBKuGCo49nmKLPTya2e58p/XHhFh2pitG2bqO?=
 =?us-ascii?Q?9y30An2Z7Z6PK/+32Zv9zZZAOkpjHJaCY12dAyNwBtflW/6bPMAMmBxb03OY?=
 =?us-ascii?Q?aP86jRBtlrYAVXJT+ZC6nfSs+oefXgmA61NZM1rPKlWgZ8v/Ydtxr1uaoFCX?=
 =?us-ascii?Q?bzV+EYgcHBGp65Yha6dODxrY/th1hB6B/HJ21FhnAKTLPScBM2cLEl6jKnp8?=
 =?us-ascii?Q?K3z7CN+38mrdQzOLBfHdDdkCxe/9EW9jqdxe/zR9G8cPfJBqxpzWBVVb99ae?=
 =?us-ascii?Q?jpP14ZbSL9ITVQwhzOJPRcIQRL69s/ERqBtATCGwu0Dw8tiAXVu1eo3qCsg5?=
 =?us-ascii?Q?fVjZOIzoSFG2P/UYsNRB9oorcLc20CBqi2EcuNB44vnZs0DDI86IWPydqGhO?=
 =?us-ascii?Q?9VCobwWKhz99+4tS4jHWMREMlY9z/LuA4yuk7fLnAZN7qubn9s6IDuVwi0Rk?=
 =?us-ascii?Q?XXVOautnq0Uc0xcmcv7OFoxQvknSTdSHosL8NQbB6XJapoUlMRohkJPY3647?=
 =?us-ascii?Q?tSWgr91MS/acn4pvzqN3T+xgoIPplvxzNmKXRBRHALnHO/+JCN3vf8TD9fm1?=
 =?us-ascii?Q?0nqdoBWjh/OgCPyzNekM4MNgQenwSWuHLRaT/tBLzQDsCrqqcRQoimE8sDF9?=
 =?us-ascii?Q?GO/+qknphI4Vd9VSxwg2QFyxsGrAAITugh0hp8p7lngTXAxzd9MdFsMXCP/L?=
 =?us-ascii?Q?IgmrgHrSVehgG9MSgtLIPc8IDNAIHP+Te1CKnLcqf1vOltwzKKofRYat+ReO?=
 =?us-ascii?Q?1ONZYg5EQEHPWaezPzskJh/m/dZMMRV901qPL2Qizkr3aBqLPQZ/o4wEpOHq?=
 =?us-ascii?Q?aX06TKMyJaY2Lg1KrYf3sETwh3v2XQcIOW58PZA6AS8bH7c3jnO95ALzsRtC?=
 =?us-ascii?Q?+KijBGlKQu2zLeV1nyZPj/BmDGyj0jJTRtkrNk4KziOydTf5TXjJ16Z1efAU?=
 =?us-ascii?Q?npwEPTf9/Nnr/6ltvp/B/Um/JIO63QSJUFfdjzvva4FDBTlKUn/InI7mJXXT?=
 =?us-ascii?Q?ukt51cOec8LOc0x2WuucIRUgkgDoETqMOjOXtYVHmGf/p2QSi44Iym7TBy/U?=
 =?us-ascii?Q?Kq2co3k4yLg1KID7/n3u2OAsqMhPR+nq3XGTvD7X9ZmvnxSWwmXnWnpuQJlQ?=
 =?us-ascii?Q?w9Rq5kXcTiC7AJiNJfTvth1OcnxPFmBBEmoa9ODHBgCMK/BZFB5o68U39URE?=
 =?us-ascii?Q?pmenQfK0Qzl8l+Tsyb+MQDKHmBX/tTEySkSIhKcuvVJ4YsH06fDF1KwtPf+U?=
 =?us-ascii?Q?lJXiuUEyqWDshFOi2/MN1WWrj+IMhxEPE85zhjRZZkDT7T/YEcXA3IVe75/t?=
 =?us-ascii?Q?pXfeHGvSR6GMuuH1rnWYxk8pjfUsUqetvt4YsfoQMuiFUGT3tOIPAkXhOhBz?=
 =?us-ascii?Q?2/UYQhDpCpyGaKg3tZT/SG1qhG0cz0KpoOIZ1PO97FivvteADYPzW+M18AB1?=
 =?us-ascii?Q?ZDrJM0t8z59r8PcBFvFqYbY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FAD233D3C648AA4BB9388C88E7EF0A42@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9d66d0b-6178-470e-5d6f-08da65f859d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 00:24:15.9443
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6lEd8Z+HH0Cf92cmDjzVANHrxaaLDZp/1BsKUx47usaY1BNnDumGXYx77RHSpk/KqQ63hbnpOQJUX8qlnUt+Zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR15MB5356
X-Proofpoint-ORIG-GUID: 7rNXUBovaQI1rvt6yf01TwYAap6hkfEd
X-Proofpoint-GUID: 7rNXUBovaQI1rvt6yf01TwYAap6hkfEd
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-14_19,2022-07-14_01,2022-06-22_01
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jul 14, 2022, at 11:15 AM, Uladzislau Rezki <urezki@gmail.com> wrote:
> 
> On Thu, Jul 14, 2022 at 04:54:40AM +0000, Song Liu wrote:
>> 
>> 
>>> On Jul 13, 2022, at 9:23 PM, Christoph Hellwig <hch@infradead.org> wrote:
>>> 
>>> On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote:
>>>> 
>>>> 
>>>>> On Jul 13, 2022, at 3:08 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>>>> 
>>>>> NAK.  This is not something that should be an exported public API
>>>>> ever.
>>>> 
>>>> Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..)
>>> 
>>> Even without that it really is not a vmalloc API anyway.  
>> 
>> This ...
>> 
>>> Executable
>>> memory needs to be written first, so we should allocate it in that state
>>> and only mark it executable after that write has completed.
>> 
>> ... and this are two separate NAKs.
>> 
>> For the first NAK, I agree that my version is another layer on top of 
>> vmalloc. But what do you think about Peter's idea? AFAICT, that fits
>> well in vmalloc logic. 
>> 
> I am not able to find the patch/change to see what you have done.

vger dropped my patch again. :(

> But
> please do not build a new allocator on top of vmalloc code. We have
> three different ones what make things to be complicated :)

It was a bpf_prog_pack like allocator, but named as vmalloc_exec(), 
vfree_exec(). I guess I have got enough NAKs for it. 

Thanks,
Song