Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1112051imw; Thu, 14 Jul 2022 17:55:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vZQuh+WYV0djLADcsEVXSaOkFKe8yD6yjl7BYKreOewbPNVIAb0si0kz+4NridVQsyxOMJ X-Received: by 2002:a17:907:7e94:b0:72b:53d2:c004 with SMTP id qb20-20020a1709077e9400b0072b53d2c004mr11487374ejc.387.1657846509360; Thu, 14 Jul 2022 17:55:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657846509; cv=none; d=google.com; s=arc-20160816; b=hyGN5M8AUeOBRuOR/1KYcwFZM/nO/s9+MsDMUnsBTlUWXAFZr6vbtYVnfGncJDNMJx v1hD004CTNsKKLFyK/oOeHnN+A/0jpd74OPl0Bccu8W8I0hD33bMa+GD3gQetMNqwFPB vwPrv4YK2ikrCL/ErD7e39Gh2W9Xh50FIuiI2bRh0Q7yzjleGLzkVNCEMeupk5w+d2qI b+g3G9b5KWduUQOzfc5XuF6JNhEbmmGPG0i72Mx2x4LZl7/k0U4/AvaxquPHSuJ+r+LQ YRh237jP48gc1GfMITZZ6pTugRMj1RAHEMH/g9Kn2izAl3YD14ZtP0gD4Cq91936axNt poFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RL4a78mz5dcxQKx/h6CWF+hVgr1YJg/HzEyCO0H00p0=; b=saKnpLqzroOaGF81iTAV4GIiqG+dKvbQ/TyQUZ0sQAHQC71tluhIKHhD7QVTyq1mnk d/MbWLcEiL45NN4Jzj8MSYbrfg+3XtdDoTXEUKZP+1E1X/AZcnyuSzGxsg1YLyhGkCXZ VPePQGlkNJv/hQ8FfM79kJi5EExszSVWCRJeGzdqPJcaHTh9fiV63wgaJThzeAaeBWQV kHtGm8SraGsF9CsbcI/RkCTUTdnDGHXUKtCpYifbHb4DU/0ujFx+aCVXZhkr7hgNSYMz 5WoOyj1ea5DeajHljF09t/VdbqCxia2VFLHvXPtjHQSVErInXfFUEcTJxm4LGA4cXVcY 5ySA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=22NYjQKf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020a170906700500b0072b5cece992si3380703ejj.386.2022.07.14.17.54.44; Thu, 14 Jul 2022 17:55:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=22NYjQKf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232713AbiGOAnY (ORCPT + 99 others); Thu, 14 Jul 2022 20:43:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiGOAnY (ORCPT ); Thu, 14 Jul 2022 20:43:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D74B0491E3; Thu, 14 Jul 2022 17:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RL4a78mz5dcxQKx/h6CWF+hVgr1YJg/HzEyCO0H00p0=; b=22NYjQKf/yMyYzmGZS+w4AE+Si QWIN0PJWTS0QpXve8sbJkO78xFs08bKN4h8IyzRjvxXZR/Zj330AIV0AGaJHFTHtYygQtsKuwdF9O tEIcCX+PGoxEDFQalmE1gdQZ1f2fvbv9T9lSHw3U0p0ZJ4iXWfdDXkR9JViMkUwUM+5jFTh7FrTQ8 k36845mcCcMWpj0NkIfqhpNMOCNty8riycMh2hBdDnbBRVAe9QjNglY0RGeAllUtgCZHrmyal4Qpa zgcXZ3p2Vtlve5aNQcQk1EFcJ11gdC7jf9ZW9efZIjUC35TLPOuRbooLnjQhVXtws5Tgh5dS7WJog DaD65xkQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC9QL-002owg-Kw; Fri, 15 Jul 2022 00:43:17 +0000 Date: Thu, 14 Jul 2022 17:43:17 -0700 From: Luis Chamberlain To: Aaron Tomlin Cc: christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, atomlin@atomlin.com, oleksandr@natalenko.name, neelx@redhat.com Subject: Re: [PATCH v2 0/3] module: Show the last unloaded module's taint flag(s) Message-ID: References: <20220714153933.2095776-1-atomlin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714153933.2095776-1-atomlin@redhat.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 04:39:30PM +0100, Aaron Tomlin wrote: > Hi Luis, Christophe, > > In addition to the previous iteration, since this particular series does > indeed modify last_unloaded_module, I decided to use strscpy() as a > replacement for the now deprecated strlcpy(). Nice, looks super clean now, applied and pushed to modules-next, thanks! BTW since you and Christophe seem to contribute a lot to modules lately, any chance for future stuff you can ask 0day folks to add your trees and branches to get tested prior to posting patches? Then you can suggest in your cover letter they've been blessed by 0-day or whatever. Typically I push to modules-testing, wait and if no complaints come back then I push to modules-next but in this case I just went to modules-next directly as I couldn't see how this could break. Luis