Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 18:19:16 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Jane Chu <jane.chu@oracle.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "hch@infradead.org" <hch@infradead.org>,
        "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
        "dave.jiang@intel.com" <dave.jiang@intel.com>,
        "ira.weiny@intel.com" <ira.weiny@intel.com>,
        "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi/nfit: badrange report spill over to clean range
Message-ID: <62d0c0947c3e6_1643dc2944a@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220711232658.536064-1-jane.chu@oracle.com>
 <62ce16518e7d3_6070c29447@dwillia2-xfh.jf.intel.com.notmuch>
 <09df842d-d8e4-0594-56b0-b4bb9ea37b67@oracle.com>
 <62cf622a32e1_16b52e294ea@dwillia2-xfh.jf.intel.com.notmuch>
 <8b13446a-65ac-0cbd-6c17-0f9e1cfbb048@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8b13446a-65ac-0cbd-6c17-0f9e1cfbb048@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vkyGGYFi/y0CRXyAhLFGE5hOP7TkIL12OjMTiEmM7d1YydOY31I0Gt/YPWVD?=
 =?us-ascii?Q?ACZqkcYyzsIrTGGaoyAFytAk3g6zas2NJE5LzP7tOivBmMQEsDHJQAO5dBun?=
 =?us-ascii?Q?NpNevyWfE/cJRNtesrOzZE9C+rmLD2PQ4iVGny4nyOFaZbFolAN6Cq0V58SG?=
 =?us-ascii?Q?tMiJrZaEfLHvfWFPh+bXtAzarZEJn1GW1+KjRuyIhRlpbu/V7Aa3UcF3gl9+?=
 =?us-ascii?Q?H8wo31WTnLx6/xWQh9OurfiQJMZprFqzi2SFn5Q2knMXLIA0ObeqicDtsJVz?=
 =?us-ascii?Q?FjCTj1Fd73df+slN4U5fOGrKPxrbLV8Cr4kWcJN1HnqY31KR09tRB76Dw8y1?=
 =?us-ascii?Q?S7tTeOomOuQAS4NFCSLyQC0v81UsFOGr8u5yzPOnU5fa28jdlt677lIE4LQQ?=
 =?us-ascii?Q?nkesH9SpAZtPjMxobPXA6mfp7amF3KHA3/AS2MgvLqJ1vxeqWG9xZ7Kjdpw8?=
 =?us-ascii?Q?5QSBG+HzJNXKpTrpBdeZBl0Lu5Nwfxbxvlivx24fop7dVeAcNPW60jjVF8Cn?=
 =?us-ascii?Q?JJcSrzJhJkctKVAII3YrIR5BABL9nSbVSgZApfwdlZkclzHp2elb1cJHJru3?=
 =?us-ascii?Q?v9KNIedh01HdiV8yg0g1A40DxaqgQyd6dDhUt9Dl4YeCiGjplLt7HyDJUNWf?=
 =?us-ascii?Q?Cn/Rt+qAEJ6JYM3YzXM6/a0CNz5L0DcOOH/awH8OIVV79tXcuTnjLD3mX4zu?=
 =?us-ascii?Q?2wDi+441lkSf+FHSfYvhlnXowQ9rbo68Pc/NrJ7b1UgMpQoZVrzba5A0tFLV?=
 =?us-ascii?Q?11/1dT+AdpMpaiuCAZhK7fNuZwnA77n5wJ+ABZoOUq5b8P6pdwPasBkBXceD?=
 =?us-ascii?Q?2JspnQn5weDEcq+5eaGzioVHD2ldKWN5B3RyOS0KQhPVz3NpNeHdcYSUUAA0?=
 =?us-ascii?Q?HxIDfdRFjMEQnyFpM2vmTxUOiCIO9HtJ+rYu4Qm5A8Tp9Tnc1HL5li44mMI6?=
 =?us-ascii?Q?V3IUuqJNVC4A3zELxn3j9NceFlbwxYAj6imLFcey/at9GTOMxElGvBXPSPd8?=
 =?us-ascii?Q?yzDfYV9YWcTJGqs/4kPihO6lDnNe9iNovU1Oed/OdyCkMgmFSUh+vcMktb5G?=
 =?us-ascii?Q?92ixUY3ePjUy/FPPiKSnLtcHmacZz7IC6kMhigmqsJdvbOVRdjS04FBBcFpe?=
 =?us-ascii?Q?IOIeKwm0E92MZQPMY78ctPylthIrzd3QP3WvxHCS8BfogAr1HEaJ+VkUmdIb?=
 =?us-ascii?Q?ARH2YZK/NDW7D9E6deHAAozaqzl366dwESYuOq8lg+T+JJMeCPcSAK4KFkU0?=
 =?us-ascii?Q?vyY/RL2UcbdE2OGPPxqU3192YnlQ6lgApwhew1wSE+mK4OtwOMNtDCCLX34j?=
 =?us-ascii?Q?Ty8XTxKmnf6Ox3wNdbJCn6yyITSa1ymtDPXnVXTc36fa0lDUCYTrVsvWXqur?=
 =?us-ascii?Q?WZ8BVyvAIKy6S+WUjG/QwD4XAlpzO/8TvuRfrPFM3KFqwUxI8TWeZu3yki2c?=
 =?us-ascii?Q?eLNtNp3gTPDfbaEP/Dv+6k/TNFjvr+LZucUYQJfINfzyUMefre8H0fZhng9q?=
 =?us-ascii?Q?0e7QFcd9hLRT8wujOssbWzOJudFKmeLp0FmiIlIFgLk3X2hghh8GVZJOXLEC?=
 =?us-ascii?Q?1fq1FdZf9dbhHwAvAqqtcZL9ut0uKc0D1FL2DW0kRebftMmE2pOeOfMwQ71F?=
 =?us-ascii?Q?bA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 08b0b3ba-6904-4f6d-5d5d-08da66000a95
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 01:19:19.1659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cVOncNNqtWZYlqr5EBTcwFhg+qCJkcfDnfqmuPAxbzpU9iR3+jGyZYxUIXnaUIRnpZ+g5fg3Us6kd8Onldkg9+BPJJZ/aftUOnn9CxFneNE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5648
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jane Chu wrote:
> I meant to say there would be 8 calls to the nfit_handle_mce() callback,
> one call for each poison with accurate address.
> 
> Also, short ARS would find 2 poisons.
> 
> I attached the console output, my annotation is prefixed with "<==".

[29078.634817] {4}[Hardware Error]:   physical_address: 0x00000040a0602600		<== 2nd poison @ 0x600
[29078.642200] {4}[Hardware Error]:   physical_address_mask: 0xffffffffffffff00

Why is nfit_handle_mce() seeing a 4K address mask when the CPER record
is seeing a 256-byte address mask?

Sigh, is this "firmware-first" causing the kernel to get bad information
via the native mechanisms?

I would expect that if this test was truly worried about minimizing BIOS
latency it would disable firmware-first error reporting. I wonder if
that fixes the observed problem?