Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org, michael@walle.cc
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 2/2] tty: serial: fsl_lpuart: writing a 1 and then a 0 to trigger a break character
Date:   Fri, 15 Jul 2022 10:59:44 +0800
Message-Id: <20220715025944.11076-3-sherry.sun@nxp.com>
In-Reply-To: <20220715025944.11076-1-sherry.sun@nxp.com>
References: <20220715025944.11076-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BZdkulLaGLTuVyukhULiCkG9M5nQu/R8Z4FE8/CGf9L+A4xUT8f0r4QJQ3x0?=
 =?us-ascii?Q?H0RqEhoa+Rd+xkYzCIs8bK7BmN1g6rF+FkA64fPce6AnKIPV0SOCD9ytO6Tx?=
 =?us-ascii?Q?dioa7cFToIqCIcHFFDCxti6Hlk5IQ6nKqSRRhIi9mbg6v8fc7f0XVTmocI+b?=
 =?us-ascii?Q?2Rl8pRcwwko+9Gg20jDTlx1F6WXcX6tJsPZX9cXIFTmgiktz7XKXcAI4uAAi?=
 =?us-ascii?Q?naDBMY3DFyNZKtjvapk1PilmFd6HHD0K+ziedj4FrpgKpjw9YX5iIOfvP4c4?=
 =?us-ascii?Q?WDJYJYHhMbfMAgDBgoeEJwN+J2p0zeQYAwXeKMMdN3Q0oyYFH6h/7FEA2yYN?=
 =?us-ascii?Q?wpY4YgWYLCjmMlRzDEZyd1bLZ1dW/NNfo5je9/4hkK8WtZrOcJfhT9Wv7UOy?=
 =?us-ascii?Q?god7oaPuchnimLflsBdkIBfIHC5wOTCW29rCSBYEdgh9KHwsqINwi+ajdeL4?=
 =?us-ascii?Q?2jD40qveXIoFfxcSU+1yUeIRTx8XAORtt0Udn9FKGaV4nl3tcwLmpwQTkrU0?=
 =?us-ascii?Q?dFrefHT7ASpPvcflYavVArheJHPzyZAVlWELWaeVNAmggOIG8hYFaUZx6Pz8?=
 =?us-ascii?Q?lQYhWd8//hTmRkHrcxP1pUkD8rnappSKiRL5C0Yi/7Y5aM7X9VWzotZ28Ps3?=
 =?us-ascii?Q?Phz5gpsgIxkS/V+ILaCvxsBJHByB6nBcfzyid5vUS2ZseIYecgRjz1EzF7FR?=
 =?us-ascii?Q?oGC9lBcjoRS2SVYfF6TuOzZnSkLp7N3fgNbJOFRFMXu7rUu0D9bwK5Wn5rdF?=
 =?us-ascii?Q?gpZ90LmBeusaHErm1eDWooE4rNghGAS1NXE0cDRH3X49MepcpY0DQlFq8Uy8?=
 =?us-ascii?Q?FKBsKw7VC3NqxT9k5NBr3D+hrZ4wMzIGGx1GsPXJdT67AR9qZrQjWnn+2K5C?=
 =?us-ascii?Q?wABqQK+xZp5IsVuSJ3dWm27RIiaRaaAOXoJWRr0SjWa62h+cB8AUMovN29K9?=
 =?us-ascii?Q?RYHLMyue1jyCXmxEB91tch+taxBOFCqOrne/gOrTsWRXX69Jhys5kQWK60jm?=
 =?us-ascii?Q?FgwMJfqYSbz6784lZhk5cADplxVwpMPLVy47q09ljVhf/6LQWCibd6mdHboq?=
 =?us-ascii?Q?c6XhXN2suIETgiBaglC3QTszuokTUo3+0K94CRi+3hByeL5FDYFgwi5jbyp4?=
 =?us-ascii?Q?GeuaErLkr7yEotUANSgKafzS4RiPeAYh4hrL5Kmk5Y9QKHj19b+1Qd2HwQnI?=
 =?us-ascii?Q?AKKA3fk/rmqQIXVIKoMsHk83tBxF1EHSLoQD3rFhdzR9v98MjXUlFKgvniTL?=
 =?us-ascii?Q?f07qn9/BZThNmgtm3f87ntptTpzven8IpnVSgzdOSuoq24eyNppiTu3ROnTd?=
 =?us-ascii?Q?A+WAS4kckeoSC9dtBNACuCNOexSVfD62SHzoVG0vvrjOLx/XkfCUc5egN0/J?=
 =?us-ascii?Q?y+37mjLN9mqho+gUFXe4hSvGvFbbveQ4S7SrWUwQ3ArY3Is1+xF/+IEw8N0R?=
 =?us-ascii?Q?xNObS0S9y3vspmdGZ6uouem5PlLMzVrtv+6TfhYZCDJhCIuqGy489ViNQ9bL?=
 =?us-ascii?Q?MnO9ue4zzsShqZWg9XL/E+RI1hh6oacVMdOZGrwKNwDuIgJcHSUwQIr+9fpl?=
 =?us-ascii?Q?vE5kU57hAiE9UX1pmxqFx9kGZAoIlaSkGmngDefy?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74d5c18a-27a5-4f19-566f-08da660e4c51
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 03:01:22.5457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JAx8MqOqX+o92VkI1Rj1LiHnRwm48RReYhgqJ8vFl2y9iVEtC6zuVrLFwob26diuUgm+b8VtEnS9LwUQBgVuiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

According to the lpuart reference manual, need to writing a 1 and then a
0 to the UARTCTRL_SBK field queues a break character in the transmit
data stream. Only writing a 1 cannot trigger the break character, so fix
it.

Fixes: 380c966c093e ("tty: serial: fsl_lpuart: add 32-bit register interface support")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index b6365566a460..8a4aae7dbd99 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1486,7 +1486,7 @@ static void lpuart32_break_ctl(struct uart_port *port, int break_state)
 	temp = lpuart32_read(port, UARTCTRL) & ~UARTCTRL_SBK;
 
 	if (break_state != 0)
-		temp |= UARTCTRL_SBK;
+		lpuart32_write(port, temp | UARTCTRL_SBK, UARTCTRL);
 
 	lpuart32_write(port, temp, UARTCTRL);
 }
-- 
2.17.1