Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org, michael@walle.cc
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break characters
Date:   Fri, 15 Jul 2022 10:59:43 +0800
Message-Id: <20220715025944.11076-2-sherry.sun@nxp.com>
In-Reply-To: <20220715025944.11076-1-sherry.sun@nxp.com>
References: <20220715025944.11076-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cXQSnROJlA/59WM95nOpbh6fKBa1pVk/s2C9/Is4BjZbXy0s4RGJ9CtMspDj?=
 =?us-ascii?Q?2qjG+mvnmoJoYNIH1B8WmLzwus33DzXwPz++bIFiC0tSvp8EiFq8OVvdLuFx?=
 =?us-ascii?Q?+OCSmwrY21biNu9pb6vabU4BkOpwde+YOsKN4YYpb0M17MjIc30tPJhP9Q/C?=
 =?us-ascii?Q?orpen434hWa7Ove3j7rynuvjdRbsWW7cTiGE4y1A5cms4qpC6ujGfrcvhat5?=
 =?us-ascii?Q?trXKmbizO0iHx/NlApR6BIICcQMHS5LXZkldN43kklfoIdZbgP4+7VPHTODy?=
 =?us-ascii?Q?zRNHW0NZeAOgMClyiZJGoj8b6CMcv5mTq+7tn7o2Wolb4w9wt965+ohYNr4L?=
 =?us-ascii?Q?P3t7H21bBg1PTNdHRdtA99yE0vdoz4Sa3eUBvUboHXD5wOitw0Mr9MHZ/4mN?=
 =?us-ascii?Q?h8WGA+XYJf27z9DFdT/Ue9J8T2mWkTjSrysn+C93GREsdrDEkwG9+pZFRG3A?=
 =?us-ascii?Q?OJAtkUbZ5nGxfHgorg06hmbNB6PTAZ84cYddFS7caRQdqHHV7sMUTU3dyrgK?=
 =?us-ascii?Q?ZzZT1va4k5tE6F/D9gDaQrO+RWmC4jT+JS+a9+MOOrFFc5edm6rRs6JGQReZ?=
 =?us-ascii?Q?CDiSyC8+NOAilEm1MJCZafArWbEVBShruSRdvUEqXHJK7+sqC27ap3ngwJM+?=
 =?us-ascii?Q?7Lj/j2aTGipURJf7fq+HOr44bXKgH3tQ21pmlJXqPjkOO/HXt8B3+3FGszQg?=
 =?us-ascii?Q?+Z9Bja6/RygRRXEPFtNEs2Pd4mYMI7yBh83w5TYywphJE75SHEAelQBitfwe?=
 =?us-ascii?Q?YNpek3S8uRtXwre9dqYyiYcc6rJj1GoLC40//tumgx/k42tWmh6Wv9i0G1h+?=
 =?us-ascii?Q?3b/q94KVu6T0SMrHt5UgkWyCXoTv4K8ItJ9XwfxUN8f53nSn+yrrXw5e5Ca7?=
 =?us-ascii?Q?RxLioYIFaeOeM/Poj2BroJvWjmSwrbxNEQR4c6a1w9y7+3we0k7uTmAYUfi+?=
 =?us-ascii?Q?WZ3RA6WBZTmUeCJ5oS5pzouqIK3cEPmZ7poGfqblZzGKqy61FBmJf5xuaWll?=
 =?us-ascii?Q?+gGEVa5vjiICorfFoF48VUct3CRHWBH67n+ZjA/sbCV9oGOwMR77vFt4Dnnt?=
 =?us-ascii?Q?B8Te0cr6Wz/zWtRcSn3RS+or7tY3+zVcXzHh0x8nKdlJj0AuPXL3cUK34h4g?=
 =?us-ascii?Q?VPeYOU9EgvNLinFfVnZWjagdv1AldnZmYcs2OFukYOFGVWYnqR/83g3Ub8VN?=
 =?us-ascii?Q?zQXVix7SfKM+CKbRi+C2GX0GtcX8+wytojbDTIiufw3LB9pZGbOd0Y4OG619?=
 =?us-ascii?Q?ctPAXzhyj0JvbcDS7cwRFrWCcpnrkD37pP5pvHBGG6BfiaA3vaU41/hnnbNB?=
 =?us-ascii?Q?lTGPhuuL9cfJkg82auvycT09BylMWwe4yz92lhN4/ZhCGVHFUJ87YlJdLvDr?=
 =?us-ascii?Q?WW8DrrJdsX6JHGsyiw8WzoBZMjdseTAPEgkgMShBd5oXyyIKbIijP34/sdd/?=
 =?us-ascii?Q?w9Mneud0ZOcmsu9+s0p2xHFm5+pVokebQZwf8IuRffeldLcMd+DmF+sEFrHR?=
 =?us-ascii?Q?M7mvbLGC6nuVx0V/1m1JS5FA++isqC5rXQqOw0W4WFNp6HwCS1N43MPzh2Yn?=
 =?us-ascii?Q?AWGVdex1wFcqMuASeigF6gJoahfThprirSMQ0tl9?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9588dc2-19e2-4311-b24d-08da660e4a7b
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 03:01:19.3104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JcpQ904NRd3RAKqVKRSolkg+j/deWB5lpG9WcGx/y93K05bQRFr+UhHR9LjnLmF3uDIdy+FivZW/Gh8a032B7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The LPUART can't distinguish between a break signal and a framing error,
so need to count the break characters if there is a framing error and
received data is zero instead of the parity error.

Fixes: 5541a9bacfe5 ("serial: fsl_lpuart: handle break and make sysrq work")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index fc7d235a1e27..b6365566a460 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -990,12 +990,12 @@ static void lpuart32_rxint(struct lpuart_port *sport)
 
 		if (sr & (UARTSTAT_PE | UARTSTAT_OR | UARTSTAT_FE)) {
 			if (sr & UARTSTAT_PE) {
+				sport->port.icount.parity++;
+			} else if (sr & UARTSTAT_FE) {
 				if (is_break)
 					sport->port.icount.brk++;
 				else
-					sport->port.icount.parity++;
-			} else if (sr & UARTSTAT_FE) {
-				sport->port.icount.frame++;
+					sport->port.icount.frame++;
 			}
 
 			if (sr & UARTSTAT_OR)
@@ -1010,12 +1010,12 @@ static void lpuart32_rxint(struct lpuart_port *sport)
 			sr &= sport->port.read_status_mask;
 
 			if (sr & UARTSTAT_PE) {
+				flg = TTY_PARITY;
+			} else if (sr & UARTSTAT_FE) {
 				if (is_break)
 					flg = TTY_BREAK;
 				else
-					flg = TTY_PARITY;
-			} else if (sr & UARTSTAT_FE) {
-				flg = TTY_FRAME;
+					flg = TTY_FRAME;
 			}
 
 			if (sr & UARTSTAT_OR)
-- 
2.17.1