Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a42658d-5bbc-7180-2d2f-e92541cc000d@nvidia.com>
Date:   Thu, 14 Jul 2022 22:09:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/6] gpiolib: cdev: simplify linereq_free
Content-Language: en-US
To:     Kent Gibson <warthog618@gmail.com>, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, brgl@bgdev.pl,
        linus.walleij@linaro.org, andy.shevchenko@gmail.com
References: <20220714020319.72952-1-warthog618@gmail.com>
 <20220714020319.72952-2-warthog618@gmail.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20220714020319.72952-2-warthog618@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ymp0VThRU1k3cDhDeTBrdzg4ZE1ZRWFBMmJVU080UTRFR2I5OS8zbExiVGNo?=
 =?utf-8?B?SW5IYlBUcGRWY1cvTFFDT2tIMVN0YUI0WnRHdTJPMjdBLzlLbkg3T3lKa0VV?=
 =?utf-8?B?QU1aaHRUVUxIbk00dWV3NjVZNGpNVi82YjhoZVlkcTIrWWpWc1RLcDZZRDFS?=
 =?utf-8?B?cWFpdnZiM05kamlGTUtsaTI5REUwMWdnOTlLeTVDNUtIZ001Sm1KRnE0YjBs?=
 =?utf-8?B?Mit4WlZWdGZLdnU0UTdNQWNyVzJUa0NGTEo1R1p4djdHRnRFR2t0NHp1bG1z?=
 =?utf-8?B?UmJJRFhCdGVjaFdWUlMzSDU5bnJKVjMxdmQraVVNYk50Tis4ZlRYbW1mZ0l0?=
 =?utf-8?B?Umg2eSsyVDVBZmRwSHlSU1hTVDdGRU4za1k0cllLeW9vaythNVQwN1p2dy93?=
 =?utf-8?B?U3NXTDFFMklFVmlrcFhiYThWeXdzWjUxSHA1a1FzNUZXdnJBOG5ZRkxwb2Za?=
 =?utf-8?B?WmVXM2htWUdzeVA4VHRIZ1ZyM2Z1Z2lDQjZWbDVleE5BSGk3SkFHRkNWSGRy?=
 =?utf-8?B?c3hKNVNiUU1YcVRzMjJGckM5OXFPeHQ2U1JSRWQ1RzMrREFQaEZXQ0RFZDhB?=
 =?utf-8?B?ZktneXJkZWQrL1pUTXVxWEFjaURGcCtqMHBROUtoNm1GVnR2WVZQdzZyU0FE?=
 =?utf-8?B?L0NrRnJjOGdsZFdPT2ZiaStNbCtTV3pOa3JxV1F3QnpNa0tUdER2a3V0aU9l?=
 =?utf-8?B?TkNSb1ZhQTZtM09ZS0ZPWHVBL3pvb3FPRDVuVGRlWkRhWHAxandEekwzUzhh?=
 =?utf-8?B?bG03UHhocjZva1djMHFqN2tkSG9jS2JZWGIxczBpakk3d3ZSTmxlQk5YVEdr?=
 =?utf-8?B?Vzk3ZFBWSjkwOXFBbG9hOEdsVEZCMkg4NmNsMnVrWjdCaWJRaC9TY0hDdGV0?=
 =?utf-8?B?L1Z0N0VjVHV1dWE2dlVQekFmSzZlTUt5cWlwcnhYUUxxc1NwV2R2K1Q5ZkF6?=
 =?utf-8?B?ZWJRM1ZqMTEwTVBtM0c3Snh0S2o3ZlJ1OVNjckpnQzMyOW1SOTlHdlhZYkli?=
 =?utf-8?B?SWNYaHpBK0FncGpNdTVuSXY0Z3BZSEdOOUYwZUswT1Z3SVkrU2pWWmd0VHJQ?=
 =?utf-8?B?ZXQrcU5aUTFDVlRqSTZCNUswMU12elBsWm5RcE0yVExjU1U0cG52RWowZktE?=
 =?utf-8?B?eHJJTFpWQ2lsZHNDV0tvZ2hTRm1ETXcvM0xtV002TGtldjFsU1BMYzBKUGRt?=
 =?utf-8?B?dGVnTW5ZL2VDcWZ5U3JWYmV5ZGVacWUwUkdvR0FoczZHT1U3OEl1UEZBNzdu?=
 =?utf-8?B?RWhwdEU5ZmdaWGpwOC9qYmJnUm5nYndzbTRuRE5IOGJhUWlUT2FLZVg0WDBP?=
 =?utf-8?B?SzJMQU13UlBRRXFJZkZWclRYa1ZGQVI2R3ZvaGZWckZ6c3BJVTlORUQ1bWRl?=
 =?utf-8?B?bXRRMmthSHIxZVNoMG1SRTlhaE9pTGhNMDcyZHdDZ0tzWUxwbnE1MENtZjNw?=
 =?utf-8?B?VEhRZE9LdmZkdFYwaTBWd3RneVQ1UjRzVjRLNndMbFg4Zy9BRlY4SzNVWFJ4?=
 =?utf-8?B?OFhmMS9Kb0VJY1NweERBZUpnd2Y0Ym9tNmJZYzliWENucTg1aVRJbHdwNGZJ?=
 =?utf-8?B?ZDlsWTcwSE15QmJYMTBLN0g0NEduRUFqUlJYMUYzUko0QW0vZDl0YWY2YXhm?=
 =?utf-8?B?QXFuZHN6cWlGekh4RXBFVHB4USs2cWtPNW90d1hrUXFxV2dCT1YwNEhRVDJr?=
 =?utf-8?B?c293OHEvZURPc2hPYW9VRFQybTdRaTc0dVFmNnNrdnVMZGdvYlZJMExObUhm?=
 =?utf-8?B?REdwaUxjMzA2N2RNbHhkb1JpbXNoQzJkWGtiN1pyTmFGNkVnYUpGTkZOMm5N?=
 =?utf-8?B?K090WlptSWFqd2lqcmdyVmZYWEdrUWo3dzJRNTROYW9GS3kvaG9ucDZtdkY1?=
 =?utf-8?B?NWc5clptY3gzM3pHeVVNUzNyc3U5YUhRYzY3SXJPdUpFbFM1RERVaUFYNWpC?=
 =?utf-8?B?V3doNlIxUENlUlZERDMxbjBGTTU2RGlNU1A3cElVbHRwbVZtdzVKQkhCM2dB?=
 =?utf-8?B?TFJKN2dLRjJHZk04eklOMW9ISCtKL0JSWko0SGYvMWJ5TDZhUk9TMzZMQmFY?=
 =?utf-8?B?SitkRURKcklVREFMSFU3SnVGYXNZRFM2MnFLYi9jOGNLdVlDSlhmUFAwaFBN?=
 =?utf-8?Q?TSQmfn5dbtmNIaE8DTgsG9/bc?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a44100f-48f9-47ed-7d63-08da662030b0
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 05:09:26.9612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iNsHBAjL7KLGn9ohvdSlkJfXohZa+ruo8X4aHuooLvC8M6BhnY1Uy81hPj91bykNYmX3agwlEesoensQ7KsjAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0196
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/13/22 7:03 PM, Kent Gibson wrote:
> The edge detector is only ever started after the line desc has been
> determined, so move edge_detector_stop() inside the line desc check,
> and merge the two checked regions into one.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>  drivers/gpio/gpiolib-cdev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 0c9a63becfef..b44526e3630e 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -1460,15 +1460,15 @@ static ssize_t linereq_read(struct file *file,
>  static void linereq_free(struct linereq *lr)
>  {
>  	unsigned int i;
> -	bool hte = false;
> +	bool hte;
>  
>  	for (i = 0; i < lr->num_lines; i++) {
> -		if (lr->lines[i].desc)
> +		if (lr->lines[i].desc) {
>  			hte = !!test_bit(FLAG_EVENT_CLOCK_HTE,
>  					 &lr->lines[i].desc->flags);
> -		edge_detector_stop(&lr->lines[i], hte);
> -		if (lr->lines[i].desc)
> +			edge_detector_stop(&lr->lines[i], hte);
>  			gpiod_free(lr->lines[i].desc);
> +		}
>  	}
>  	kfifo_free(&lr->events);
>  	kfree(lr->label);

Acked-by: Dipen Patel <dipenp@nvidia.com>