Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <634d07cf-596d-c116-df41-3e4ad05179c5@nvidia.com>
Date:   Thu, 14 Jul 2022 22:10:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 2/6] gpiolib: cdev: simplify parameter in call to
 hte_edge_setup
Content-Language: en-US
To:     Kent Gibson <warthog618@gmail.com>, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, brgl@bgdev.pl,
        linus.walleij@linaro.org, andy.shevchenko@gmail.com
References: <20220714020319.72952-1-warthog618@gmail.com>
 <20220714020319.72952-3-warthog618@gmail.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20220714020319.72952-3-warthog618@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWpaekFzWGoxZVVQdlhmQUFVQnJPcGJZSkNPU2s3MU1qNGhpcFZiTUV5Rysr?=
 =?utf-8?B?ZjJQVHpCWkswZzByMkhJajI3ZDB2c0hUMnF2TmNla2lSZ2lmbGtOYm1JK3hV?=
 =?utf-8?B?VlRRRm1pZG9uNW5HSjZQVW0wTk5XQXdYTHU2cnJoVjB0Q2UrYTVnUFBiTGxj?=
 =?utf-8?B?WEtWNHFjWFZEcms3N09mUDJ0YUpWd3RuSElDaEd6WWpjNUhCL0ZKSHVGR2tX?=
 =?utf-8?B?WFVESi9SYTZtZU9EOFY5UU5OQUZYRzlsYzRneHlIdTNVQnkzMzl5QVRXaWhR?=
 =?utf-8?B?TlFVa21NcEQzUVE4VVhYaHBNeGppY0lZQVc1NjVocHhmb2l0dC9Ma29ZL1hY?=
 =?utf-8?B?b29VcGsxSEZuQ3h4Y1hld09RNDgyUDZNdUt6aFRiZS9vRmMxcW5qSWNGRXI1?=
 =?utf-8?B?TVJ0L0c1aTIwZzFiUDQrMEJjVVo2QndEZjJUc2s5c1BqamtheVJoY3NkcTNJ?=
 =?utf-8?B?bWVFS1hnMWtxWVR2NkEyRU5VUFBwYTFVeHY5VzhpRTdoTkx0MXFMb1RmNXdI?=
 =?utf-8?B?aXlqR3BNbWhYSU9iVHg5MXl5TmQ0WndkanlvK3pROGQzWXNYRVQwMkFsN0VZ?=
 =?utf-8?B?encwQ21FZXBJVnhkWEY0ZGNBUG1saWtqSnY3cmFzQ0JHNWdLaEtJanVYYWRk?=
 =?utf-8?B?ZVl1RGt4anNPYm1WRGFCRWVnWjB0TTRxeUsyRHlLSmEwbG9BbjlxdWJxZFVU?=
 =?utf-8?B?VzJOMEtrMm5URncveEVHYmtpZEVBZTE2QkJRaG5FQjJoSFFJR0t0RGZPTUVO?=
 =?utf-8?B?dlJHZUplZ0hIclNrYk53Mk12S01Gd3NXODlaeVNzRmRXbFNyOWUxMVJ3QlY5?=
 =?utf-8?B?Q1VuT3lYMCtxNUZwelNPMkRUbU8xay9PWDhnVmJSdWY0OWxSb3paWEdzZSs1?=
 =?utf-8?B?bGVRUVBYN2ltSXB5REExRGQyL1IwMjAwVGJidVJsSWt2eFlxdUo4REJ5YUhn?=
 =?utf-8?B?Y1RWQUhpQ3NpZGpsclN2Yk9VNVhBUjNIM3ZrVDJBK3hLM1pZZzlGZWZYNTZW?=
 =?utf-8?B?SjFFZGpxbGJ4ZUtKVUpNNU91RTlYNVpKTlBzTXgvZ240bURpdUZyRlJSdDBK?=
 =?utf-8?B?ckVTckhTRy9hdnR0eUVvR1hNOTN2MW1BR2h6ZGQ3SnIwMlJTM0FnOXA2YzFG?=
 =?utf-8?B?Y09YS0I4S3RHZkpZZHluWDQ4eWxVZnJLR3Z4a2QrRUgxL3JpbEZTSlg2NnhI?=
 =?utf-8?B?dzRNU3Vpd1NuZEhua0QrVTlXTlUwTXk2RGZMTXpzSHdDQW5EVmZOYUVzZ3l6?=
 =?utf-8?B?bU9xbzVmOGpoTS9jcDRQZTUvVWlrS1ZmampLZnhFK2E3S3I2S01oVFFpTURB?=
 =?utf-8?B?aEF0ekpyMzh4T012ejdKRU55clJYbllYaStWdmkyTnYrYlRRU3BGK0tnM3ZS?=
 =?utf-8?B?eE1uSmp1Q1k5cHNOY1Rna3JGOVdtRmtTRlB4a3ZMWWllRG50WHVIdmUzZUsy?=
 =?utf-8?B?c05Rd1NNLzNaZzQ5VklLdWZIMlEvMWFFa09FOXh1TUtCQ1hZRzBoQTJ3aHdh?=
 =?utf-8?B?Ylg0UFlyd01IaFIrK3hRRmtGZFVPQm02Q0NTU2RHdHRIQzlMclprV3FCb21K?=
 =?utf-8?B?aTF2YjV6NXlidjMrR1RUT0pSNnBkTjhGd3M4Tnd6LzBHaFdJYnIvdC8vdEVJ?=
 =?utf-8?B?R243TkpjUmYxR2JDaS9YcnlvNWo1bEx2cVBDWmdMSWNKVk55K2F5cmsyZ05a?=
 =?utf-8?B?UW1QdUdlUnRuZFNKNkZuQzJuM0xDUUU1WkVwL3ZzUGluRE9MS1dsYXo1d2Zi?=
 =?utf-8?B?cXhMV3Y3QUVUVDB2dVp5MldJc0NuM2lEOEZSNVZsZzdoQXErSmRBNlJ0eFo3?=
 =?utf-8?B?SDQ3TUltNG9jWXlRTmUzSkh2S1Rac2pqc1NXb3BJR0E2a0VnaFhsZFJEU2t1?=
 =?utf-8?B?bkw0Vi8yL08yd1lSaGV1ZzMxUmpFNVFRcDNZbm10YU1LMHlzbFBZbjV4c2ky?=
 =?utf-8?B?STNIa2VmTE1TbTZDS05nY1VNY1RrcFdVYTJrSWZNdGp2ajdwQ0FvWHh3MkJs?=
 =?utf-8?B?NU1Zc2lQMmtUOXk0a0l3NENoMGZ1UzlIVkt3TGdhMTZqVVJNeHUrc3N1Q2VY?=
 =?utf-8?B?cDUzUm5RRjd1M3BNU1UvNHFuOVU2dVh3RWRwaDNPSSsxa2FHUmFoVFRndkk5?=
 =?utf-8?Q?GqKcaauSYNfq4Y35lhR3MgK2m?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c178d22-b5e6-407c-562e-08da66204869
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 05:10:06.7602
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vdy3PD24qw3WRqB8FYc9OhJe15W3nWS2HObeFxS71AlNBgDPuaxkf+Aiyzxso3jIguph9tvEvzsAdODnFokpJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0196
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/13/22 7:03 PM, Kent Gibson wrote:
> Improve readability by using the GPIO_V2_LINE_FLAG_EDGE_BOTH instead
> of combining the rising and falling edge flags.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>  drivers/gpio/gpiolib-cdev.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index b44526e3630e..f635bbbb6a6d 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -885,9 +885,7 @@ static int debounce_setup(struct line *line,
>  				return ret;
>  			line->irq = irq;
>  		} else {
> -			ret = hte_edge_setup(line,
> -					     GPIO_V2_LINE_FLAG_EDGE_RISING |
> -					     GPIO_V2_LINE_FLAG_EDGE_FALLING);
> +			ret = hte_edge_setup(line, GPIO_V2_LINE_FLAG_EDGE_BOTH);
>  			if (ret)
>  				return ret;
>  		}

Acked-by: Dipen Patel <dipenp@nvidia.com>