Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: amphion: adjust the encoder's value range of gop size
Date:   Fri, 15 Jul 2022 15:38:00 +0800
Message-Id: <20220715073800.11321-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iJMb8+y+VZBHVe995BPS2z958LThxN3qfd3VgmxYh3K/BaXCg2EvvWPs+w5V?=
 =?us-ascii?Q?jsmdyHALiTLvE4lCSHFiQgFSqSTd/ZXbLBq4wDgSKuUq1H0Wr8C27dK2B3lT?=
 =?us-ascii?Q?cKPdm3W573OyctRltjsNr6DHfVH8TWYp9E/f+IgnbClJKr40BwswlX3PYR9r?=
 =?us-ascii?Q?F07Icnk/Y/NnHBwCrxlz7fkE8V2S85Y9N/sGUgY+XKSRC8r7BEyjVpVrUDRM?=
 =?us-ascii?Q?MGLnHs0CfCh+vJVvVcZoQXzCaKVVIcw6R3Xo9jKYZ2uaDR4lsct/WtAVXBMi?=
 =?us-ascii?Q?Axf8XnYlJNuOKNO0p7tx2aDI1wAGYg1FlEgBocMcnKZmq9He6P+UyIpWYZbd?=
 =?us-ascii?Q?S+Jw1KDVvfuCbHQJY8oki6bu3lGQHsPpqcml5btsgLwBcEZmn11KoKNy5eUm?=
 =?us-ascii?Q?AM/IceKLSYa9TLlhR7XnOpBmXG/n/JHiqoTcL8alWMKtLWa1THu5KY3xC44X?=
 =?us-ascii?Q?XNdNNyYfeNZw1MuBNHvFF9p03dUmful5weMif/pFUWJ8GXDsdvWJLpVpX3mB?=
 =?us-ascii?Q?mHTo8nsVjqfDKKn1XdzMUUOBANY84qPMGShjiQcUAvj4v4SF7qJIBA1gtwjb?=
 =?us-ascii?Q?zKY536UwDtdznPsy/KzWLHJe3aY8yWd3otsdPb6XtLzu8NYjmftI/afXujxu?=
 =?us-ascii?Q?Gtw4njPfqweI3XYKwYEAhphS4y0BMoAAb50QjlGFX0JT/Rt3pjIEFtGWFXoL?=
 =?us-ascii?Q?B8a5HlRql3pOwka57jhNTbtxz9i8zJtP0gpuVNqk3EnUZPZaHjHOnUdi5dXP?=
 =?us-ascii?Q?R7EcmtP5QbjkwnYO7hkmMNxAAX2mwqkKshFD9kO6Ri4BFb7BTKCEIvHOBYqv?=
 =?us-ascii?Q?aEfM6dCu6bzLlZdC2r6jrIkCKvzXA3XLpRRXmiaMPxMhSGo/RcO4xc6lFYnf?=
 =?us-ascii?Q?RrVERZa2mWP9GWMsORd/Z2cHZk9VsmsBK+GRHujJaQ/nDG50gjAAvcQfgBlv?=
 =?us-ascii?Q?I4vTTsW/7PKqgBEhKnauq17wO9XTulRwOZ2BUU3aeK0FVkMVF7Aav32/8bm3?=
 =?us-ascii?Q?VSdG0FJbmPZcdyZVNXv5EEe5K7WDQPli82zq/YYMLaBquyWQqTbPnIYHgChC?=
 =?us-ascii?Q?lEAbni/38Obqi4vWFbGmUZZkru6bmAJ1n7CPfw4teriJ5vKm/QsJO2mUHA+b?=
 =?us-ascii?Q?+KSxG7yS06Km+Ulsp8tI5iVhNgWumJJFKfiwqrSC3tgq6xAvWVaMtZGYPVMR?=
 =?us-ascii?Q?/72GIf/Y5nKBDiCoYWUfpXiyEcQ3RxyThzVuwsBxe+5WqriuphxAk30fbBJu?=
 =?us-ascii?Q?83vE5B2NLi34C+rH0P1VuoXlkwENekrfnNxypnvX0O4Oe7Kfv5WcVr0mU5ie?=
 =?us-ascii?Q?Kdu2wzVXWJ7Nw8aYTA0PKViQEZA8hTjMLHSzpmtatepv3Fh+e/tPjvwRLDIL?=
 =?us-ascii?Q?GkX9MfgVQc/dCWdGBCmUIzTXMozLu2Djggu9iUlCrSOXpkZ1MLOLwK+yLFvO?=
 =?us-ascii?Q?vEbWJltIzzZ8DJs1tLPiqfSkEyRH6FI/jMYqhHhBqfyua3s040dsx4CF/hSZ?=
 =?us-ascii?Q?cWLcjobeNHzN9mXClUMgPjSdKqZDU7Ocufu+G8x+8truDGmTknuImGz8y+Ni?=
 =?us-ascii?Q?/dLoXwJq8Z5zICXjuGj2RXA2nmaQOBehQiQX7J0I?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9507227-a1d2-4f9e-e8a7-08da6634fe0f
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 07:38:22.6102
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FnMzM53jHt4r0QRv5fyykIu0Py/KJ1urbY9bYMMMFWI1gagqoANEawoy54vYYf48NAxXqbnsUdKJ0rcxrd5ohA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6615
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

adjust the value range of gop size from [0, 65535] to [1, 8000].
when the gop size is set to a too large value,
it may affect the encoded picture quality.
so constrain it to a reasonable range.

Fixes: 0401e659c1f92 ("media: amphion: add v4l2 m2m vpu encoder stateful driver")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/amphion/venc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/amphion/venc.c b/drivers/media/platform/amphion/venc.c
index 461524dd1e44..37212f087fdd 100644
--- a/drivers/media/platform/amphion/venc.c
+++ b/drivers/media/platform/amphion/venc.c
@@ -644,7 +644,7 @@ static int venc_ctrl_init(struct vpu_inst *inst)
 			  BITRATE_DEFAULT_PEAK);
 
 	v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
-			  V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);
+			  V4L2_CID_MPEG_VIDEO_GOP_SIZE, 1, 8000, 1, 30);
 
 	v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
 			  V4L2_CID_MPEG_VIDEO_B_FRAMES, 0, 4, 1, 0);
-- 
2.36.1