Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     Michael Walle <michael@walle.cc>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break
 characters
Thread-Topic: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break
 characters
Thread-Index: AQHYl/co04hpCZj99kO2L0tD4LHyy61/AMiAgAAGGnA=
Date:   Fri, 15 Jul 2022 07:22:18 +0000
Message-ID: <AS8PR04MB84041C0319ACAC555AC89BF4928B9@AS8PR04MB8404.eurprd04.prod.outlook.com>
References: <20220715025944.11076-1-sherry.sun@nxp.com>
 <20220715025944.11076-2-sherry.sun@nxp.com>
 <f480572d82310c3ed14e476b7cfbe7f2@walle.cc>
In-Reply-To: <f480572d82310c3ed14e476b7cfbe7f2@walle.cc>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZkoKFRwisUQ90YVhsrXnliB3myfvvoQvaXtCN7Qh0WW1GFnnllF7HlTTU6Dn?=
 =?us-ascii?Q?ltPYThHsGOMQ7/gVcvKVe6cUMz7BWEeUZUgqfTU6FY/OZ3iBP56fa7g7RAO2?=
 =?us-ascii?Q?WzbhW62CLLjuZYsehq4Pc1ibNMHtNZ/SlZzi7lzqBdKI34OZrbF/2XtYOMwu?=
 =?us-ascii?Q?FvzeAtcNoNOj/pC7c9OXulS+I6ag+4lX9Yzbeb0xp597XXH5/yVwxxtlN+3S?=
 =?us-ascii?Q?HtxHhkyGUrKojxX9EaHHYv56y2ss8hNzT+tqzO6RaG2ZXiaiQfmv6ftPq0p6?=
 =?us-ascii?Q?TLHhjtZ0kOxowaMdBfWa6CX0CwQVm7cLUJ4aJK0cpEffJr8MZZWefR5syzFf?=
 =?us-ascii?Q?vwUwpS6HYacSRaYYQMVyAQF7rxOjuIITa8LtdzN54T38u1VEThpPmvS38Ed6?=
 =?us-ascii?Q?jDsBUWLmjG8RtKXPLLjaHk7Nn/DI+1vopanuB1sVtUHi9lSCDtkuUSQmEeTy?=
 =?us-ascii?Q?WStiND7BmJ5uLbqhedsW2EXRNcyXaOCLUtEB431jBUUbpk6KKGqWG/0zVtYo?=
 =?us-ascii?Q?fXAEfEQZXFLwKsFr+YxkgGyASqPW3HtP1wMHEPYc5YEcVN5dyptGc8M20Gwf?=
 =?us-ascii?Q?UPMxMoCv30Y/S+1e7St4Gqh1jUitmpaQW+ILj2umjbMAOTCjzRoLWNwO4Fux?=
 =?us-ascii?Q?2FbEHjifxi+Xm25EpBT2Pdun58c55ojxs0WEgagpaxERLUZSTuDjyE9epfd9?=
 =?us-ascii?Q?GS67ufQvmxiq+q5U7vbxy9ydlIP3+6xs89IcoT0nYQrjTfCdvksFIbcyNeIO?=
 =?us-ascii?Q?JPJIcwuFAgsNyzmCTFUt5ggEWmwQmsBX0xesnPjlSAw8XDXkHWgkYkxcPVDD?=
 =?us-ascii?Q?AC6DjgmfF7uhnPxI4bIaKXBJW8BpJlyOJsY8i4cCa3xIh8Qw2AkdOdFIHGdY?=
 =?us-ascii?Q?7e72/vryCx7ZVGhpKqchk+pYi8Hy7NLGLBB2iomwWiRurMON1l0pE4IdWF0q?=
 =?us-ascii?Q?O8EeRHUZswQophta3GC0Xes2v/1A5qJott4kBn/ltHMDGzKNfmUgDR4sRlcW?=
 =?us-ascii?Q?pUKO/+C3ZgvKbF2TP8GryXAhNx6tXKCBt0gqBCmH+PsuF1hyhNkiJddlt8WV?=
 =?us-ascii?Q?vUIaW27FWEdPprh8bhu44zpQa0RpMf6HIZiJl+vQ+ibLFjn+jj2a9b/1AI+P?=
 =?us-ascii?Q?+XCIH8e+/x7MLGmo4MGkjSZYhPRZXs8VR1KPMAke2NttoC+HR1QxuSIZFK1T?=
 =?us-ascii?Q?p+dU4J/2ojuvCWBe7/mWdVs4s8DRtqgY/z3h5irthsRhjDHIuJVqOBcnESjI?=
 =?us-ascii?Q?0BdhW3GT32l+RBmm1cFpCbCi8WXxGh5qQNylaRI4rTP3BiVlG/jf29V/u6AY?=
 =?us-ascii?Q?JmSWOHSe4HLjXl1GXqcwY7g7+ks+AJjd3C+N87C8UiCJdKWY+FDsRy3FTwEb?=
 =?us-ascii?Q?8i1rm/1WCrJpSDkUnpid3b8rmGDAPeSGzxWH0/dQaOxGgLZWDEMQ4b9dmKDn?=
 =?us-ascii?Q?JQY2L1ZJfDKv0SER2InJSaCV2plxP3z2lp9ISwJl/6nXqcx8IOE9dfKx91Pf?=
 =?us-ascii?Q?lW/9mMNLpjftnpSl0Fk2kstNY2lozNBE453Zh3Jo29ulrBZ/6bMJNCY35rlY?=
 =?us-ascii?Q?UWkKwUY/1s8Ul4y0RlwqwZF5untpxF3w7RYVEcFc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba5e99a0-6091-45f9-924d-08da6632c07f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 07:22:18.9705
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: n3hrWGG2xPIOCBIngYbpPh29uc5NDDt/85J5HFY1G8t5nG8Pi/RiRwGc8pDWrF1CEXmBnXiF1lidRtdcoUu9uA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4930
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Subject: Re: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of br=
eak
> characters
>=20
> Am 2022-07-15 04:59, schrieb Sherry Sun:
> > The LPUART can't distinguish between a break signal and a framing
> > error, so need to count the break characters if there is a framing
> > error and received data is zero instead of the parity error.
>=20
> Ah, it seems I mixed up the framing and the partiy error. Did you test th=
e
> break in the receive path, though?
>=20

Hi Michael, yes, I have tested this, with this fix patch, the sport->port.i=
count.brk is correctly now.

Best regards
Sherry

> -michael
>=20
> >
> > Fixes: 5541a9bacfe5 ("serial: fsl_lpuart: handle break and make sysrq
> > work")
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c index fc7d235a1e27..b6365566a460
> > 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -990,12 +990,12 @@ static void lpuart32_rxint(struct lpuart_port
> > *sport)
> >
> >  		if (sr & (UARTSTAT_PE | UARTSTAT_OR | UARTSTAT_FE)) {
> >  			if (sr & UARTSTAT_PE) {
> > +				sport->port.icount.parity++;
> > +			} else if (sr & UARTSTAT_FE) {
> >  				if (is_break)
> >  					sport->port.icount.brk++;
> >  				else
> > -					sport->port.icount.parity++;
> > -			} else if (sr & UARTSTAT_FE) {
> > -				sport->port.icount.frame++;
> > +					sport->port.icount.frame++;
> >  			}
> >
> >  			if (sr & UARTSTAT_OR)
> > @@ -1010,12 +1010,12 @@ static void lpuart32_rxint(struct lpuart_port
> > *sport)
> >  			sr &=3D sport->port.read_status_mask;
> >
> >  			if (sr & UARTSTAT_PE) {
> > +				flg =3D TTY_PARITY;
> > +			} else if (sr & UARTSTAT_FE) {
> >  				if (is_break)
> >  					flg =3D TTY_BREAK;
> >  				else
> > -					flg =3D TTY_PARITY;
> > -			} else if (sr & UARTSTAT_FE) {
> > -				flg =3D TTY_FRAME;
> > +					flg =3D TTY_FRAME;
> >  			}
> >
> >  			if (sr & UARTSTAT_OR)
>=20
> --
> -michael