Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Jul 2022 11:15:20 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Steve French <smfrench@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>,
        Yu Zhe <yuzhe@nfschina.com>
Subject: Re: Is casting a void ptr to something else considered bad kernel
 coding style
Message-ID: <20220715081520.GX2338@kadam>
References: <CAH2r5msuc3-1V+dh5NdwnE6uBoN+7_cf=m6kwrFrTnwArND0LQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH2r5msuc3-1V+dh5NdwnE6uBoN+7_cf=m6kwrFrTnwArND0LQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XSRp6c60fqmB+dRG1LvwNn59pQKdkpKP+d4RrWQSsLdvge8EGGqIrnHvy1hv?=
 =?us-ascii?Q?INb8BFxw8+XO66DqezDLabKRk+mz0/LjeZoepG7gpnUY/wfvaTiAgKhE2/C+?=
 =?us-ascii?Q?36w8MXT5KdEhIpAHtNoXFeKc6xa/cz1LrOuC+eS8QS5A7PdgCQsULNr6UAYf?=
 =?us-ascii?Q?+/vYsVAbYiFtDIGYaVkfliRnDOqghYKL+KelRyK3VDoZSl3Th77oYtJQFnpc?=
 =?us-ascii?Q?o6pJrMewfF5gAV01/akz3C/7o8xRzQDjw/ervuWj7i7V34/DV5oHGeZmOWEL?=
 =?us-ascii?Q?GfzBtA1LS19Tmy88sqERsl7wfR6nR0qY24V/+ebdcAVr2hVgObOwREaM5Qlw?=
 =?us-ascii?Q?tU7DKlK0IoLpFVU3WhwL1SKM/i/Jm13zwCHfbBvpQhfZWC+TnrpTQI9BUlBw?=
 =?us-ascii?Q?DDonQP9EaijZ02IQHo7HKyrQw+EdUeGWZdNXPWpje5lJLFoAJLsMrwRXj/Br?=
 =?us-ascii?Q?j1dsZLdBzyGJ1D7L0L2Bm71SxuXgnV+/Gl/mDZvXatGy9lSNX+Y3GnWMYZEv?=
 =?us-ascii?Q?D8XPi4cef/4nk6giHPoJJBsBXaC3gO947o9No3avb+OK8/NDzoKcSN2t/B1+?=
 =?us-ascii?Q?3eat0kWB+VqhYAXPtxD8j7aPPiHPC0W9o1eIZq3bE33BhEQ+qz+7Ma8nwKcH?=
 =?us-ascii?Q?3FLtJcID5LYg77U3c1CfXViU2mbI8lMIHGV1b6VO0rzBxIig/W0OTsrqvo0D?=
 =?us-ascii?Q?QacfpJLh5gRcyrocjK1bH9BaN1DaErPZoEPAqmxIWOS7Auq96s9EjXfpLUtF?=
 =?us-ascii?Q?UvNtyf2UO1mfakUyZDlrMu/uYw0S+TFKz4+CD7sNpIPzCa5B2MwoKModv5fQ?=
 =?us-ascii?Q?vv+K849fitnfxObNKGM6FkKWm2OAoMIHKos61WDnyfpcBnKIprnrLU5sqL0n?=
 =?us-ascii?Q?a7J/6UxVhbjE/QltrRKC+x7lxEBLz87yI17d+7SLLz4CedZhVrlK9gfWmssy?=
 =?us-ascii?Q?4hZI0rj4sUiC2BMK3hNjy0Peai4z74pGEvodRHgRNuFB+refIdIPA0XWjMn5?=
 =?us-ascii?Q?anczKcshztF9K+Qaxp6caPEw2mvLtAgGcGRNTg4iv9dekafA4WllOiOaPOq1?=
 =?us-ascii?Q?1JU26Xv/988iWaXNxt6Uk/kcZrYH/j77hJyCFAwN+Cv5+DaNhfiNQXWzscf6?=
 =?us-ascii?Q?7JF1siFow0YintJd16UsPvYZ+pPVmb1IaVwsxE+H1mf8V9O8AWucrP179t3A?=
 =?us-ascii?Q?JIOGTzkubr0UgZvJIW3buhq1yRHXnTJgxjSLPokD7DEahhp8IqP3m+MhdUi2?=
 =?us-ascii?Q?aBTBAfMrSo4mJCWSjaEq1FaUp7OLUW/pG+JINZAYDHpM0NIF2nHq47p0Vcef?=
 =?us-ascii?Q?jF2YDc0HGBUhF2u/1NJUlyF1a1KCBFZxx4FSRk9IOYvuFp6ddHrCc/R1yygw?=
 =?us-ascii?Q?BZvnziY2kD9gE5XG6oeP51VEt4G+L7pgr8/4h/B22Pb/E/8QPq5TyaTlt3V5?=
 =?us-ascii?Q?datP1WCbNw7bA37eT9ZzLyaRKkH8E+8taRdGDpHwoizmdxYiUWfQpj5JIi+/?=
 =?us-ascii?Q?6a8ZrmT2V41EYg2vhlWB1mbZRHrTXUUIswRXvOxhGNF7O3vzlJ/EiYBEMRbM?=
 =?us-ascii?Q?8/LFnZJJ8V1vZQQmFzKn9ilmmomHQve0Si4eIpMaKEUBYTpt+XKh4nAx/DRN?=
 =?us-ascii?Q?Dw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63788aee-d473-4058-756f-08da663a3491
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 08:15:42.6647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8l53yknr/8oIgbNLrssLABEYur3kQB/paBqYcidAKgS+n5I7b1E+6K03U5uVOJYJxO83Sba/C7tc5bk3S2BnXU9LtNIH0NjNeypjv+jFPnU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3459
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-15_03:2022-07-14,2022-07-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0
 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207150035
X-Proofpoint-GUID: 8DD7Ydu4t9UzDKKbtAetWMCwpAek9QPW
X-Proofpoint-ORIG-GUID: 8DD7Ydu4t9UzDKKbtAetWMCwpAek9QPW
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 14, 2022 at 05:00:19PM -0500, Steve French wrote:
> For examples like this where a pointer which is (void *) is cast to
> something else, is this considered bad coding style in kernel C
> programming?
> 
> It may be that leaving the (unnecessary) cast in, although it is not
> required for C, makes the code clearer in some cases.
> 
> Any opinions on changes to remove casts of void pointers for kernel
> code (which I have recently seen suggested)?
> 

Pointless casts are bad, but the churn is bad too...

regards,
dan carpenter