Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp246088imw; Fri, 15 Jul 2022 02:17:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vPKRX167YcD3iBwBzkNRamEzzyvsPrUcr+psE1dnLrBilDwvMzk/CXlU5EbblqGCG64nqZ X-Received: by 2002:a17:906:14d:b0:711:ff36:b1af with SMTP id 13-20020a170906014d00b00711ff36b1afmr12634287ejh.422.1657876629381; Fri, 15 Jul 2022 02:17:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657876629; cv=none; d=google.com; s=arc-20160816; b=HTvdDZhYNdzS2x1AjdxbyF8lk+g4nJAJuQIQ+6qPuj3Kt+l4hQBIDmFF7FrzNwO1mL MgMQpgZMvfvrivaQB6guSG7XrgeGY0MJWYRLXCaxpoumiUT1xJSE+Ri0SdqrDuJO9Ou0 B6ypJZGTp/61M0tF23Tty5jOp7Zd836h6swzPBXs2g4yHRTdBDIYQCzMQJyTOYwKTR/g vBGmrSS/srgdsx1SABLsVHmEziKTSrAo3KfyEzdsra5rn2MkI8hVrlJCh0a+xIeTRFTU f0SRuv+WsTVpZw9BKswQa/hA9x0MJTQmpQTPK2P65PI8tWUGtLWDgVdF7jP/NgCh2mhF /r6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pewT8E+AMPK4SmDndzWRAibg3SgpkLpF1vXDo2gnCLI=; b=YDWLZRrotmFK4aOmYoW+LofT2dgprj5A60ArJma/xPVNb/1s+VUT3p1OhYZUQ/bD8q 0pJ+5k+61//oBGr+iqGFaO2bMLF4H6j/8dszK/OF5ELxwcT8+ed5Gmc03XQUXl9AHPt+ N8Ga6mIjORb8818twrviNXMTdS2QeSLSzTzfd3axgzYHhxixuAzndyHV08PcjMAF2BYq DhIoGsl5yZ45jqGRG+ecYM/fIS7PymroIF6MVkRQwd2C1uJOzZGDN8UtOvPu6KvtxbiN 4rsEkRegMfr6MZVNM3u/P51/hjxbWz5Xdcm519tOV889cbGnjweRnADAdOimFU7CWInK 91Ig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k2-20020a50ce42000000b00435672e061esi3875711edj.488.2022.07.15.02.16.43; Fri, 15 Jul 2022 02:17:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232380AbiGOIul (ORCPT + 99 others); Fri, 15 Jul 2022 04:50:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232157AbiGOIuh (ORCPT ); Fri, 15 Jul 2022 04:50:37 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2599820FB; Fri, 15 Jul 2022 01:50:36 -0700 (PDT) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LklR42Qs2zFpxk; Fri, 15 Jul 2022 16:49:36 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Jul 2022 16:50:04 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Jul 2022 16:50:03 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] media: ar0521: fix error return code in ar0521_power_on() Date: Fri, 15 Jul 2022 16:59:24 +0800 Message-ID: <20220715085924.1881607-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return error code if ar0521_write_regs() fails in ar0521_power_on(). Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver") Signed-off-by: Yang Yingliang --- drivers/media/i2c/ar0521.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index c7bdfc69b9be..e850c92d847e 100644 --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -757,8 +757,9 @@ static int ar0521_power_on(struct device *dev) usleep_range(4500, 5000); /* min 45000 clocks */ for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) - if (ar0521_write_regs(sensor, initial_regs[cnt].data, - initial_regs[cnt].count)) + ret = ar0521_write_regs(sensor, initial_regs[cnt].data, + initial_regs[cnt].count); + if (ret) goto off; ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT, -- 2.25.1