Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp246089imw; Fri, 15 Jul 2022 02:17:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1todeRicdr1kJQPOze/ZmpDk/yrTQRrx3HOZ12YlnQp+TdGG6fla9HfVhpzEkPHZiOXviW6 X-Received: by 2002:a17:907:3f84:b0:724:2ec:b474 with SMTP id hr4-20020a1709073f8400b0072402ecb474mr13125065ejc.644.1657876629473; Fri, 15 Jul 2022 02:17:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657876629; cv=none; d=google.com; s=arc-20160816; b=z1X5XUnh/yLi2yacqY5jMgQ7VZAWqOzMpKlfZGhhJEct/MHN+OTvkxUccPSKa98Yfa Yu2KYvUxCYNlbVj6tb2Q9SzcJ7ELM36hHnT5MBf+hwQGM24sdnYvDlRwFjQ0efDasXD1 X7+F4YyrkH7RNLODBiEdf08SveETbMgdpUhzpdAtXMh8PUYnSorvkQkDuqBscxvCLzNl WU3DWgNrvkJYSE2nVzfEhyrnQXbbzEb/vHpomxkPR0RPBUFuc6buIRAA+38QVGKqhPDa dIVRbMA/z9S/nzEbEKFJTbIK1fFUmO7Aw/zj1GBiyZQumGbfJe8uGZnGxF01HPe0ilQT rPiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=+gJ3aZb1JznWCiFXkR4vvBk3qsZXCLudt58MB9Ukyuo=; b=xCZHLs5POEO2kyZfY7NJlyNnpt9oHP0HhZCx+5pnz8Q8U0/QfS/H8TBCcfs+1RXP9b 3+6KVu5XkRuDRnPYlQrnyuVHP2ZKGxYOkWTeZVCBDAqTW0I+Ba0et646oQIfh8ubjsPx V74Ydtv/gBrxoGM1PsdazyqkeC8UyOqcxYJfQ0oYaddPDXCE8u+g6Da97dCgofgv4rWx 95We5GY6vVOlcZxo9Z+lwI1Tbp+Hd1AYUu4FJYIYpTqLbfeDbQnXwTL/Q6QFwKh7IaYA 0AGpZR/HJ+LICsfIpaUYIB4R7fW7Osuix3FdAPD35IyFWBTKC8ZAOWJRtIRXfAZVkg9Q Waaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr2-20020a170906d54200b0072aa15584f8si6631823ejc.756.2022.07.15.02.16.43; Fri, 15 Jul 2022 02:17:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232069AbiGOIre (ORCPT + 99 others); Fri, 15 Jul 2022 04:47:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231512AbiGOIrb (ORCPT ); Fri, 15 Jul 2022 04:47:31 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AFE4E814AE; Fri, 15 Jul 2022 01:47:30 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B74171474; Fri, 15 Jul 2022 01:47:30 -0700 (PDT) Received: from [10.57.11.112] (unknown [10.57.11.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 203983F792; Fri, 15 Jul 2022 01:47:28 -0700 (PDT) Message-ID: <1198724e-d94f-0b7c-9c4a-90595f8426d2@arm.com> Date: Fri, 15 Jul 2022 09:47:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] cpufreq: schedutil: Move max CPU capacity to sugov_policy Content-Language: en-US To: rafael@kernel.org Cc: viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dietmar.eggemann@arm.com, vincent.guittot@linaro.org References: <20220711124229.16516-1-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: <20220711124229.16516-1-lukasz.luba@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, gentle ping. On 7/11/22 13:42, Lukasz Luba wrote: > There is no need to keep the max CPU capacity in the per_cpu instance. > Furthermore, there is no need to check and update that variable > (sg_cpu->max) everytime in the frequency change request, which is part > of hot path. Instead use struct sugov_policy to store that information. > Initialize the max CPU capacity during the setup and start callback. > We can do that since all CPUs in the same frequency domain have the same > max capacity (capacity setup and thermal pressure are based on that). > > Signed-off-by: Lukasz Luba > --- > kernel/sched/cpufreq_schedutil.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) The patch got Ack from Viresh. Could you take it? Regards, Lukasz