Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp247904imw; Fri, 15 Jul 2022 02:19:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1scA9W5Ix7fxzoRo2o6aXmaOmrHS3K2fihrv8pIlKaBoGy7JkSfxhPjjc9ChxUetFlfLKUe X-Received: by 2002:a63:4558:0:b0:411:442a:b740 with SMTP id u24-20020a634558000000b00411442ab740mr11079588pgk.540.1657876784129; Fri, 15 Jul 2022 02:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657876784; cv=none; d=google.com; s=arc-20160816; b=tAWsPqThOk6YwUT6zzsL82depEf7CfRUeeMyg90T9Wmz4GoFHS8ngaxea8kp5dxlvG LLRr4wd8RCpvTgQRoCC2yudwLbCvdORMBU5VFUH1NfX/XtGYHuoJsUGxBL6Yr8K3KS5e E9ZkGU2kclzrIV7mHjBbrkNb7vcS/c+T9DudH2R2JeTn+uc2eysd50pge8yVQWnkyp8L p4IIDKB/USTP5Wrzw2YqP96a1wxwDwKaFWhLwvtHn4hmtQvWsWcsmXNFOg9mHPZ3nUze nAAgAPoWc0G+NVnsXarPJusIRr9jxZUOB5b3eLES68swkHqF5DNwRSAETKEibvX9+Vuu ptfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ASNZoFJy1d7f3k201KdPaWFsxQuaNSNqOXhlC5/Xqzg=; b=vx3UkpwD60FVRhxRrQzDAb0OMnTfKUD3mEuONO2jXZVB9ds3RFsPOXVxd7b1OG6BKq EdlfdfiVTJc/FX/RgWHNGlp6hpqQDbFYeBTNVpfbfXT1XTenc3bSHEZEQ7Pk2yOCqq7a zAtIpE0701a6N+hEKRf52VKs0h5ZEvRDEHnF7w/EUCOZUK5kFPAEZALlnFawe6fWiiL7 ggloopITMCin/12qh6Fn9BBGRGHS79wSkBjsJjFj7ZG8MM+UhGBCE33T/bfH++j7TXn9 cg+Lfc7lT2pQis8uSje2mvuvsU/BDBTLh2iaxbwC3/vCBVs2oyUSCmJOUIhU+BC5W6mm T+7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a170902c11100b0016bdac9b953si3662280pli.425.2022.07.15.02.19.29; Fri, 15 Jul 2022 02:19:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231718AbiGOIZS (ORCPT + 99 others); Fri, 15 Jul 2022 04:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbiGOIZR (ORCPT ); Fri, 15 Jul 2022 04:25:17 -0400 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AD0324088 for ; Fri, 15 Jul 2022 01:25:16 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id AA9C21F88; Fri, 15 Jul 2022 10:25:14 +0200 (CEST) Date: Fri, 15 Jul 2022 10:25:13 +0200 From: Joerg Roedel To: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado Cc: AngeloGioacchino Del Regno , kernel@collabora.com, Matthias Brugger , Will Deacon , Yong Wu , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] iommu/mediatek: Log with dev_err_probe when failing to parse dts Message-ID: References: <20220712214427.544860-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220712214427.544860-1-nfraprado@collabora.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 05:44:27PM -0400, N?colas F. R. A. Prado wrote: > mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs > have probed yet, so use dev_err_probe() to avoid logging as an error in > that case. Also drop the return value from the message since it's > already printed by dev_err_probe(), and add the missing newline at the > end. > > Signed-off-by: N?colas F. R. A. Prado Applied, thanks.