Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Jul 2022 11:14:14 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     John Ogness <john.ogness@linutronix.de>
Cc:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org,
        Todd Brandt <todd.e.brandt@linux.intel.com>
Subject: Re: [PATCH v3] printk: do not wait for consoles when suspended
Message-ID: <20220715091413.GC24338@pathway.suse.cz>
References: <20220715061042.373640-1-john.ogness@linutronix.de>
 <20220715061042.373640-2-john.ogness@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220715061042.373640-2-john.ogness@linutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri 2022-07-15 08:16:42, John Ogness wrote:
> The console_stop() and console_start() functions call pr_flush().
> When suspending, these functions are called by the serial subsystem
> while the serial port is suspended. In this scenario, if there are
> any pending messages, a call to pr_flush() will always result in a
> timeout because the serial port cannot make forward progress. This
> causes longer suspend and resume times.
> 
> Add a check in pr_flush() so that it will immediately timeout if
> the consoles are suspended.
> 
> Fixes: 3b604ca81202 ("printk: add pr_flush()")
> Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>

The patch is committed in printk/linux.git, branch rework/kthreads.

I think about creating pull request for 5.19 later today or tomorrow
so that it is in the last rc.

Best Regards,
Petr