Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp264736imw; Fri, 15 Jul 2022 02:45:56 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u02g2vgMg45asoNRNnyfoz0KxZMg+q5yWcKxTZbJlO/A1J8qwFVbbZLV974UbkxVs19hZi X-Received: by 2002:a17:90b:4ac1:b0:1ef:c1ba:e73e with SMTP id mh1-20020a17090b4ac100b001efc1bae73emr21173685pjb.47.1657878355939; Fri, 15 Jul 2022 02:45:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657878355; cv=none; d=google.com; s=arc-20160816; b=cbvvsWa55AjzgCVpeADIgCIx6VZb4eW7XOuanFhPoQ31lpXiFJmBlz23TF8LyyTqIo muiCXJWRU/7JRFsM8pMUtNNpBFOriax1LArE7UdaK6flNiCsH5uuw/JAyfnaP6OMoyqz 6F2HjxDl3sKe1aqiPePOtBz3LFr6/lVXRqrZ83qw0UkNpGzXgMCDTtrN63NG3yZkfL4f qtK+SglV6Rc5MPlw+o9KwxHwYPr4YOLhTKM52hBuYLVc8HyRO6Ld3SBEzRtzqVCc9xVH eR9iHi2AaD/eDm/6O10MounNYxchtRiDW8//ARFRUhNB7an5w3dCxvOOP3Mq0zaECJNU iCqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=alTX0d1OUMd3ry53fc/WUPvtpf0EQR6wwN8gC5Cj7ts=; b=duPF14+EKIaKz2oeTEmzP6VvqSgd9mu0gIbTnq6gD93/Z+I6arA4XpJ15o6OkF9VNB k6M/ZeMKAJDgdt2/0DrTPniRgKeXqYOdsroWzhFwITzQnxLHY6cAw5K9zP8utLuw/XG0 XchV+dRzASTcW78qZQJY+uhgBne4OCXUEbA7Kq29Q2xTtAsjbvMZRNBg4WyTxueIE6GN dL6dftrQNTSvUnsEr55JDhUt0dhNnX8FWkE/xNebfMciVHjFjvlAtndzzqDFTiPzzL1Q bA18HNVwQXotJ1iDkPL5iutGPnNeOFBoceCf3dGUQP+hIVSBKFi8DaZW1tpAuJH2/J9b AWIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@avm.de header.s=mail header.b=GYk9iigA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=avm.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a635c4c000000b00415d679d50asi4652041pgm.434.2022.07.15.02.45.40; Fri, 15 Jul 2022 02:45:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@avm.de header.s=mail header.b=GYk9iigA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=avm.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233312AbiGOJZe (ORCPT + 99 others); Fri, 15 Jul 2022 05:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231631AbiGOJZV (ORCPT ); Fri, 15 Jul 2022 05:25:21 -0400 X-Greylist: delayed 489 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 15 Jul 2022 02:25:19 PDT Received: from mail.avm.de (mail.avm.de [IPv6:2001:bf0:244:244::94]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 234FA7A519; Fri, 15 Jul 2022 02:25:19 -0700 (PDT) Received: from mail-auth.avm.de (unknown [IPv6:2001:bf0:244:244::71]) by mail.avm.de (Postfix) with ESMTPS; Fri, 15 Jul 2022 11:17:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=avm.de; s=mail; t=1657876648; bh=0IekHBlcmPpyzZw3GYC5sqAejwnOmaePZ2yt2T56XvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GYk9iigAfGFIhjFfT8I9dJJP0AESz9zHZf9qs9ajY485SduwNO+aAwFcc1V4Gvc6s g9q/jkPL6rMAqPyiQQF0DZALuAW0khFjS+iAJXp4XBgNokH8nzC2m5xIEFi9LByzKq 3s0DIgH5NEQGAaB+6eL3YTh0YGSNehDh0h7QkzFo= Received: from buildd.core.avm.de (buildd-sv-01.avm.de [172.16.0.225]) by mail-auth.avm.de (Postfix) with ESMTPA id 78403800C7; Fri, 15 Jul 2022 11:17:28 +0200 (CEST) Received: by buildd.core.avm.de (Postfix, from userid 1000) id 7358F182DDB; Fri, 15 Jul 2022 11:17:28 +0200 (CEST) Date: Fri, 15 Jul 2022 11:17:28 +0200 From: Nicolas Schier To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Michal Marek , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] kbuild: error out if $(INSTALL_MOD_PATH) contains % or : Message-ID: References: <20220714050243.16411-1-masahiroy@kernel.org> <20220714050243.16411-4-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220714050243.16411-4-masahiroy@kernel.org> X-purgate-ID: 149429::1657876648-D1BAA7E9-F4C7D76D/0/0 X-purgate-type: clean X-purgate-size: 401 X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 02:02:43PM +0900, Masahiro Yamada wrote: > If the directory pass given to INSTALL_MOD_PATH contains % or :, > the module_install fails. > > % is used in pattern rules, and : as the separator of dependencies. > > Bail out with a clearer error message. > > Signed-off-by: Masahiro Yamada > --- Reviewed-by: Nicolas Schier