Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Jul 2022 11:32:06 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Hendrik Brueckner <brueckner@linux.ibm.com>
Cc:     Steffen Eiden <seiden@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, nrb@linux.ibm.com
Subject: Re: [PATCH v2 1/3] s390/cpufeature: rework to allow more than only
 hwcap bits
Message-ID: <YtE0FmnL9iDMMA9n@osiris>
References: <20220713125644.16121-1-seiden@linux.ibm.com>
 <20220713125644.16121-2-seiden@linux.ibm.com>
 <YtEedTrWv3Wc+cZQ@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YtEedTrWv3Wc+cZQ@linux.ibm.com>
Precedence: bulk

On Fri, Jul 15, 2022 at 09:59:49AM +0200, Hendrik Brueckner wrote:
> Regarding facility bits for cpu features:  Initially, I used
> MSA hwcap to cover all ciphers among all hw generations. With facility bit
> checks, it makes more sense to fine-tune and load based on respective
> MSA level or CPACF functions that is required for ciphers/hashes.
...
> > -module_cpu_feature_match(MSA, init);
> > +module_cpu_feature_match(S390_CPU_FEATURE_MSA, init);
> >  module_exit(fini);
> 
> which becomes automatically loaded if (any) MSA is available and then
> performs this check:
> 
> 	cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_512
> 
> which in the worst case would fail.
> 
> This might be a very useful follow-up patch to remove those mod init checks
> into the cpu feature.

Yes, that makes a lot of sense. Thanks for suggesting this!