Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d480a850-601b-cda2-b671-04d839c98429@amd.com>
Date:   Fri, 15 Jul 2022 13:36:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v7 07/14] KVM: Use gfn instead of hva for
 mmu_notifier_retry
Content-Language: en-US
To:     Chao Peng <chao.p.peng@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
        linux-doc@vger.kernel.org, qemu-devel@nongnu.org,
        linux-kselftest@vger.kernel.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        Hugh Dickins <hughd@google.com>,
        Jeff Layton <jlayton@kernel.org>,
        "J . Bruce Fields" <bfields@fieldses.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, Mike Rapoport <rppt@kernel.org>,
        Steven Price <steven.price@arm.com>,
        "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
        Vlastimil Babka <vbabka@suse.cz>,
        Vishal Annapurve <vannapurve@google.com>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com,
        ak@linux.intel.com, david@redhat.com, aarcange@redhat.com,
        ddutile@redhat.com, dhildenb@redhat.com,
        Quentin Perret <qperret@google.com>,
        Michael Roth <michael.roth@amd.com>, mhocko@suse.com,
        Muchun Song <songmuchun@bytedance.com>
References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com>
 <20220706082016.2603916-8-chao.p.peng@linux.intel.com>
From:   "Gupta, Pankaj" <pankaj.gupta@amd.com>
In-Reply-To: <20220706082016.2603916-8-chao.p.peng@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmdybVBZM2pKOHd6UmEwcWxuV2xjVFlpVWZHNVVmUWdwMkJ4R1FPKzhleEZB?=
 =?utf-8?B?UElUK1pCekRFaXBFU2Q4Ykk3WExxNGt2dFYrWkFVOXhxVmo5Z1dreFRSN1p6?=
 =?utf-8?B?YW8vLzk5TkVtUjdWdjc4bzVQSVh1QXhsSlpaeEc0V1F3TFFRcFlrc3hUdU93?=
 =?utf-8?B?c0pXTzUvOE1JalFLOWZXUVhkSHpYM3FKOTBNRm51MUNqRGVvQUpUcTF2c29p?=
 =?utf-8?B?M2F4eXF1WDRxYlJwL3JSNlloMEI5ZTU1bjVPcElIR0hOYm9DWTVJU25iRnFa?=
 =?utf-8?B?Y2dnYzlZRVZ3OG9Ib0MxQjlZd0Y3bkdLYS9IYmdQQmtqTDByNWFhTFBENlhC?=
 =?utf-8?B?Ymo5MDEzZnE0RU1MSU50N0RRNDhDVHoxZ0VOdmYvTTNnUlFQWUlBR1Z0dlRq?=
 =?utf-8?B?ODdDaEFBRmd0QmhtcjhCQ2VhVUVSemtmZVUxTUFHVTEvM0N0Q3JFY1UyVTZq?=
 =?utf-8?B?MVRyWVZBSk1SQ3liakVmdFVuc2xZTXNuc0lBZFI4WHo0c2NCanRtSG5QNlB2?=
 =?utf-8?B?SHdWVVlxVVNQMXN2ZHV3MUdxSzMyK1FXUGtNOGNPU1JxbWRqcUVyak9ZcDA3?=
 =?utf-8?B?SWZER01qUmxWVEk4YWlML25sd0V0eGViL0JQSkI4VExNUTQwR2JERWdRem1T?=
 =?utf-8?B?TnJZM0k1d0piNzVORUc4M2lwQW8vT3diWnRqNFZSQmwwbUQ3VGttMXpuOEhU?=
 =?utf-8?B?N1ZCNUFmUW1IQjBwU2RiSzdXaGhMeHBlcjlESWxlVm9lb1ZYZUVMOGQwL2g0?=
 =?utf-8?B?TDBUK1pUUjNhVStTcmhOdURQakRRcVpMODNHSWRzUmZzelRHUkFtOVROdGhw?=
 =?utf-8?B?U1hlY0JPUVM5dmJOWWZ0S2dHZk9qNUdFS3REUU5FWWdOQ0NyMk9sSzVKWVVv?=
 =?utf-8?B?dTRzb3Uxem80RGs3S3paNytlaFZ4b2hDSEhuWGdZZE5DY1pZTHNhR3hiZ2JF?=
 =?utf-8?B?VUZLNitFTldFS2dFYS9WZGJBalh0S29qT3ZuTVZoL0laTmxkdlh1dUkrcFIv?=
 =?utf-8?B?d2V4RTF0U1dsOFZLRWdKQWlKa2lKRkQvZ2dpMlVOYW84OGlyUEIyZ3p0YStj?=
 =?utf-8?B?VmJZdDI2b3JKbDdXdzZGRlhJaG0zcWsyNjdNZjVEcnpYZVhrOGNQUEtnQlU5?=
 =?utf-8?B?Rm9HVU5DazZ5L0RFRTMydWVnNVBvbU8vbWdNbWc2U3RJT29kZnNtVmRxQW9a?=
 =?utf-8?B?WEI4MDBVME1HN2wzNmNGWU9USlFpTkxkUEkxL1N6T1NXYWhJMGQ0bUZBWkNi?=
 =?utf-8?B?bEFUcitLUkhrWlZCbG9RQUo0SHVtN0drTzhsSzU4MWN1VFVxd3RGZ1RSSmlV?=
 =?utf-8?B?blFROGdOMXRRbkpFdDd3Zm9sRkpmM0ZSbmtvTTI1WGc3b1BuL3FMTjdZWTVn?=
 =?utf-8?B?MEdKcXN4ZzFLK09jajZNcmZHNWk5bW9mVTJSUGRnNG16QUlOaVJuM293YzRP?=
 =?utf-8?B?M09iNzBycllwQlIxcDJDeGtFbzBLUDE3NkVFUVV3Y212U05ubGpaZndtVUtK?=
 =?utf-8?B?R1lFeVc0djl3bmNGaHNxaWtjQ091UXVRVG95NlIyYWVqWCs2cExXNE1sV0hn?=
 =?utf-8?B?NDhkMVlBeU1BOXdyNWhoLzhjMWUwK3hUOVgzS0p3WEhCRmVrQnp5SGpTQ3FI?=
 =?utf-8?B?alluZTBzaUZLNnBkRzJaa0Y0TUdMbnBVRnM5Ry9hRjZDRVBhS0hESUU4VzNa?=
 =?utf-8?B?Smc3NXBKb3l1MFZ0TGZNSm11YTcrWjhEaFd6ay9Ibk92N2N5Z0lVMlQvenFu?=
 =?utf-8?B?L2ttV1dIdVg5RTRzQkh4ZGQvMlNlRUJPelNNODFKcEZLZWhYWk8vbnhuenNP?=
 =?utf-8?B?WGVLZ1g1MVVnM1ROVVJ1eElBaThWOGh2bmlwNi9WTVhZMktSS1BwRUp0dzFy?=
 =?utf-8?B?WmpNbFI4VFRjdG83WjlBa0gwUXlLRWFOMTFyZy9JZFVwRXRiSzN1UDZtbW05?=
 =?utf-8?B?RnhOZ2NtaFMxQ3VFcDZmNnhJL3FuWnVWNEp1Y3JHVjhta0wxaElTOTFUdUJK?=
 =?utf-8?B?bi9YN2xMRXhNOFpObzBUMzd4WWJIVGRVK3hObU5wVDk4ckpYUlE1MVFnUmlD?=
 =?utf-8?B?L3dtMTZEZmg1UG81OStzOUlRZEQzUDlpN05rSVVwVFJ2cG9jSHhIOFJvdHZH?=
 =?utf-8?Q?zLFesLhWXyR4hhivE2uY7X1do?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1adc661-638d-4ca9-6a74-08da665642c8
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0181.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 11:36:30.3903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p+f1/KruhoMG2zGDJ2cMcjuJcAYMxE0cVRgZWt+0DvK35dsX4wUFe4Oej8RyMfec6ySWtiWX7aqFhMiQCwP2Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3640
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Currently in mmu_notifier validate path, hva range is recorded and then
> checked in the mmu_notifier_retry_hva() from page fault path. However
> for the to be introduced private memory, a page fault may not have a hva

As this patch appeared in v7, just wondering did you see an actual bug 
because of it? And not having corresponding 'hva' occurs only with 
private memory because its not mapped to host userspace?

Thanks,
Pankaj

> associated, checking gfn(gpa) makes more sense. For existing non private
> memory case, gfn is expected to continue to work.
> 
> The patch also fixes a potential bug in kvm_zap_gfn_range() which has
> already been using gfn when calling kvm_inc/dec_notifier_count() in
> current code.
> 
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> ---
>   arch/x86/kvm/mmu/mmu.c   |  2 +-
>   include/linux/kvm_host.h | 18 ++++++++----------
>   virt/kvm/kvm_main.c      |  6 +++---
>   3 files changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index f7fa4c31b7c5..0d882fad4bc1 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -4182,7 +4182,7 @@ static bool is_page_fault_stale(struct kvm_vcpu *vcpu,
>   		return true;
>   
>   	return fault->slot &&
> -	       mmu_notifier_retry_hva(vcpu->kvm, mmu_seq, fault->hva);
> +	       mmu_notifier_retry_gfn(vcpu->kvm, mmu_seq, fault->gfn);
>   }
>   
>   static int direct_page_fault(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault)
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 0bdb6044e316..e9153b54e2a4 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -767,8 +767,8 @@ struct kvm {
>   	struct mmu_notifier mmu_notifier;
>   	unsigned long mmu_notifier_seq;
>   	long mmu_notifier_count;
> -	unsigned long mmu_notifier_range_start;
> -	unsigned long mmu_notifier_range_end;
> +	gfn_t mmu_notifier_range_start;
> +	gfn_t mmu_notifier_range_end;
>   #endif
>   	struct list_head devices;
>   	u64 manual_dirty_log_protect;
> @@ -1362,10 +1362,8 @@ void kvm_mmu_free_memory_cache(struct kvm_mmu_memory_cache *mc);
>   void *kvm_mmu_memory_cache_alloc(struct kvm_mmu_memory_cache *mc);
>   #endif
>   
> -void kvm_inc_notifier_count(struct kvm *kvm, unsigned long start,
> -				   unsigned long end);
> -void kvm_dec_notifier_count(struct kvm *kvm, unsigned long start,
> -				   unsigned long end);
> +void kvm_inc_notifier_count(struct kvm *kvm, gfn_t start, gfn_t end);
> +void kvm_dec_notifier_count(struct kvm *kvm, gfn_t start, gfn_t end);
>   
>   long kvm_arch_dev_ioctl(struct file *filp,
>   			unsigned int ioctl, unsigned long arg);
> @@ -1923,9 +1921,9 @@ static inline int mmu_notifier_retry(struct kvm *kvm, unsigned long mmu_seq)
>   	return 0;
>   }
>   
> -static inline int mmu_notifier_retry_hva(struct kvm *kvm,
> +static inline int mmu_notifier_retry_gfn(struct kvm *kvm,
>   					 unsigned long mmu_seq,
> -					 unsigned long hva)
> +					 gfn_t gfn)
>   {
>   	lockdep_assert_held(&kvm->mmu_lock);
>   	/*
> @@ -1935,8 +1933,8 @@ static inline int mmu_notifier_retry_hva(struct kvm *kvm,
>   	 * positives, due to shortcuts when handing concurrent invalidations.
>   	 */
>   	if (unlikely(kvm->mmu_notifier_count) &&
> -	    hva >= kvm->mmu_notifier_range_start &&
> -	    hva < kvm->mmu_notifier_range_end)
> +	    gfn >= kvm->mmu_notifier_range_start &&
> +	    gfn < kvm->mmu_notifier_range_end)
>   		return 1;
>   	if (kvm->mmu_notifier_seq != mmu_seq)
>   		return 1;
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index da263c370d00..4d7f0e72366f 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -536,8 +536,7 @@ static void kvm_mmu_notifier_invalidate_range(struct mmu_notifier *mn,
>   
>   typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range);
>   
> -typedef void (*on_lock_fn_t)(struct kvm *kvm, unsigned long start,
> -			     unsigned long end);
> +typedef void (*on_lock_fn_t)(struct kvm *kvm, gfn_t start, gfn_t end);
>   
>   typedef void (*on_unlock_fn_t)(struct kvm *kvm);
>   
> @@ -624,7 +623,8 @@ static __always_inline int __kvm_handle_hva_range(struct kvm *kvm,
>   				locked = true;
>   				KVM_MMU_LOCK(kvm);
>   				if (!IS_KVM_NULL_FN(range->on_lock))
> -					range->on_lock(kvm, range->start, range->end);
> +					range->on_lock(kvm, gfn_range.start,
> +							    gfn_range.end);
>   				if (IS_KVM_NULL_FN(range->handler))
>   					break;
>   			}