Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp357668imw; Fri, 15 Jul 2022 04:50:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t+0zNamnkL0YUHxcYMSvxv4aN2eikuO9GV19DIOquxEoa9G2mgKyFSPhc0ICXwjEJI2j5d X-Received: by 2002:a17:90b:1d8a:b0:1f0:6083:5d80 with SMTP id pf10-20020a17090b1d8a00b001f060835d80mr20695057pjb.147.1657885834699; Fri, 15 Jul 2022 04:50:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657885834; cv=none; d=google.com; s=arc-20160816; b=na8N2S7ae/p6/mLZTGL901M+cycT1GI36xj62JKdHUSS5JBn6Cggn9abV70vSvBv35 cKonQysTMMz/xtGU4zVv8lS4ciykAyXEXtHh+zsEb75Hix5C47MJwaaLUOH06wgsxWEX d2CUO9McBNrgWRo9f51nlN9CySq2RESTYz2HQUHFy7IjG8rcpWDLC0hdToWkl8WoLjgo wi/h2uyzbs8CW5k9T8Tq1c+XcU//+L5xAbIzlHmA47DQ1j8TCILvgmyOb16kON3JB5sN Bc2zZvG28/fK9ct8fCmgFaRo6SEB1ZV3Dr0rpKuHEqt8bhTvyKqSFfSN9F7nv5WOE6+L YNUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1ofnvk96zryFa0WIMf2Q0BxUEjkKOSxNf6ockQ6cVB8=; b=z+IN5k06H/wYFfD94m1myLxVufVuT9NO8HrJNB+hUTJXi+q8uya8TVld2jxOsRnKRa rvUqk6InJ/+Xz8YxZ68uzxLh7Xq+HEU3lLYwhgV2OASi0P+jcLpWrKiG5PSxlZAlO6Jb x1C1LPQg5rOTGCmxtbIUYyzQ3eHgt1hrS/w7degq5uto5YQE4sA2D+H5Cv1a1MIRGXTd XZcppz72AZ4S1PKYyNJj2YBBzmdXV7vLEj+kwBJl+NmB2NwjkAaOWA6CBAWjEcwUikSz 4Y0esZHpXnHE7H8iwt3LMb0//Rb9lrZwDr45x2TOQ/HD1y5zCY5nC1BAWFU2nmSOhQ56 vNfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eERiyrRX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h70-20020a638349000000b0040c8a3c4980si825596pge.190.2022.07.15.04.50.19; Fri, 15 Jul 2022 04:50:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eERiyrRX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232427AbiGOLsp (ORCPT + 99 others); Fri, 15 Jul 2022 07:48:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiGOLsl (ORCPT ); Fri, 15 Jul 2022 07:48:41 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D987639B for ; Fri, 15 Jul 2022 04:48:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 43BADCE2EEE for ; Fri, 15 Jul 2022 11:48:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED09DC34115; Fri, 15 Jul 2022 11:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657885716; bh=mKWhPThcZmP1RLWqrhqBF+ZhH0KatTGFVjzBtLtdpu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eERiyrRXCg7lr+J2REf2VMzZc1HPKXbJtpBbKd+r+lOBbsWRGYbwiN1+jREtEsA3M RSGqId2uDmoYE7OmEa0udZULdp+WAYVYIHTFP3aiNYz9K5TXJgkhUaFKaAdi80WmFN VrJDjMHfKUFYKf1Hw7MjZt5WPmLSlg+XJeLxH9QRO4nx6T98It2tAAilvmf6FVx1f3 CHcdv96gAldK6MS9LUfRSGpkFkyNqxRopxjXPmdrddqs+Cgp4DZYmxN1T7hFMS8hEM trd5cCVZd5XX5+rg8ZsUo93P2lyvkuCwajbIFzu3PnEpC8XXdHrY76jAT6c1nB0KE+ tn6jiZAlXd3+g== Date: Fri, 15 Jul 2022 17:18:32 +0530 From: Vinod Koul To: Samuel Holland Cc: Frank Wunderlich , Greg Kroah-Hartman , Peter Geis , Heiko Stuebner , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode Message-ID: References: <20220708061434.38115-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220708061434.38115-1-samuel@sholland.org> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-07-22, 01:14, Samuel Holland wrote: > When the OTG port is fixed to host mode, the driver does not request its > IRQs, nor does it enable those IRQs in hardware. Similarly, the driver > should ignore the OTG port IRQs when handling the shared interrupt. > > Otherwise, it would update the extcon based on an ID pin which may be in > an undefined state, or try to queue a uninitialized work item. Applied, thanks -- ~Vinod