Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp391362imw; Fri, 15 Jul 2022 05:28:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tfBYmTM92BBnZTSgb44EDTgF33Fm8TbZSpg4Y3YaH36zhHFRjueWdeKAhXRpdvLxBGDIRR X-Received: by 2002:a17:90a:5d05:b0:1ef:91ab:de15 with SMTP id s5-20020a17090a5d0500b001ef91abde15mr15157267pji.85.1657888098219; Fri, 15 Jul 2022 05:28:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657888098; cv=none; d=google.com; s=arc-20160816; b=qU6xIQqWsSZUvfkLM3wugE1gAM5CvvaSDw59HdTjZEZnpDWw0sdzChskDSlntCb0im Aw9YWoHgxdPylvlTqF4SMsuT0AgtSV3nDuzmxUEWHWxjEI9KI8uegNG8wiSRC5xQyRaS aK0ubdYjPWT7XSw/6gPYtvt/2wETMoabORhsuIpdi+y3Xtoq2KkrLW/3j/dzB1Y8jLhv lIKGosJ1dKiighP0fg3nytPK78aKg/boHCbYhH5gBDKeQR+x1RwNnAz2V2hwTbHORtvH xfEJu3lMyFoiqyeIi3Xzo0RqVAu1tuMniS9y888WhF6C6GfA22mGVgcLCMgaQMzQlhcV g+Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:in-reply-to:date:sender:references:subject:cc:to:from :dkim-signature:dkim-filter; bh=6WgQL5dDQgGCkY5eOoqGlM0sZqSYnTYubq8pAl/7Hec=; b=lNIFMk6wbdvqgXAGUjQOoLB9kEMggdJcP4vrwh7UhCTYdbR+O+QlS/ypy8nvSTQl9C eOG4RuPEYfziXYJnM5d7HWuoU5kmv1nELwSznqz2BhmiGBIw8RarokeKLR7//z05I/f7 ANivsYhVN7KNZcMcQAX9l9NTziyxDC7W4xvpuFCdS5zmoU/71tQBkNzZ7aTzYqycLSB7 JWbVFyHLshVlXkT05AVPeldw1a1mLNFknItXphEEspXLpdkA04Btjla1JpErGAu5jUKV NCB8bi3JyUu7PDGpANZjunO1nKnxWFW++tYyj2S3NI7M4pay0CLr7KPCSVanAh4v3Jn2 9+1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@piap.pl header.s=mail header.b=bnRjuirY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=piap.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a63c154000000b00408aab0e934si5402755pgi.251.2022.07.15.05.28.03; Fri, 15 Jul 2022 05:28:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@piap.pl header.s=mail header.b=bnRjuirY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=piap.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233937AbiGOLmD (ORCPT + 99 others); Fri, 15 Jul 2022 07:42:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiGOLl7 (ORCPT ); Fri, 15 Jul 2022 07:41:59 -0400 Received: from ni.piap.pl (ni.piap.pl [195.187.100.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C11187C30; Fri, 15 Jul 2022 04:41:56 -0700 (PDT) Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPSA id 638BBC3F3EC9; Fri, 15 Jul 2022 13:41:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 638BBC3F3EC9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=piap.pl; s=mail; t=1657885312; bh=6WgQL5dDQgGCkY5eOoqGlM0sZqSYnTYubq8pAl/7Hec=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bnRjuirYKpLgrdjRlDwjPz1wtIiqmTWPOo0WEvq+Z2DGevfhNxjtec9GQPpPrJAcu 2Yse6OgcVKi22OcVj/Bg406bhRmX1vJNbE9LYZi5EiEPS6AIfRuQ0HXBMwJry4o15W /xA+Cbv6wxR0zJ7MFEBriw+t6tGB//nS8/sXNeHQ= From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Yang Yingliang Cc: , , Subject: Re: [PATCH -next] media: ar0521: fix error return code in ar0521_power_on() References: <20220715085924.1881607-1-yangyingliang@huawei.com> Sender: khalasa@piap.pl Date: Fri, 15 Jul 2022 13:41:52 +0200 In-Reply-To: <20220715085924.1881607-1-yangyingliang@huawei.com> (Yang Yingliang's message of "Fri, 15 Jul 2022 16:59:24 +0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, license restriction X-KLMS-AntiPhishing: not scanned, license restriction X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, not scanned, license restriction X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yang Yingliang writes: > Return error code if ar0521_write_regs() fails in ar0521_power_on(). > > Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver") > Signed-off-by: Yang Yingliang Right, thanks. Acked-by: Krzysztof Ha=C5=82asa > +++ b/drivers/media/i2c/ar0521.c > @@ -757,8 +757,9 @@ static int ar0521_power_on(struct device *dev) > usleep_range(4500, 5000); /* min 45000 clocks */ >=20=20 > for (cnt =3D 0; cnt < ARRAY_SIZE(initial_regs); cnt++) > - if (ar0521_write_regs(sensor, initial_regs[cnt].data, > - initial_regs[cnt].count)) > + ret =3D ar0521_write_regs(sensor, initial_regs[cnt].data, > + initial_regs[cnt].count); > + if (ret) > goto off; --=20 Krzysztof "Chris" Ha=C5=82asa Sie=C4=87 Badawcza =C5=81ukasiewicz Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP Al. Jerozolimskie 202, 02-486 Warszawa