Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp436142imw; Fri, 15 Jul 2022 06:13:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ukyVnZhZUODx5XrUwKxnV8FA6zv/n2NXMAoxLgLgtmKhtSInAD5PV5/4X90UpGrwn0SkdL X-Received: by 2002:a17:907:7245:b0:726:a909:902e with SMTP id ds5-20020a170907724500b00726a909902emr13533600ejc.308.1657890784208; Fri, 15 Jul 2022 06:13:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657890784; cv=none; d=google.com; s=arc-20160816; b=wGy0XrgCgFiF0/K4suI9H4NRwqmpKlSXMMANdPawUL+yLvD+d1JiR67fze5UXqRZwW 2YXDawWlnfYnmiK0AcGTiDzwPLyJTiJdZOlWJnHVxaqWpYZjmPqCTN1EWf0lm2JNpzn3 Yiy69joWKZY7K0qL6HoSYUA5luDd+In5OGi1T+kJFIciv1eqzRtxulM+ZuaaYHwbB/Jo XifZgpfrq7+xuUvDqHBHgL3toJTRZHCUjOGA32ilmA2Rp6QaQDPecqalNa6/KgP8AwEK Rmvy1pT8TgtltwuqpM8OnEoDZAt+KKTef8jqjjKEijUKLEwtjHVWu40JuicOLToV3HXj 1IwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=sPOIR8lKBOLMKiHODxm4lxVipb+oJaSRASZ9I7mLKD4akKPtTrU6ehhrbX3DzW25el bklSNkuRjgtwodVXUb59c0jFd9do+YCods0wVNjRn5c7Tivtq16bRjhXfHZui1lNvqIl iGj32nwsZTzfMCEyYLydwiSaNIStwUBzG1scBfONRaKY5LqKk+4gDnckptWhn02nPWEG mBhOVLaTgddrAGn/WTdv2V6oHOfu1D+I50gT3KgLJT1BcgpGr0Z7adweisCidzbZ5RFj 0bR4knuGcG9O/t8khvZkUPulSzrI+oB9oEJWo5VcoYkipRD5LzPMDa6X5p5Utuv/BVRI LW9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="I/KxJOar"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cf4-20020a0564020b8400b0043acc275debsi51659edb.296.2022.07.15.06.12.39; Fri, 15 Jul 2022 06:13:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="I/KxJOar"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234487AbiGONGW (ORCPT + 99 others); Fri, 15 Jul 2022 09:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbiGONGT (ORCPT ); Fri, 15 Jul 2022 09:06:19 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A468B3D599; Fri, 15 Jul 2022 06:06:17 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id 6so8329824ybc.8; Fri, 15 Jul 2022 06:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=I/KxJOarbkD3CTr6bI1+GX+R+0NK3NiJOovyOkNmpfsXSDv2vhcKk5NI+vZftnkbGg MwrvPAOczLpV/PzuzznMkxCSxJ+6WcBxz2SeXhuGLsY0hH+bxgIA+vAWaqy8gXKWAq2A uzFOe2j4x3jy2QIvV7SK11B49LyIqafJ56HKzoiej9S7S0ggTmMqLI8tQrHvAJsSRq/z rNeHJ2pSwMUMYzeC8dNaH6ecQWQOtzNB7/eDnb0GxvTouw5w6xHmU0P81MLtH8ioFMQA fU5zDFovh6s+bvTishJ0zl5v/l4nnJ809RZNoyuqT7PXEo9cUMjGqySfB+fn2ERJmoLs 3duw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=H5ztsXgtdPdhxjNfLlDvNXD2n7pVUmxlic9bMcioNNnGL3iAxoY2mKgsTvcAti25n3 SG5BqjPUl3V9/wfI50Kicyhq0/Vy1srtnht3X2lU/Bat8u8O149jfW6YFJ55fx/2+YtJ BAC/zgY8yCPwTlhlwaSoCoHkI6sDz7Rgi3KnRrh28QPfWC9X/1iJlkmG1AJx02gXwauA Rz2Q6YqM9UMph9pNwlERWYB8pUDckUuzsZ4lJW7ndNuweU4Mexjip5nzsu271O10jk4q YBEIGJY30cEajjc9/FQh0akSfEcmWaSrcFgTtXWlRMpiibN/jqFSZCUpVwompp9S9NtE V+UQ== X-Gm-Message-State: AJIora/zfuY0767eC++6t2Mqy1l+2KqJvtQoxIr6SYyFjwt/IpwTJWZx IuxZHqnBPKbC0gpAC9ChtW3hTsIpQ+HqZg5l/tc= X-Received: by 2002:a05:6902:1143:b0:66e:eb08:4c23 with SMTP id p3-20020a056902114300b0066eeb084c23mr14488436ybu.570.1657890376848; Fri, 15 Jul 2022 06:06:16 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 15 Jul 2022 15:05:40 +0200 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: AngeloGioacchino Del Regno Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto: ... > > +#define STATE_OFF 0 > > +#define STATE_KEEP 1 > > +#define STATE_ON 2 > > I propose, instead: > > enum mt6370_state { > STATE_OFF = 0, > STATE_KEEP, > STATE_ON, > STATE_MAX, Usually we don't put commas at the terminator entries. > }; -- With Best Regards, Andy Shevchenko