Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp494667imw; Fri, 15 Jul 2022 07:17:56 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tlpgH+ZNMeBfCgJ90t49uY7wC0Lcxoihmwr+4czH8p4fSsRKAL5GR9pB/WyDzhSPojme70 X-Received: by 2002:a63:f95c:0:b0:412:9d5b:fbfd with SMTP id q28-20020a63f95c000000b004129d5bfbfdmr12369919pgk.103.1657894676475; Fri, 15 Jul 2022 07:17:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657894676; cv=none; d=google.com; s=arc-20160816; b=aoTvs8UPYtx/dUHY03YRT4aC3PfsltJD1MOpctNhTOkFfPmAhy/KE0lVufL738aid0 uBI+X8xCw1bmrXZa1ODsiXMIQhYYx+suKgrc6zZcP7GJJoatEezoCPSLW7cLju1K9MZD xzDgVjn2ZlIWFyhBUd57LyYLenIZ+UrqaR6mxs1gZ5PoWmYK+xiZrvsZSeoepmxhWztK QByJykNFKIr4PMjc4T3UzUrT1N0QRpmb+Fu23zc87UT2CrCOO6ys5Ozk4N9tsGqm+Tp2 hQYjlspazSCAkwOqUnajRpUF9U7GRfAWw5SQ0g1lk+LPCHaiQZw8WSi4iUZoB1pZjqqt J6Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=j8MimsVYB8fCZDSy7MAtS+tgvx5/Y7Ip8qF5P4nhD9c=; b=P9B28vLccF2wID2cLztyR/RoZR5+48EWjdKd0KxXraebSWp8Vjpvsox6tZ8THQkO9X 5Pj3KFkwOzH0lJ8ocO3EU0GL3UB+S+RD1rT8zP5YTAQmRHOrjCPZfIeikQpT8Pd/b51+ EH0erI+N5i7qs3qlG9qilSTUFThGEItZTEe6KhKiuLJMgQQqp/wUI+Maz9Xxh64x3epj AFruw/OJlC/W50kLdYpngAsgbdvt8JdAEP/beHaFTte4ISL6ypLOWXKQM7gWQAtaiiIQ PASNZ9V0VUwmfnstyHOve0nQC/InO4oL7o/20KWIgsSxyUQSdFOHPe3prMMROMu3H07T jVQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=plvision.eu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h31-20020a63211f000000b0041288737bc6si4529852pgh.797.2022.07.15.07.17.41; Fri, 15 Jul 2022 07:17:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=plvision.eu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234888AbiGONjg (ORCPT + 99 others); Fri, 15 Jul 2022 09:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233136AbiGONjd (ORCPT ); Fri, 15 Jul 2022 09:39:33 -0400 Received: from syslogsrv (unknown [217.20.186.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B340F5B1; Fri, 15 Jul 2022 06:39:32 -0700 (PDT) Received: from fg200.ow.s ([172.20.254.44] helo=localhost.localdomain) by syslogsrv with esmtp (Exim 4.90_1) (envelope-from ) id 1oCKrJ-0001SM-KU; Fri, 15 Jul 2022 15:55:53 +0300 From: Maksym Glubokiy To: Taras Chornyi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yevhen Orlov , Volodymyr Mytnyk Cc: Maksym Glubokiy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: prestera: acl: use proper mask for port selector Date: Fri, 15 Jul 2022 15:55:50 +0300 Message-Id: <20220715125550.19352-1-maksym.glubokiy@plvision.eu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FSL_HELO_NON_FQDN_1, HELO_NO_DOMAIN,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adjusted as per packet processor documentation. This allows to properly match 'indev' for clsact rules. Fixes: 47327e198d42 ("net: prestera: acl: migrate to new vTCAM api") Signed-off-by: Maksym Glubokiy --- drivers/net/ethernet/marvell/prestera/prestera_flower.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_flower.c b/drivers/net/ethernet/marvell/prestera/prestera_flower.c index d43e503c644f..4d93ad6a284c 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_flower.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_flower.c @@ -167,12 +167,12 @@ static int prestera_flower_parse_meta(struct prestera_acl_rule *rule, } port = netdev_priv(ingress_dev); - mask = htons(0x1FFF); - key = htons(port->hw_id); + mask = htons(0x1FFF << 3); + key = htons(port->hw_id << 3); rule_match_set(r_match->key, SYS_PORT, key); rule_match_set(r_match->mask, SYS_PORT, mask); - mask = htons(0x1FF); + mask = htons(0x3FF); key = htons(port->dev_id); rule_match_set(r_match->key, SYS_DEV, key); rule_match_set(r_match->mask, SYS_DEV, mask); -- 2.25.1