Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp519984imw; Fri, 15 Jul 2022 07:48:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uvHn6S4Dm/FFcMTsrwQWtXGXglbnnwEG1O4bGygE+BGziOo2mxUqGUa5ARLajhz7b47fLS X-Received: by 2002:a05:6402:51d0:b0:43a:d3f5:79e9 with SMTP id r16-20020a05640251d000b0043ad3f579e9mr19298558edd.411.1657896524168; Fri, 15 Jul 2022 07:48:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657896524; cv=none; d=google.com; s=arc-20160816; b=LRI9yNEyG+jvDhy7M34Q6fY0tiGoFq00kFZrbHyTSZ+QZoJfjNWlsoTZeC8bzu/ckZ 01wEgLf13ksX9oU9fC16Z3LYfsUuXKp5xKtwwiT3On8mJtdoSuaX2QpjsOntH5LN8WeM O3ql3A5t9WBzboxlehn33ySKKrSV63GFSi3/O5tThk6uY+OFWmqO48BScqGfzcUi7jMR ZOQUF7f687GLKN9geivCjSsbLKGVMfwiKEtrLZM79nvvq5I0xwcylD09AmjJX6djV/gw J7NVh8eS3NNEtxnMzAs03m9Utbhua/UohjxaXSE6h59KpX+1frg83ILKEyB2/DVuuBWs Cl0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=DwBoro6ohEaudedDerNKNJIZfhYlTPgtZTy7JVOygyo=; b=ab39tiJh0jMH7R/zmsGvimrToER9WxdEFlPWaM3ZeUd2kCouCEvJBPQpc2xBu5uF49 nMQ9cA5ut5kPp043/3iFYpvyRdQbMkprLuLMq+KdHAe+pqQM/ppqEZh29HUFXWn9yI0d CNGVGeSMOHaF3L22qIef7w/RrTbF1AWWyeyAdLTgxlyLKR2ANk2FXfcYvV3cezfxUnRM h0QYOoB0XOBveruUQPfpGkO00GM5J3+SjG86BgnZglgIDbCTcPkXswVCKdlwcjpB72kt r3myO2XawzaJwMRPqbYQIZadPUtbz7NqF5KPBTN4ZiKn8h+jVYh9nbI/G3WWqUoYPHZb jGXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf28-20020a1709077f1c00b00722e1c6efe2si4222474ejc.426.2022.07.15.07.48.19; Fri, 15 Jul 2022 07:48:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232754AbiGONwF (ORCPT + 99 others); Fri, 15 Jul 2022 09:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232699AbiGONwD (ORCPT ); Fri, 15 Jul 2022 09:52:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DDAA820DB for ; Fri, 15 Jul 2022 06:52:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 47839B82C6D for ; Fri, 15 Jul 2022 13:52:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F7C6C34115; Fri, 15 Jul 2022 13:51:58 +0000 (UTC) Date: Fri, 15 Jul 2022 09:51:56 -0400 From: Steven Rostedt To: Marco Elver Cc: Petr Mladek , "Paul E . McKenney" , John Ogness , Sergey Senozhatsky , kasan-dev@googlegroups.com, Thomas Gleixner , Johannes Berg , Alexander Potapenko , Dmitry Vyukov , Naresh Kamboju , Peter Zijlstra , Linux Kernel Functional Testing , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: Make console tracepoint safe in NMI() context Message-ID: <20220715095156.12a3a0e3@gandalf.local.home> In-Reply-To: References: <20220715120152.17760-1-pmladek@suse.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2022 14:39:52 +0200 Marco Elver wrote: > Couldn't this just use rcu_is_watching()? > > | * rcu_is_watching - see if RCU thinks that the current CPU is not idle Maybe, but I was thinking that Petr had a way to hit the issue that we worry about. But since the non _rcuide() call requires rcu watching, prehaps that is better to use. -- Steve