Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Jul 2022 17:44:44 +0200
From:   Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
To:     Usama Arif <usama.arif@bytedance.com>
Cc:     io-uring@vger.kernel.org, axboe@kernel.dk, asml.silence@gmail.com,
        linux-kernel@vger.kernel.org, fam.zheng@bytedance.com
Subject: Re: [PATCH v6 5/5] io_uring: remove ring quiesce for
 io_uring_register
Message-ID: <20220715154444.GA17123@blackbody.suse.cz>
References: <20220204145117.1186568-1-usama.arif@bytedance.com>
 <20220204145117.1186568-6-usama.arif@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220204145117.1186568-6-usama.arif@bytedance.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hello.

On Fri, Feb 04, 2022 at 02:51:17PM +0000, Usama Arif <usama.arif@bytedance.com> wrote:
> -	percpu_ref_resurrect(ref);
> [...]
> -		percpu_ref_reinit(&ctx->refs);

It seems to me that this patch could have also changed

--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1911,7 +1911,7 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p)
        ctx->dummy_ubuf->ubuf = -1UL;

        if (percpu_ref_init(&ctx->refs, io_ring_ctx_ref_free,
-                           PERCPU_REF_ALLOW_REINIT, GFP_KERNEL))
+                           0, GFP_KERNEL))
                goto err;

        ctx->flags = p->flags;

Or are there any plans to still use the reinit/resurrect functionality
of the percpu counter?

Thanks,
Michal