Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a9adb78-d9bb-a511-e4c1-c94cca392c9b@kernel.dk>
Date:   Fri, 15 Jul 2022 10:00:17 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v6 5/5] io_uring: remove ring quiesce for
 io_uring_register
Content-Language: en-US
To:     =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>,
        Usama Arif <usama.arif@bytedance.com>
Cc:     io-uring@vger.kernel.org, asml.silence@gmail.com,
        linux-kernel@vger.kernel.org, fam.zheng@bytedance.com
References: <20220204145117.1186568-1-usama.arif@bytedance.com>
 <20220204145117.1186568-6-usama.arif@bytedance.com>
 <20220715154444.GA17123@blackbody.suse.cz>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220715154444.GA17123@blackbody.suse.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/15/22 9:44 AM, Michal Koutn? wrote:
> Hello.
> 
> On Fri, Feb 04, 2022 at 02:51:17PM +0000, Usama Arif <usama.arif@bytedance.com> wrote:
>> -	percpu_ref_resurrect(ref);
>> [...]
>> -		percpu_ref_reinit(&ctx->refs);
> 
> It seems to me that this patch could have also changed
> 
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -1911,7 +1911,7 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p)
>         ctx->dummy_ubuf->ubuf = -1UL;
> 
>         if (percpu_ref_init(&ctx->refs, io_ring_ctx_ref_free,
> -                           PERCPU_REF_ALLOW_REINIT, GFP_KERNEL))
> +                           0, GFP_KERNEL))
>                 goto err;
> 
>         ctx->flags = p->flags;
> 
> Or are there any plans to still use the reinit/resurrect functionality
> of the percpu counter?

Ah yes indeed, good catch! Would you mind sending that as an actual
patch?

-- 
Jens Axboe