Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Jul 2022 10:29:33 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     Axel Rasmussen <axelrasmussen@google.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in
 hugetlb_mcopy_atomic_pte
Message-ID: <YtGj/YYixDT0npgL@monkey>
References: <20220712130542.18836-1-linmiaohe@huawei.com>
 <20220713102357.8328614813db01b569650ffd@linux-foundation.org>
 <a47922cf-eb30-1ad9-fc96-1896254564ef@huawei.com>
 <YtA7svbn4MtuT7qJ@xz-m1.local>
 <402ae708-4c86-8feb-75c4-9339e1deac3b@huawei.com>
 <YtFfHU3fb/ncCG6O@xz-m1.local>
 <CAJHvVcgFY2uXM=CkxYmHc32Vqb5qmr8vFv0dpFk-2=Ef+Kssqw@mail.gmail.com>
 <YtGe2qIO038e627p@xz-m1.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YtGe2qIO038e627p@xz-m1.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ySlkIF8fH+mOuKoQ8Cf5hfJVztdiCyO7/+qcPGhDp3XEIfwaZaCB05zStv5e?=
 =?us-ascii?Q?oxvGoL97M3+K78QKCLGIxDuHoG+G9sWgrd33UoCrBkwn8IFdRO/9on9ivcNr?=
 =?us-ascii?Q?ZuAksAwJ26q5uPJiQ0jbsnAHXm9j0VPkjE1l3qWeG9uAj0rWOS5ihMVWqfWR?=
 =?us-ascii?Q?eqvVQ3VTeYEL0nIlM32TGDi1WZJGAK87ecnNW9D1lPVq+s51Zl0PG9GfBRpo?=
 =?us-ascii?Q?jBOqmmxZj7P1BaU+lf1lEHJRRkteUQqqeBpynugkkPnnLskifC7FJmoNJIgp?=
 =?us-ascii?Q?7ApVkKqoBA6PbaYDdxn7AbfniLuCt7DQ29fyo7XDJfIVjLvFVdI+EHVqjb6X?=
 =?us-ascii?Q?5h1P7KXeHKxQMUel3va4jkLNKslK+JeC0cg/ipBRskjdNRek9LvdJ+8lBuRN?=
 =?us-ascii?Q?28XKGpQjOCD3hQXr9emWUD3090pjMc6RLUldsfaY+nm42of3plQeTZ8bycIc?=
 =?us-ascii?Q?a1W0rqVWxc0lgiytWwWzjJLuq+2Pk1Q0nLpIFetC/0VAe8DbH042wLeiDund?=
 =?us-ascii?Q?B3cQVES/ToY9OVOTJQ9L8MbzzpqXg1Wcyf2jGazo8TlCfLKmG9g1ZbNYPJng?=
 =?us-ascii?Q?Vlutvc4YpgOuATKL2cLSTT5AL8jLRMol74e3977NBdhKAUlg3L+jaVb/tCCz?=
 =?us-ascii?Q?Q5UgSMTQ7Hsd3FepZSPK98gJ88jnOrf5i/uu7e4W8Q7k0m/yyUY4z/Itkd4h?=
 =?us-ascii?Q?eja6Qid5Q2mtLRvPoQvNHM5mTgT0IGchV3tevwPIyZwYCPuQUiCSvsDdN+47?=
 =?us-ascii?Q?24ZqyqQZW2zoorb0oUSvsGL9Yt1xwsgkl8g5kpmZVxHleaor2Gvmuaq5n+rk?=
 =?us-ascii?Q?TdsT+XaVsXn4m6WhNl6rXfZfmaM8c/h+75ufCBXFp8jTBHCTaQ41sXD0psC4?=
 =?us-ascii?Q?MWVDvrhgQqNtCyM1EhkXZUsuXePUDiMB0jTVKDbUbmSMD2rp3y4AmlVDXABS?=
 =?us-ascii?Q?al26fz9cw1oY7PUdW8d9CeoR4oqAVLVYkdCAa5dOKMnpl55bsfmPYgbYwpBK?=
 =?us-ascii?Q?KXJxBn+IrchX/LZIRUGPiY4y5xlVov9V/ZFxU9nU/GlLwxzkmjEWqoFaY7U7?=
 =?us-ascii?Q?ExSXdXAEAZzJzFWgyKg02q/EjZ/74dJiEpQrXV1lPEw8hoNCYYika8WzMQX3?=
 =?us-ascii?Q?Qsm/wQuDsSnhOIgYFHqCDLO9OPqzjJ10jOjUlOha7V2fx4UqybmnVyaAHbsT?=
 =?us-ascii?Q?gQzr0I42BR7LtpgMdyOcp6wl83ERyeuVHk/oY0bmq02uUDNeKAdhMEkI5UTr?=
 =?us-ascii?Q?xgnL0diL3f5o3yeiXdbeaK+H06ExdXaUx4QgIbybRvrf+k36tkQEupeXjXA4?=
 =?us-ascii?Q?8k7d33Xk+IwdvUJ0YRbe8yG8embv3TO31CA5OKjZok8qTZbk76SJspC8oC1w?=
 =?us-ascii?Q?0zu3gWIIfhDrlGeqZuToFfuk9umYfiYJxCwaBEqe+Hy2uASiYE5Z6SKa3/gE?=
 =?us-ascii?Q?+uZkC7Zfuqkk7I68k3/+JaHRza03DNqlRN7ZonBhNceUBucKHmyuRkmVT4HI?=
 =?us-ascii?Q?LnYOvwjd/asefhOzj0iwdJNk/J18wursevnfBztW6ftXvogi8vR4c+pv/TVr?=
 =?us-ascii?Q?5fOUBVP4IWdFXQs4idnZQomKq/P3GA97627ijeAIp6b4qRtlqNJoQF5JuVgo?=
 =?us-ascii?Q?1Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d436c34-74ba-4b55-a853-08da66879666
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 17:29:35.7836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RXiV0eT0YRopZuy9P4oe8CYttM8eA6d4PSJ9381lN/6pF1KO49s+rxnL9ZTs7SbaEYoeNPlg6uohGCA7eTD0ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4300
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-15_09:2022-07-14,2022-07-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=985 mlxscore=0 spamscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207150077
X-Proofpoint-ORIG-GUID: O3XFNg5GV7h3Tnx3OkdSViQNyFJjILIo
X-Proofpoint-GUID: O3XFNg5GV7h3Tnx3OkdSViQNyFJjILIo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/15/22 13:07, Peter Xu wrote:
> On Fri, Jul 15, 2022 at 09:45:37AM -0700, Axel Rasmussen wrote:
> > I don't really have a strong preference between the two. The second option
> > is what I originally proposed in the first version of the minor fault
> > series, so going back to that isn't a problem at least from my perspective.
> > If in the future we find a real use case for this, we could always easily
> > re-enable it and add selftests for it at that point.
> 
> I'd go for fixing the test case if possible.  Mike, would it be fine if we
> go back to /dev/hugepages path based approach in the test case?
> 

No problem going back to using a file for private mapping testing.  Removing
that was more of a simplification, because of new MADV_DONTNEED support.
Just want to make sure we also keep remap and remove event testing.
-- 
Mike Kravetz