Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b37e02f-137f-2f93-43b9-eb5bb9814e97@sifive.com>
Date:   Fri, 15 Jul 2022 18:33:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] net: macb: fixup sparse warnings on __be16 ports
Content-Language: en-GB
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        Sudip Mukherjee <sudip.mukherjee@sifive.com>,
        Jude Onyenegecha <jude.onyenegecha@sifive.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
References: <20220714084305.209425-1-ben.dooks@sifive.com>
 <20220714164336.0f2768a2@kernel.org>
From:   Ben Dooks <ben.dooks@sifive.com>
In-Reply-To: <20220714164336.0f2768a2@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/07/2022 00:43, Jakub Kicinski wrote:
> On Thu, 14 Jul 2022 09:43:05 +0100 Ben Dooks wrote:
>> -			htons(fs->h_u.tcp_ip4_spec.psrc), htons(fs->h_u.tcp_ip4_spec.pdst));
>> +		        be16_to_cpu(fs->h_u.tcp_ip4_spec.psrc),
>> +		        be16_to_cpu(fs->h_u.tcp_ip4_spec.pdst));
> 
> There are some spaces on this line, please use tabs,
> checkpatch will be able to help you validate.

Thank you, didn't spot an issue with my editor config.
Sent v2 patch