Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp686512imw; Fri, 15 Jul 2022 10:56:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v+zaOKnyN54Bo0amFq4JU8Naf2vJPeT16RVnjO43eRF88tEITRByhZlAo3CMaHuX14qdEx X-Received: by 2002:aa7:c9d3:0:b0:43a:67b9:6eea with SMTP id i19-20020aa7c9d3000000b0043a67b96eeamr20326432edt.94.1657907770114; Fri, 15 Jul 2022 10:56:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657907770; cv=none; d=google.com; s=arc-20160816; b=VE/oQx6HEp//j3QVYpxHPJQJFrhvqgnm5UdJAE2sbIBcHlgI4PHn1tS6ppMBFHffpt a5GNFiMlUpJcJAradGm2gJlUG09JhQDvuQ2IO6y4QGPb8J+6JQLgc6ymO6g+ehHIei7l j1sk3EpgSku+TOETuQU9XNhZEmXUt+pxy3zIaflQKZeFVOtKxhmJwoAvV97Ws+9FhMs0 JaEBBM7IrpV+xZ+suxaWuFgflGkZg/Tdxp3aaRxD09fqw9zflSZj2Xx2cuERmEycPYoj KG+dAp3kagD/NJVdhRqqv5+pBjl6bDhKpApi73rWnGZJuhf3Au23MBYpjMuxC/djpzsU ZXvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=FMOfvIopOBxQCHYl99LpTtFKbEuWoSv6+x2W53JYYLk=; b=Z+i34stlQZpmhQsV3VYx8vPynOGrGmRTbXppt6Erj21csl2npue3DpLQSYdqAyLXrT LmIOhvqyIr/j/nmgJnFS9uBj9NKouu4ONR3IMRjysoui7DCip66W9vis24C0CjGFvmL4 rdU4ejvBS4UIuNOtSQ5o6QbgxKjtIk7fdVjJoyQdSGK3xVunpBVBxb8dWIxnEy2Zke7+ f1oyManivDFaOEfQVIrHuUgPVJyg5ImQNW8q/+1aCzaEvIcLECHN3rHErdZtSy1QjDqm sAimDNAj+LGFgDhNXhkUTUUllyq2XTFwlxUM30eDQ7abY/LeRulTxmVBTcqqzKbq5qHZ yOag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=mQRlV8Dl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go6-20020a1709070d8600b0072b9c43063csi6695747ejc.507.2022.07.15.10.55.45; Fri, 15 Jul 2022 10:56:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=mQRlV8Dl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbiGORcR (ORCPT + 99 others); Fri, 15 Jul 2022 13:32:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbiGORcL (ORCPT ); Fri, 15 Jul 2022 13:32:11 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13BF883F2C for ; Fri, 15 Jul 2022 10:32:10 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id x18-20020a17090a8a9200b001ef83b332f5so12253313pjn.0 for ; Fri, 15 Jul 2022 10:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=FMOfvIopOBxQCHYl99LpTtFKbEuWoSv6+x2W53JYYLk=; b=mQRlV8DlMaaxNeG2XfbAzF1zmK60UayPcSr8VCl/nrS7GD0Hz8Ek6+Xmzkqy9YzFRE vTOlFc8HRN7dIU+8p9/FCK8XrYFQGek+Dw8MxJE4OIUKqW9RATDyxsigdjOr+kfppEBn BolI/CTr+WxMsIjr/7vOngm24mZPhQhV4wp/SyLKkoBHNAnY737f7X0Yysh8suT3WIe6 ZfWLCd0q8NZntCoY2QNr64tOPVLcSStDDdzN0Ickzsh5ugUC35gvp5jnWu1GAS4emJvB pj4t5piEa1sWssQgPM2IChvKctERbx8d+lzv2cjjvRFCLcLrTTCpxt4DMKHjiMGAlpFZ 4Uqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=FMOfvIopOBxQCHYl99LpTtFKbEuWoSv6+x2W53JYYLk=; b=iUdiqIlTxT4VTCzZn+lP1mASPBhxjjEVRKkN1J6zf67QWe3OzcsCx8W2745rTGd/M7 hqEh7I1VzAVzKUmJbzbNyEIF+1WPXDZtZDb0BoSmya0oatC0hc1eK/k0g3z7bnkBW/8v zhnIZanBlD4uPa9tGdX16pcHFYNvI6p6ZEviX44JHb3M3TuWPwLHPoy73nrjekKGGJpJ XoKoKCwxqcDkMI+xaJjAcGaLOAyEKJo3l0cJMyy5a1/kaqLFFMZdOHWQtqXwMFdN49J7 T1AgOApor1VnHbknhP9M7redI51LMPldpoy8td2DejqMmExifGQffwXnGvWESUud0sg6 INkQ== X-Gm-Message-State: AJIora9b1gwAc//p4RC+UJGsazgZOLbpygtHzdgMwkJ/ifOV46cNMI0s TZGue7w8du+/Yvv8cDghLgHK0A== X-Received: by 2002:a17:90b:4c8c:b0:1ef:9d26:3087 with SMTP id my12-20020a17090b4c8c00b001ef9d263087mr23322384pjb.195.1657906329569; Fri, 15 Jul 2022 10:32:09 -0700 (PDT) Received: from localhost ([50.221.140.186]) by smtp.gmail.com with ESMTPSA id y9-20020a17090a600900b001f07ce88696sm3775181pji.49.2022.07.15.10.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 10:32:08 -0700 (PDT) Date: Fri, 15 Jul 2022 10:32:08 -0700 (PDT) X-Google-Original-Date: Fri, 15 Jul 2022 10:32:04 PDT (-0700) Subject: Re: [PATCH] riscv: dts: microchip: hook up the mpfs' l2cache In-Reply-To: <20220629200732.4039258-1-conor@kernel.org> CC: daire.mcnamara@microchip.com, ivan.griffin@microchip.com, linux-riscv@lists.infradead.org, conor.dooley@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Paul Walmsley , aou@eecs.berkeley.edu, atishp@atishpatra.org, sudeep.holla@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: conor@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jun 2022 13:07:33 PDT (-0700), conor@kernel.org wrote: > From: Conor Dooley > > The initial PolarFire SoC devicetree must have been forked off from > the fu540 one prior to the addition of l2cache controller support being > added there. When the controller node was added to mpfs.dtsi, it was > not hooked up to the CPUs & thus sysfs reports an incorrect cache > configuration. Hook it up. > > Fixes: 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board") I just noticed this as I was looking over the PR I just sent, but since you're sending PRs I'm no longer re-writing your commits and thus I won't be adding stable CCs. If you want stuff CC'd to stable you'll have to either add it to the tags in the commit, or do so after the fact. > Signed-off-by: Conor Dooley > --- > arch/riscv/boot/dts/microchip/mpfs.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/riscv/boot/dts/microchip/mpfs.dtsi b/arch/riscv/boot/dts/microchip/mpfs.dtsi > index 3095d08453a1..496d3b7642bd 100644 > --- a/arch/riscv/boot/dts/microchip/mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/mpfs.dtsi > @@ -50,6 +50,7 @@ cpu1: cpu@1 { > riscv,isa = "rv64imafdc"; > clocks = <&clkcfg CLK_CPU>; > tlb-split; > + next-level-cache = <&cctrllr>; > status = "okay"; > > cpu1_intc: interrupt-controller { > @@ -77,6 +78,7 @@ cpu2: cpu@2 { > riscv,isa = "rv64imafdc"; > clocks = <&clkcfg CLK_CPU>; > tlb-split; > + next-level-cache = <&cctrllr>; > status = "okay"; > > cpu2_intc: interrupt-controller { > @@ -104,6 +106,7 @@ cpu3: cpu@3 { > riscv,isa = "rv64imafdc"; > clocks = <&clkcfg CLK_CPU>; > tlb-split; > + next-level-cache = <&cctrllr>; > status = "okay"; > > cpu3_intc: interrupt-controller { > @@ -131,6 +134,7 @@ cpu4: cpu@4 { > riscv,isa = "rv64imafdc"; > clocks = <&clkcfg CLK_CPU>; > tlb-split; > + next-level-cache = <&cctrllr>; > status = "okay"; > cpu4_intc: interrupt-controller { > #interrupt-cells = <1>;