Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220712145850.599666-1-benjamin.tissoires@redhat.com> <20220714213912.zrotlequhpgxzdl4@MacBook-Pro-3.local>
In-Reply-To: <20220714213912.zrotlequhpgxzdl4@MacBook-Pro-3.local>
From:   Kumar Kartikeya Dwivedi <memxor@gmail.com>
Date:   Fri, 15 Jul 2022 19:34:32 +0200
Message-ID: <CAP01T746cSrRgYME75O-NZvf+4NQNvtU8ZhGf5XGmXRqY6jQzQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next v6 00/23] Introduce eBPF support for HID devices
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Jiri Kosina <jikos@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Shuah Khan <shuah@kernel.org>,
        Dave Marchevsky <davemarchevsky@fb.com>,
        Joe Stringer <joe@cilium.io>, Jonathan Corbet <corbet@lwn.net>,
        Tero Kristo <tero.kristo@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 14 Jul 2022 at 23:39, Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Jul 12, 2022 at 04:58:27PM +0200, Benjamin Tissoires wrote:
> > Hi,
> >
> > and after a little bit of time, here comes the v6 of the HID-BPF series.
> >
> > Again, for a full explanation of HID-BPF, please refer to the last patch
> > in this series (23/23).
> >
> > This version sees some improvements compared to v5 on top of the
> > usual addressing of the previous comments:
> > - now I think every eBPF core change has a matching selftest added
> > - the kfuncs declared in syscall can now actually access the memory of
> >   the context
> > - the code to retrieve the BTF ID of the various HID hooks is much
> >   simpler (just a plain use of the BTF_ID() API instead of
> >   loading/unloading of a tracing program)
> > - I also added my HID Surface Dial example that I use locally to provide
> >   a fuller example to users
>
> Looking great.
> Before another respin to address bits in patch 12 let's land the first ~8 patches,
> since they're generic useful improvements.
>
> Kumar, could you please help review the verifier bits?

Sure, I'll take a look.