Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f5cab9f-9c18-7114-2ca1-ad4eff13eb63@kernel.dk>
Date:   Fri, 15 Jul 2022 12:22:05 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] io_uring: Don't require reinitable percpu_ref
Content-Language: en-US
To:     =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>
Cc:     asml.silence@gmail.com, fam.zheng@bytedance.com,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        roman.gushchin@linux.dev, usama.arif@bytedance.com
References: <8a9adb78-d9bb-a511-e4c1-c94cca392c9b@kernel.dk>
 <20220715174501.25216-1-mkoutny@suse.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220715174501.25216-1-mkoutny@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/15/22 11:45 AM, Michal Koutn? wrote:
> The commit 8bb649ee1da3 ("io_uring: remove ring quiesce for
> io_uring_register") removed the worklow relying on reinit/resurrection
> of the percpu_ref, hence, initialization with that requested is a relic.
> 
> This is based on code review, this causes no real bug (and theoretically
> can't). Technically it's a revert of commit 214828962dea ("io_uring:
> initialize percpu refcounters using PERCU_REF_ALLOW_REINIT") but since
> the flag omission is now justified, I'm not making this a revert.

Thanks, applied manually for 5.20 (new file location).

-- 
Jens Axboe