Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp718406imw; Fri, 15 Jul 2022 11:31:11 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXlDXohjlz+mf2cJ11jJqSIzQ8QZw+0MvoBU3QXiRgGNhuslixg32HRB4/+ufmTeqM5ZAB X-Received: by 2002:a17:902:b944:b0:16c:c6e4:e44b with SMTP id h4-20020a170902b94400b0016cc6e4e44bmr4590613pls.117.1657909870956; Fri, 15 Jul 2022 11:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657909870; cv=none; d=google.com; s=arc-20160816; b=Ajbsm4KcaZZY5FcKfvVDbvrgU77kAtgNFsioP0jNko0bkuiXfQYgqPYsnZKvOU8HYl LkxzqBj1gkiAvTdPktuZ15651LeTl28HqmYURJi41YXOhAByzmbLvs3P+OwhFpgPHblF Zi9BXwJneXl9wEYdQKnjtBgplfXoTBZAhE6/0Nw4Aq+LVl+Q9vlIMkCpVLiFloZXJ6je c95wwZkCvjV+tfoWUO0k2JaPCOIql1O9Vm5YtaxlGQpApKMfc8COnPAyqDQelJhv6j+A iMjVsLNJZulkScW0qivclMwxXm2j+ilVYALovLZhV+DLNM23HjY3PCEb5zj1qWJW0zi/ SMgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=zIlIOmYzM8LZQferT0hpRH67cgEzMBDIOwX8w9UtQ0I=; b=tBRpYg48kj8F/JD9SUU6xF2R05wnf65hcb17kZzPu6yhrnwr5w/E6zwpuyIHbkv6ZC CAMN4C9YxQd+f8YzldpKmN990a7Yy0VLWz87pMwxsS6fvNXnjSGTJD76Mc/hm3hBfaaU xMn2v8Wdd/P556BIML5caqImZx9oZJBSoQtB6fgPDElIC/h8Wn3+HEvo8aUGmshIa/Gr nH9oZhyipXu0G01ohU5S35rwMZkUdyx/olDD3qh2cbHmNMvOhbiOYyZoYRenm89SKTGI Au8VWjv/2yRU7Yh4LCRqUBOLPY9yPEBK1/IpZrQHlXAj8N1iIBjVoxbe0MZ2BNa8/tkx H94g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b64-20020a636743000000b00419a2de79b6si6041955pgc.305.2022.07.15.11.30.55; Fri, 15 Jul 2022 11:31:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbiGOSZh (ORCPT + 99 others); Fri, 15 Jul 2022 14:25:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbiGOSZg (ORCPT ); Fri, 15 Jul 2022 14:25:36 -0400 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C50B0675B8 for ; Fri, 15 Jul 2022 11:25:35 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:47016) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oCQ0N-00GNfN-14; Fri, 15 Jul 2022 12:25:35 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:47774 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oCQ0M-00C0xe-4w; Fri, 15 Jul 2022 12:25:34 -0600 From: "Eric W. Biederman" To: Uros Bizjak Cc: linux-kernel@vger.kernel.org, Alexey Gladkov References: <20220713155405.80663-1-ubizjak@gmail.com> Date: Fri, 15 Jul 2022 13:25:27 -0500 In-Reply-To: <20220713155405.80663-1-ubizjak@gmail.com> (Uros Bizjak's message of "Wed, 13 Jul 2022 17:54:03 +0200") Message-ID: <87ilnyz10o.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1oCQ0M-00C0xe-4w;;;mid=<87ilnyz10o.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1+c8LVUlqZsyYj+hQijEsgfPB7eQK9MRD8= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *****;Uros Bizjak X-Spam-Relay-Country: X-Spam-Timing: total 321 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 12 (3.6%), b_tie_ro: 10 (3.2%), parse: 1.06 (0.3%), extract_message_metadata: 13 (4.0%), get_uri_detail_list: 0.90 (0.3%), tests_pri_-1000: 13 (4.2%), tests_pri_-950: 1.24 (0.4%), tests_pri_-900: 0.96 (0.3%), tests_pri_-90: 125 (38.9%), check_bayes: 122 (38.0%), b_tokenize: 7 (2.1%), b_tok_get_all: 4.8 (1.5%), b_comp_prob: 2.3 (0.7%), b_tok_touch_all: 100 (31.1%), b_finish: 1.66 (0.5%), tests_pri_0: 135 (42.0%), check_dkim_signature: 0.62 (0.2%), check_dkim_adsp: 3.1 (1.0%), poll_dns_idle: 0.67 (0.2%), tests_pri_10: 3.1 (1.0%), tests_pri_500: 14 (4.5%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 0/2] ucount: Fix and improve atomic_long_inc_below X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Uros Bizjak writes: > The series fixes wrong argument type and improves atomic_long_inc_below > by using atomic_long_try_cmpxchg instead of atomic_long_cmpxchg. > > Signed-off-by: Uros Bizjak > Cc: "Eric W. Biederman" The bug fix at least looks correct. I haven't reviewed the atomic_long_try_cmpxchg yet. Thanks, Eric > > Uros Bizjak (2): > ucount: Fix atomic_long_inc_below argument type > ucount: Use atomic_long_try_cmpxchg in atomic_long_inc_below > > kernel/ucount.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-)