Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Eric W. Biederman" <ebiederm@xmission.com>
To:     Hangyu Hua <hbh25y@gmail.com>
Cc:     akpm@linux-foundation.org, songmuchun@bytedance.com,
        longman@redhat.com, roman.gushchin@linux.dev, legion@kernel.org,
        linux-kernel@vger.kernel.org
References: <20220715062301.19311-1-hbh25y@gmail.com>
Date:   Fri, 15 Jul 2022 13:20:23 -0500
In-Reply-To: <20220715062301.19311-1-hbh25y@gmail.com> (Hangyu Hua's message
        of "Fri, 15 Jul 2022 14:23:01 +0800")
Message-ID: <87v8ryz194.fsf@email.froward.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH] ipc: mqueue: fix possible memory leak in init_mqueue_fs()
Precedence: bulk

Hangyu Hua <hbh25y@gmail.com> writes:

> commit db7cfc380900 ("ipc: Free mq_sysctls if ipc namespace creation
> failed")
>
> Here's a similar memory leak to the one fixed by the patch above.
> retire_mq_sysctls need to be called when init_mqueue_fs fails after
> setup_mq_sysctls.

Alex can you review this change?

> Fixes: dc55e35f9e81 ("ipc: Store mqueue sysctls in the ipc namespace")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
>  ipc/mqueue.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 12ad7860bb88..83370fef8879 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -1746,6 +1746,7 @@ static int __init init_mqueue_fs(void)
>  	unregister_filesystem(&mqueue_fs_type);
>  out_sysctl:
>  	kmem_cache_destroy(mqueue_inode_cachep);
> +	retire_mq_sysctls(&init_ipc_ns);
>  	return error;
>  }

Thanks,
Eric