Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp753897imw; Fri, 15 Jul 2022 12:12:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vjNNlJxFfOI1KH2u64q4LMPbkwKdb1HOViMTbZxXxggrDiHj0dqZUefklScY7ZVDOj4j5N X-Received: by 2002:a17:906:cc5d:b0:72b:1313:cd09 with SMTP id mm29-20020a170906cc5d00b0072b1313cd09mr15232682ejb.482.1657912341981; Fri, 15 Jul 2022 12:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657912341; cv=none; d=google.com; s=arc-20160816; b=QNXpT/pCbvvR4tFylcWUN3FBpVP48HrHaxv315dqHdH/6h5y4llR+2+lJ1+b/co5BG rTanhJjNNUCAbcSQhvY213/wDCoZuwQAqubEc3VDtCGQ7ug5pqXWtFiO6N6FqshLNAzN CLzc0bCpm9pSFUB/dOi/ZrhlRxPCWWRMQ1fhY8YFdDkHDtokEGCDEY9iPodcKryES3Xv 9rTe+2pVRXCxUINXX+48j0fp3G5MI5dA++V2aem1jk4grb8VUz0xMl4FrrE7p84osEOX UQZLalKE2kxa4QmLpxdw/Q5q0RTx15eGUbHzI7WO4Bh1IindXCZNgZNbHJL34RdVZrLh J4Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=Px5WoIkjyQI+1PtxcAg9Bsov7I6ALdL/F5TEuKn+JYU=; b=SdjO96O6w1gg+LiTjXzZyoyEK0BbkQzUQDWnFYSnrlixwoB3dmjopZy6e0oRJTL8TP fgmba1juyFwF34vyCeAuthIqknaRDvNZ9Nffbsj4K87DBnnrvS0oRp9P9M5ydXnt5PzT //ppqCu67QjzchNSiT8XR+fovqnvgWNIrqPVSIgynrOmERr9rvd+vqgy++DM9r5ZnxME 18Iqn8gdKx6Efd7wRrDyx+dYzpXjuERB6ND7Oai9CAx/V/KAyrqd/ktpI9POPWBIV3Ps 4V2uG1S21BFg7UhTgmuj3vfo6701IrauuLKtwO9CAzQjY/VgyIWqulQtqZjq9kt1awMb cHlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfZGg70E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a056402274300b0043ad89e8c77si7708158edd.14.2022.07.15.12.11.49; Fri, 15 Jul 2022 12:12:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfZGg70E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbiGOS1Y (ORCPT + 99 others); Fri, 15 Jul 2022 14:27:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbiGOS1W (ORCPT ); Fri, 15 Jul 2022 14:27:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 332CE67CA2; Fri, 15 Jul 2022 11:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3A5C6232B; Fri, 15 Jul 2022 18:27:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92F95C34115; Fri, 15 Jul 2022 18:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657909638; bh=GLrIOUKfTCEiitR+k/dayuHMYy8E4I2pvFk24p8afZA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=jfZGg70EGZ58zaDDn8ZKKNJ8DPyDu0cAcpK/AV7rGjYSqpmQotBcWt0MgwPOkhep0 pAYxNSAtmitca9ADEZoaQJ0IJD3UrZ5iPwUfV3JOSWUl6i/cvE261pirar6sgIjY1t iT6n2bxgn81JNrPKzAMPg+MHWDVbgmtelLQe0pycRpH5zQn7IIDq3h86fb0WmjpmBD uNK96PLwO+cq3NzoacPSPLbZbf2ajetQ8iela16p3uWFLra+7JAGgnmpp5f2S+wPt6 CKIJ9hC+1Sq0bRYCkqw8svNte0bM0tC948wdr87usqzTnRIYj49UFYk+ajYRDOvMhp MaglZ3Q/Xe+ZQ== Date: Fri, 15 Jul 2022 13:27:15 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring Subject: Re: [PATCH v1 0/4] PCI: brcmstb: Re-submit reverted patchset Message-ID: <20220715182715.GA1145359@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701162726.31346-1-jim2101024@gmail.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 12:27:21PM -0400, Jim Quinlan wrote: > A submission [1] was made to enable a PCIe root port to turn on regulators > for downstream devices. It was accepted. Months later, a regression was > discovered on an RPi CM4 [2]. The patchset was reverted [3] as the fix > came too late in the release cycle. The regression in question is > triggered only when the PCIe RC DT node has no root port subnode, which is > a perfectly reasonsable configuration. > ... > Jim Quinlan (4): > PCI: brcmstb: Split brcm_pcie_setup() into two funcs > PCI: brcmstb: Add mechanism to turn on subdev regulators > PCI: brcmstb: oAdd control of subdevice voltage regulators > PCI: brcmstb: Do not turn off WOL regulators on suspend > > drivers/pci/controller/pcie-brcmstb.c | 257 +++++++++++++++++++++++--- > 1 file changed, 227 insertions(+), 30 deletions(-) I'm assuming there's a v2 coming soonish? We should see -rc7 this weekend and likely a final v5.19 release on July 24, so v5.20 material should be tidied up by then. Bjorn