Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220715224443.46ce75ca@canb.auug.org.au> <87fsj2v3oq.wl-tiwai@suse.de>
In-Reply-To: <87fsj2v3oq.wl-tiwai@suse.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 15 Jul 2022 21:09:41 +0200
Message-ID: <CAHp75Vf1O0AEkdNvAoGQ-nM9Pbx-nFtA5-GH=z=TZF_xTgfY3A@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the sound tree
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 15, 2022 at 5:39 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Fri, 15 Jul 2022 14:44:43 +0200,
> Stephen Rothwell wrote:
> >
> > Hi all,
> >
> > After merging the sound tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
> > sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
> >   693 |         status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
> >       |                                           ^~
> >
> > Caused by commit
> >
> >   d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")
> >
> > along with commit
> >
> >   eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")
> >
> > I have reverted commit d60b05b4c780 for today.
>
> Thanks.  Now I reverted the commit on for-next branch as a workaround,
> too.

Thanks! OTOH it means it's working well :-)

Nevertheless, I have prepared a series to deduplicate this _SUB code
and I think the ACPI would stay as a compile dependency because of
that change anyway.


-- 
With Best Regards,
Andy Shevchenko