Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp813255imw; Fri, 15 Jul 2022 13:25:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tz09tw7G2Jx3gX9GjqcXoxdQitnEjx9Ok3GG82MjeO2kZIRwiAz5is4ekzvaNl1Ca76Sk3 X-Received: by 2002:a17:903:1c8:b0:16c:4e2f:926f with SMTP id e8-20020a17090301c800b0016c4e2f926fmr15466556plh.76.1657916707069; Fri, 15 Jul 2022 13:25:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657916707; cv=none; d=google.com; s=arc-20160816; b=tLkB3itQzLPpqarO2mNYC1dsOuJ4GFRCZpIZJxPzZL3e0YUDM7/W49ufUmIKTvAJLi SjtocZRxUWJZ9hMYkof6bEWya7dI4Rn0MCOlbeZvVuhMXeMP1sa32QcLzA7qjMh2ZDYd jmfkk7yO/6IX1ITMSk1kPoHO5hteWdcbQNWufpZKKEqsrSvigYDPMrj3NXbrumF0rJQb 8Q64rn6i85irflFPrsg1xwAhoBPit9viTfLzZD2UbxaCTG7r6BOcPaaqbwxYYOT++z4i bDHeP70DnwAAqC0LMnevLwgavkTQoh85PZWrOVGpzZqC1mmEk0buMZzNZ46LoEVpxkYQ dJ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9bthFWGGZOgnq5tOIwG+Zuw9iuhfZaoSbS5HHpWv5nk=; b=tEnRJnEoPImXbEyNOmKYtfcHblQ+eGNFo007+YzaTtgtk70TJHC3PXb2prrYpEiKLk cy+/WyCyJNGLtJ3VW0qw+1gD7KUqX/9oc3GMuLAs4cfimucnEg2lSsJfUCSfEBp5Bs8B a+cNgiK2B7fFfruC4Q6lFQncq2iM0EkfdGyY4EYqmbfvgG/AWoqKRM48KIJTN3hj/hxe Qqe6VICgf20k/h2cL/H0zGwUPO6AGkG4YLXWAk5+JwTryaVk/jf2lF5OAkX4KOmpQAT6 EIkyP/gNDLwHKrWwEO42LI+Yplq67abYDIivywqPRFCZ7g5vJ1zvPSK9nUDM9TcAsnXk zEtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a632c09000000b00419c1361f5bsi5809762pgs.171.2022.07.15.13.24.49; Fri, 15 Jul 2022 13:25:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230072AbiGOUQK (ORCPT + 99 others); Fri, 15 Jul 2022 16:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbiGOUQJ (ORCPT ); Fri, 15 Jul 2022 16:16:09 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99A1F4598A for ; Fri, 15 Jul 2022 13:16:07 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1oCRjG-0006Zz-Rp; Fri, 15 Jul 2022 22:16:02 +0200 Date: Fri, 15 Jul 2022 22:16:02 +0200 From: Martin Kaiser To: Michael Straube Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] staging: r8188eu: remove SetHwReg8188EU() Message-ID: <20220715201602.bnmexv2uzmnkusjf@viti.kaiser.cx> References: <20220715062908.8547-1-straube.linux@gmail.com> <20220715062908.8547-6-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220715062908.8547-6-straube.linux@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, Thus wrote Michael Straube (straube.linux@gmail.com): > Remove the case HW_VAR_CORRECT_TSF from SetHwReg8188EU() and move the > functionality to the function that calls SetHwReg8188EU() with > HW_VAR_CORRECT_TSF. SetHwReg8188EU() is empty now and we can finally > remove it. nice work :-) For the whole series: Tested-by: Martin Kaiser