Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>, netdev@vger.kernel.org
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        linux-arm-kernel@lists.infradead.org,
        Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net-next v3 32/47] net: fman: Specify type of mac_dev for exception_cb
Date:   Fri, 15 Jul 2022 17:59:39 -0400
Message-Id: <20220715215954.1449214-33-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-1-sean.anderson@seco.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ah9B7cwfqwMre55+ElsGIWVYuNiQXUlocxc8Rem8M74/dcSa4Fek8L15l/xV?=
 =?us-ascii?Q?/2Kaz+HPf/w3DP+IOO1M9PoFCd7efygBmaZOETdefsI4xDrsyw9UJY6Sc5hl?=
 =?us-ascii?Q?pvAABOc6F9kleuRBbXN6y0kKwc+YC9cOWVStMdkxUJ18LlU8uH4EpLVpAeOF?=
 =?us-ascii?Q?QiqjqZ4kyHVTZbkYRKdPKjUsMZlRVWx8EpE0MLRnXh4ou0FicKr3yTpnnp4H?=
 =?us-ascii?Q?w4ocBzB95mhcxO4D00D9s7gj0+LA74+FurqaWtz7xo+IxlO41UJN6aa4AHZp?=
 =?us-ascii?Q?Sj9sguf4Ni0sRb1hZyZyGSD96yeZ9XpjbDJWLHvAexTGcUsrLhtac++uC4fn?=
 =?us-ascii?Q?c4yC4OriLgMZqYPF6GgIgt0vvHJQI7cpJaubpDM858ee32WXch5Sh8QYSpPJ?=
 =?us-ascii?Q?DGeP+l8QxXoeS3ZxW0Zt2l5exARTPOTbMkCd/FddT0NRZBn1n/Yph2/NM0Sc?=
 =?us-ascii?Q?nAV3jA+FyPZEHvcYE92hzVY/IBECSC3xFkPpM7iG7pftlGeXE+JNEEvgqOhs?=
 =?us-ascii?Q?wUQp+MXbCaG+zpoDv4dXosgxdSLRU/90pfrrorVQP+eaLqlwtffgVC15pm5Y?=
 =?us-ascii?Q?LClxepV8TzDaWPZ6A8wyqgJ+zMDMGKY1zCgm2GVeoNNavzsIrPSQYNH/fRNW?=
 =?us-ascii?Q?1oEsU3A43mCB6g5r8w5r9pW2Sls3EXItzqtcvSaxomuTgdkEMI9Nrh7PmvDd?=
 =?us-ascii?Q?A/FbITxW7IHbzyGgLFL5KcD/dIbQbzfgCiEWlw2PaEzmUmUIVCSoEUIvqZnO?=
 =?us-ascii?Q?vaYOwnalz7dY2TUTfX4hy1mbLT/oWxuLonM1ppaKG1duENC3QrCsH3R83m8c?=
 =?us-ascii?Q?7Dbh/++fcvgGLrDJMzcn0Y3sGBfJnNoSsMc5GBYxozcMocnH6J46+S7BHIcp?=
 =?us-ascii?Q?7jJsv7Df/8gjhfTi8XYphbWIF1dSnhWZCGHnp0Pxzku4YaXLiKnhPqJb2ZIF?=
 =?us-ascii?Q?0SO3TGOKTbH/Rn+enPNGaDbnHKAzMnEZTku3MSlVIOqHh86k2zdznfnHMWt3?=
 =?us-ascii?Q?j7Bn7viEyp1Xd3Dc967kNzNe/8SpmBg2Jgf6bNcoyTlmh8uLAT3/TK2eINI+?=
 =?us-ascii?Q?nWkopXZ7DkkSkTEtvf82TOCZ7jd6WEFVeeOMJ3WCn+1yH8O/LBzpOscaLnOb?=
 =?us-ascii?Q?pWT127os3H1FH2O73UyjQ8dmPCo535qcM+VCG8dMS7FQLlRq+vxcg9CoDMRA?=
 =?us-ascii?Q?ASZaPYdOiCINeXsfaGRIMJZN1kWCVDuKZRDzsiEHyzGscohlmb5rA5fcSclq?=
 =?us-ascii?Q?o+xXCrvxxWYMwgdZgvRlf1lN3ZbFdNwEl6y4xfv89uMFOvoVvj9D4S1s9jD8?=
 =?us-ascii?Q?cfa3SXKq9siM1OsW3sGSBSvvlxbiDvDntT7UUocYpsWLbwhvXfPGcnkvCw6t?=
 =?us-ascii?Q?YRdpCWlIYMLnsq2UJvbY5wNmaQEIGn1rC9bRXxG9K4YHOxOgO3XgC/z1f3Ca?=
 =?us-ascii?Q?+RZmG0TNq7KZsiBuekDwOC8mytHkXwcEVXb77yMSBWmXuVLUX8nmK/lOXaWV?=
 =?us-ascii?Q?aj1DFPnODSaL/fG1AekNeJtByV8UVNLQBca7h1CBWHMjgPMMAl4zoxLdVxeU?=
 =?us-ascii?Q?2pGBwLYeNAEdD/Hc1Y673l/6jmawuJqt0FM6VjYdQ42ziqWZR57mhfJZqQvf?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 443fd466-fd3b-4e67-5c55-08da66ad8fb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB4973.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 22:01:25.3933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2QnK95Cb5Af4zr1KLS6ELQPTGSkOYcHL8xtOTT4JH4s95Huc+ilQBvCdgJ/bpM7XCKLHekuwOY2TGd2W7E91BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB2902
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Instead of using a void pointer for mac_dev, specify its type
explicitly.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

(no changes since v2)

Changes in v2:
- New

 drivers/net/ethernet/freescale/fman/fman_dtsec.c | 2 +-
 drivers/net/ethernet/freescale/fman/fman_mac.h   | 5 +++--
 drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +-
 drivers/net/ethernet/freescale/fman/fman_tgec.c  | 2 +-
 drivers/net/ethernet/freescale/fman/mac.c        | 5 ++---
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
index 09ad1117005a..7acd57424034 100644
--- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
@@ -301,7 +301,7 @@ struct fman_mac {
 	/* Ethernet physical interface */
 	phy_interface_t phy_if;
 	u16 max_speed;
-	void *dev_id; /* device cookie used by the exception cbs */
+	struct mac_device *dev_id; /* device cookie used by the exception cbs */
 	fman_mac_exception_cb *exception_cb;
 	fman_mac_exception_cb *event_cb;
 	/* Number of individual addresses in registers for this station */
diff --git a/drivers/net/ethernet/freescale/fman/fman_mac.h b/drivers/net/ethernet/freescale/fman/fman_mac.h
index 730aae7fed13..65887a3160d7 100644
--- a/drivers/net/ethernet/freescale/fman/fman_mac.h
+++ b/drivers/net/ethernet/freescale/fman/fman_mac.h
@@ -41,6 +41,7 @@
 #include <linux/if_ether.h>
 
 struct fman_mac;
+struct mac_device;
 
 /* Ethernet Address */
 typedef u8 enet_addr_t[ETH_ALEN];
@@ -158,8 +159,8 @@ struct eth_hash_entry {
 	struct list_head node;
 };
 
-typedef void (fman_mac_exception_cb)(void *dev_id,
-				    enum fman_mac_exceptions exceptions);
+typedef void (fman_mac_exception_cb)(struct mac_device *dev_id,
+				     enum fman_mac_exceptions exceptions);
 
 /* FMan MAC config input */
 struct fman_mac_params {
diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 2f3050df5ab9..19619af99f9c 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -311,7 +311,7 @@ struct fman_mac {
 	/* Ethernet physical interface */
 	phy_interface_t phy_if;
 	u16 max_speed;
-	void *dev_id; /* device cookie used by the exception cbs */
+	struct mac_device *dev_id; /* device cookie used by the exception cbs */
 	fman_mac_exception_cb *exception_cb;
 	fman_mac_exception_cb *event_cb;
 	/* Pointer to driver's global address hash table  */
diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c b/drivers/net/ethernet/freescale/fman/fman_tgec.c
index 2642a4c27292..010c0e0b57d7 100644
--- a/drivers/net/ethernet/freescale/fman/fman_tgec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c
@@ -180,7 +180,7 @@ struct fman_mac {
 	/* MAC address of device; */
 	u64 addr;
 	u16 max_speed;
-	void *dev_id; /* device cookie used by the exception cbs */
+	struct mac_device *dev_id; /* device cookie used by the exception cbs */
 	fman_mac_exception_cb *exception_cb;
 	fman_mac_exception_cb *event_cb;
 	/* pointer to driver's global address hash table  */
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 0f9e3e9e60c6..66a3742a862b 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -41,10 +41,9 @@ struct mac_address {
 	struct list_head list;
 };
 
-static void mac_exception(void *handle, enum fman_mac_exceptions ex)
+static void mac_exception(struct mac_device *mac_dev,
+			  enum fman_mac_exceptions ex)
 {
-	struct mac_device *mac_dev = handle;
-
 	if (ex == FM_MAC_EX_10G_RX_FIFO_OVFL) {
 		/* don't flag RX FIFO after the first */
 		mac_dev->set_exception(mac_dev->fman_mac,
-- 
2.35.1.1320.gc452695387.dirty