Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>, netdev@vger.kernel.org
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        linux-arm-kernel@lists.infradead.org,
        Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net-next v3 39/47] net: fman: memac: Add serdes support
Date:   Fri, 15 Jul 2022 17:59:46 -0400
Message-Id: <20220715215954.1449214-40-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-1-sean.anderson@seco.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9vJd+Cifz5TWsOKggSQ1F+CWEPtT6xxwprsLitYH2BAd8U4CzHh1fF5VWPDt?=
 =?us-ascii?Q?v50eFuziV7sAbnYCqo7+GMFRFgzZwOgwATCgw+GG8bZHz639RjFqoqPbrd9J?=
 =?us-ascii?Q?iiTdZGCAgOOQ6KmM1GQnsvwKeedSQy2XqLglLfTn6x2RnopaBsgv7/jj0vKs?=
 =?us-ascii?Q?BJX2f2Ny9n7FRJ5WK4OpJJX/Is9XkxKwOWuiZ19oF0k0cL8nwn7m31ktxscx?=
 =?us-ascii?Q?G9R3QpQdyonlAugU/uOk8oq2bpNNqWs2fkqm30t5vy8UHh8xjdg5ElfqDWnU?=
 =?us-ascii?Q?gx2jrJh6uXQvM+cE9u6JWKYOmdcS3BC1imiCUbj4E4AX4v6q11Q7xkd3Spto?=
 =?us-ascii?Q?zsQf1FmTJIydzlX3HM96OvXdo/1kdpT2a6bs2S4JABNx87cQW2tWyA7Ce1mi?=
 =?us-ascii?Q?BGOP5Jfg+c2gW5MPcpXuoDuYqtBJPNDPXvLNG9i01eNEQ47eNQFCwPCILBng?=
 =?us-ascii?Q?pi9KpzPfJucC1wfYC9Qwf8iwxC6+/lev1lGKKXTD5VQbyI5At7SE0Dmv0LJF?=
 =?us-ascii?Q?5Qds4oKEGNqjPnfINAWOAftk46Uh0roKBk6vr2fRegw5BfNgFTVutUxlguC2?=
 =?us-ascii?Q?Oh9DhGV1dUbThVLzIJNMqZNR6boRcNOLQ+LDRMPo3iH2Pay+pEEFZ02J2jFR?=
 =?us-ascii?Q?0jc86v0o+bNG7GR/Oz6U66LcyABQkdvzCUG5r4weeX6qvbotJTX/iLInr7Ke?=
 =?us-ascii?Q?stSY7Z1WTNU4qUnHXDb2HHDNRRse36JbUIQFhOqck3oTPTyPBOWVbJ4g+V7i?=
 =?us-ascii?Q?77kXD4Gahbbu2oymySSOz2dbbJN8cFaZ0I4z0Yxkvzm/50tgQmOVT8cEx72V?=
 =?us-ascii?Q?E2FPzbrs6CCsKKttb0gzLhW+RTGND1d2m4jeOB/z6vtEUNBlB8a8XUIJZ63U?=
 =?us-ascii?Q?/BmPrd0VDouJpMiwEN/bDmdHp/yMCf7IIUSuzHpmt/fwIKy3EAxHXi9dq1y0?=
 =?us-ascii?Q?PhnDGucH04afmNeXG8B/av7NSC0JrX0mYRL29zsRZk4O4eIBiEtgxv2aic6X?=
 =?us-ascii?Q?hyWRKWNZ2xMgdNBYb6E/fQN6mxV1VTxuO3FeXWdjFBeOJdJV0dwDHJ4/5Wb+?=
 =?us-ascii?Q?UvDQCFxQJRzIJOyhT5u4hp9TJphrGwmZtExdrd8q2YKWxEScXjOpChWItwxQ?=
 =?us-ascii?Q?ZR/sv3ec1JhvaeufHQo6yrFmVWlC+pwK4SkIz7Asvz3WKwEpdGpl3Xdn9vaO?=
 =?us-ascii?Q?p2WQ/10LAjdtJG2J65l/3/VIRmkv3gllJ7KRN6InV9p+4sUjT0d87SCjtESN?=
 =?us-ascii?Q?Ff7peSLp/3d94uoFU6IX/GM54S4S8AznTruS+Xj3K4wjBWTXktR5kfBCEXKi?=
 =?us-ascii?Q?TIkx31v0KijMEE6iAQaleFoQciizZMq6HX6Y17mE4u19V78rALlfwCXkmZMU?=
 =?us-ascii?Q?bV+GRphy8sgpODMtl4oDZM+RBHhbxKCurn5AzT9lyl+E4wryCRcaT7avcmgq?=
 =?us-ascii?Q?TqjQlVTBZkATaZDJ3Gc4TBv5/574kThH7T7nen9HS79A95x+Ldive1heiZsV?=
 =?us-ascii?Q?o7if7hH6f8jggZ8+uCt0lYrkmPi2AsX/aCD/628A3kCTGkZPq8Tk9YY9vR7P?=
 =?us-ascii?Q?fQDflQ2BhIUFcuKUzz1rZ4Bn9SARh6VPvy1CWnToIIBvwLSgL+eBI/VPG2o1?=
 =?us-ascii?Q?ZQ=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b9caab0-92a8-4540-bf88-08da66ad9912
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB4973.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 22:01:41.1583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: la6Km+ZNriU/8ch3qWVKrSdycvl36Nd25KBtB+WI/7vCMq03EWzjK7O9Mi18nV1i1G0xmWfOZGvbl5GIUH0GFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR03MB2857
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This adds support for using a serdes which has to be configured. This is
primarly in preparation for the next commit, which will then change the
serdes mode dynamically.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

(no changes since v1)

 .../net/ethernet/freescale/fman/fman_memac.c  | 48 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 02b3a0a2d5d1..a62fe860b1d0 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/phy.h>
 #include <linux/phy_fixed.h>
+#include <linux/phy/phy.h>
 #include <linux/of_mdio.h>
 
 /* PCS registers */
@@ -324,6 +325,7 @@ struct fman_mac {
 	void *fm;
 	struct fman_rev_info fm_rev_info;
 	bool basex_if;
+	struct phy *serdes;
 	struct phy_device *pcsphy;
 	bool allmulti_enabled;
 };
@@ -1203,17 +1205,55 @@ int memac_initialization(struct mac_device *mac_dev,
 		}
 	}
 
+	memac->serdes = devm_of_phy_get(mac_dev->dev, mac_node, "serdes");
+	if (PTR_ERR(memac->serdes) == -ENODEV) {
+		memac->serdes = NULL;
+	} else if (IS_ERR(memac->serdes)) {
+		err = PTR_ERR(memac->serdes);
+		dev_err_probe(mac_dev->dev, err, "could not get serdes\n");
+		goto _return_fm_mac_free;
+	} else {
+		err = phy_init(memac->serdes);
+		if (err) {
+			dev_err_probe(mac_dev->dev, err,
+				      "could not initialize serdes\n");
+			goto _return_fm_mac_free;
+		}
+
+		err = phy_power_on(memac->serdes);
+		if (err) {
+			dev_err_probe(mac_dev->dev, err,
+				      "could not power on serdes\n");
+			goto _return_phy_exit;
+		}
+
+		if (memac->phy_if == PHY_INTERFACE_MODE_SGMII ||
+		    memac->phy_if == PHY_INTERFACE_MODE_1000BASEX ||
+		    memac->phy_if == PHY_INTERFACE_MODE_2500BASEX ||
+		    memac->phy_if == PHY_INTERFACE_MODE_QSGMII ||
+		    memac->phy_if == PHY_INTERFACE_MODE_XGMII) {
+			err = phy_set_mode_ext(memac->serdes, PHY_MODE_ETHERNET,
+					       memac->phy_if);
+			if (err) {
+				dev_err_probe(mac_dev->dev, err,
+					      "could not set serdes mode to %s\n",
+					      phy_modes(memac->phy_if));
+				goto _return_phy_power_off;
+			}
+		}
+	}
+
 	if (!mac_dev->phy_node && of_phy_is_fixed_link(mac_node)) {
 		struct phy_device *phy;
 
 		err = of_phy_register_fixed_link(mac_node);
 		if (err)
-			goto _return_fm_mac_free;
+			goto _return_phy_power_off;
 
 		fixed_link = kzalloc(sizeof(*fixed_link), GFP_KERNEL);
 		if (!fixed_link) {
 			err = -ENOMEM;
-			goto _return_fm_mac_free;
+			goto _return_phy_power_off;
 		}
 
 		mac_dev->phy_node = of_node_get(mac_node);
@@ -1242,6 +1282,10 @@ int memac_initialization(struct mac_device *mac_dev,
 
 	goto _return;
 
+_return_phy_power_off:
+	phy_power_off(memac->serdes);
+_return_phy_exit:
+	phy_exit(memac->serdes);
 _return_fixed_link_free:
 	kfree(fixed_link);
 _return_fm_mac_free:
-- 
2.35.1.1320.gc452695387.dirty