Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b6d2fed-f357-9426-b6fd-cb4864180842@fb.com>
Date:   Fri, 15 Jul 2022 17:17:06 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH bpf-next v6 04/23] selftests/bpf: add test for accessing
 ctx from syscall program type
Content-Language: en-US
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Jiri Kosina <jikos@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Shuah Khan <shuah@kernel.org>,
        Dave Marchevsky <davemarchevsky@fb.com>,
        Joe Stringer <joe@cilium.io>, Jonathan Corbet <corbet@lwn.net>
Cc:     Tero Kristo <tero.kristo@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org
References: <20220712145850.599666-1-benjamin.tissoires@redhat.com>
 <20220712145850.599666-5-benjamin.tissoires@redhat.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220712145850.599666-5-benjamin.tissoires@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjNCZ0x5QS9CZ1Btb2k1TDBYdytKckQ2eExjVlh1ZUJDa1pmWGZTWXVGb0Rr?=
 =?utf-8?B?cTFxSktWdTdZSm1aeDVmL1lIWEJvYlVoT0QwN2ZjbDFkbmdEdWM3aDJFYW9P?=
 =?utf-8?B?ZWQrNlNQS0lXMUtYdlg2cmtoVWllTlQ1dVI2UVIwdHI2R3BVNEtiQUFiaWtV?=
 =?utf-8?B?UlZtb3V3ZUlpRkc4Nzc2VHpUc211TnM2b280ajMySzdtWThKS2pJS3BydkdU?=
 =?utf-8?B?SitKL1hHaTFWTjRtdTdLOEt1eTJMZ004SmpBUmh1dHJkREN2c2cyRksrZW1s?=
 =?utf-8?B?d0xyZ0R5Q3orOGgvWGNxbWRsd2V6REh0MHN3cUR6MUZMTEEyZXBtVGNUMVM0?=
 =?utf-8?B?K09PVWJXY3hWbUdNSUQ0cmdac3p3bGVMYmxUcC9TZDcxUFlDRFRzbjBLT2Nx?=
 =?utf-8?B?MllOZEJnc0NxTVp1R3c1cjNIL1J3alo3UGZudFlsaUY5T0pLaGs2Tk5pTHA5?=
 =?utf-8?B?QkFwTDErWENEbC9NU3RGM05zSjB1WjRVL1dzMGQxTitUbng0Zlh3aDBhY2hR?=
 =?utf-8?B?dGh6MW84UUoxeVRsMnAxME5sa2pKbmZsRlFSaHFhMUlhNkR4MTlkaWNiOGt4?=
 =?utf-8?B?WkRKbzVtbGVrTzJIYVNUbXZibGxvWmd6QXBwMTdtdTJIaEpKem0zSGxiY2t2?=
 =?utf-8?B?L0k5M1BRTDMzY3MvNWhpSmNIcDlLZW9ueGNDVHFNeUFYbldhUFhoUmV6elFm?=
 =?utf-8?B?Yk1BRzE0M1JpbTg2bHAzZVI2aHNQQnZ2cTAxbHFtcndDMEpCcXZ1ZVpkQzFT?=
 =?utf-8?B?NEtPTFY5SUhPZURwSDlvenI0b2Z6WVJ4SmFJcFRLOUdFaFpLaVBWYjFDU1V2?=
 =?utf-8?B?UVJ4WC9XUXljSFpvOGlKVVBKdTNIeWo3UjVzc2U2dnVzUlVjcFFFM2puc1Rm?=
 =?utf-8?B?TEVkYnNqcm5zRWozR0NKeWNnaTFwaUk3akM0ZzVUSzRRWTE4cXdvNHZ1amZa?=
 =?utf-8?B?RnZUQzNyOUI5bU96STdPUjg3ZDVaVkc5dUVWMUtSQUpqdTI1bSsrQVVVRzJO?=
 =?utf-8?B?SzlwaDN0OW5CMU1WT3JJTXlUMi9BTFVHNHhyRUQ3TExkZHlJdzJrTnVuaUJv?=
 =?utf-8?B?M0ZZdE9iTWd3cFJMckwvb1JxdHo0MlNlZk41TXBoWHhWZ2ZMeTVoN0ZDRk81?=
 =?utf-8?B?VEhuanJQQWljdC82MDJHMjE3bHRFZURtZm9SS1FySk9aaFNqQ1UvQ1hjQWxR?=
 =?utf-8?B?clMwNWNaeTF6ZU4ra3VWM00vaHg0WnVPNVdTeFVsVExqTzEwSkZNejJpNjJM?=
 =?utf-8?B?RHdIbkU4UWJXbVNwRUk5NktXTDAvYTRjd3JsbHU5ZVBIeXIxbDdhV0lzWllV?=
 =?utf-8?B?bjRhSVc0TUJhbXR4ME1ld1Y3dVVUa0dacmZhVEdSTDlyS0pNdjJJbzFpRW9n?=
 =?utf-8?B?cGwvN0hWb2FBYUFaTElTMnM4YlFQYk16S1JST2duS0N3cFdvZ0V2RW56NUJ5?=
 =?utf-8?B?SHVWMlJCNWJrM1dwVTIyaXBEeWlvcHFZTlArUW1hV0VQaWs1ME9NTUFDblVJ?=
 =?utf-8?B?bW5kSW82aW13VEtUZnhlbjVaWmxVSGwxYW1QY2I2ek0vRnBJcTVZWTU3WGkx?=
 =?utf-8?B?RDRSZGdNTW5WRjl5NnFOMDAzN25zWXBNSmRwaFF3QVN6MDdkNUhDdnFTTTF1?=
 =?utf-8?B?bGYwNzBtSEhpVFlib0N4TXlHOUtxdzJISWZmdW5vOXdhbW5ZZ00zMXFmTlhl?=
 =?utf-8?B?dUhOK3ErYjczOUpUcEFiRW1xclB3c3ZUeHRtR2NTZkhzdzdSTGl4SzZvc3RO?=
 =?utf-8?B?WHVBMU1GZFFZNnlnaVFVWjJ0R1ZMUkcvdzJPQklJYlJZNDdwTUNTQmF2dnVm?=
 =?utf-8?B?ZkpHTUhMZFdGa1pCU2EzSm9rczdCelJhNjdBNk4xa0h5U3JaSlBrQUNHKzhD?=
 =?utf-8?B?d0JGbjdrd0theWNhdW45UEFJaW5TY1lld3V2OGRzbXBDTGkwUWl6TTUzVjl0?=
 =?utf-8?B?QVNrMUlBUFlacFB3dktoMnEzSmNZNC9Ga1Y0TFVOeXJMOERDNUgraWxmMzk2?=
 =?utf-8?B?RjZzUTQ5OUpwZ0J5Nk4vLzIwdi9ReTVzU3BiS2krczJkV0VWd0dmdW53MXRj?=
 =?utf-8?B?dXNqU29NOEE2MUwyL2dQeE5LUmVjZnZ0UkFCcGxKRGRaV3BqT05jaXpCdmN5?=
 =?utf-8?Q?fo2HkgaA1js5cYsNIE6VrHWzQ?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 871357c0-3472-4c9d-7dc4-08da66c08614
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 00:17:09.7465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m+EHpJnjA8ashj9V4FrWF1j3/p7vFksGjYU7ccsk19iWjMGxWclYKj4YYuErxeQI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB4940
X-Proofpoint-GUID: XJvFT_NtYROwnFUsr1ojBv24jYx1Slue
X-Proofpoint-ORIG-GUID: XJvFT_NtYROwnFUsr1ojBv24jYx1Slue
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-15_15,2022-07-15_01,2022-06-22_01
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/22 7:58 AM, Benjamin Tissoires wrote:
> We need to also export the kfunc set to the syscall program type,
> and then add a couple of eBPF programs that are testing those calls.
> 
> The first one checks for valid access, and the second one is OK
> from a static analysis point of view but fails at run time because
> we are trying to access outside of the allocated memory.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Acked-by: Yonghong Song <yhs@fb.com>