Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Jul 2022 19:26:01 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Ira Weiny <ira.weiny@intel.com>, Lukas Wunner <lukas@wunner.de>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: RE: [PATCH V14 7/7] cxl/port: Introduce cxl_cdat_valid()
Message-ID: <62d221b999ece_242d29476@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220715030424.462963-1-ira.weiny@intel.com>
 <20220715030424.462963-8-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220715030424.462963-8-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K/LXYHgOCXhN8c6eIQtNdskmkgA29VlSFYIx4EP+eGH7z9HG7qqD20u4DurQ?=
 =?us-ascii?Q?+n0Nbz1KtuwFIlUkxuKtLK86DqPbXC3XASEfGt1cajB9mWtPVz1jonPStFra?=
 =?us-ascii?Q?UVh9zXZX7ed+dWTyAsTGC9sQcJBV0xVysASa5bDHpXl5Sae1kOoAnTj+WJ7A?=
 =?us-ascii?Q?XzVSZFP2qAs0cYxMUAFCnhg/xzjCWQ7pgde2LANZPbo9GDH3sPg9Mo0ztF7X?=
 =?us-ascii?Q?G14xHyP7bIO34cW1gEEjcmSCR1bh3kWEXp7UpbUidjpmUt3+V1+7eC9AYEMV?=
 =?us-ascii?Q?K8Ef4uIS08MyRFCGh3zCVneuCISaopbhjXrkllzZFNt4ttOZbGAce+XtQIoC?=
 =?us-ascii?Q?Y2nbFXM4oAhWZHOlfdGWxdVXZ4dfr2oi4QgtlslM7QMBTP4C4H2glMzjS3cc?=
 =?us-ascii?Q?pWg4Gc435lzkVAgnk5WRDNaA8Dn/1sGPz0Fa9/bz2ChmbUUwujOcCOd2xbYC?=
 =?us-ascii?Q?+OpLd6kYl8monkmc2ni8hL7fnFMDHhMdXr+WgyT+YIZVgUawQOTvoRLSiaJm?=
 =?us-ascii?Q?RMKBq3iPMIw9qwFXkcBNsW6z3aoi0uUUyj3NhpVYEkeSbwpHX1EohrZuO6Qm?=
 =?us-ascii?Q?ik2lExsGs+KhWI+aulMSGMdbfnddn8Ora6lxbYF0cmUHFUs3RgRbVAnKkM/7?=
 =?us-ascii?Q?xT+cR8UueUuMROPJJAzV8cc7II4gOT51a/clDJ6TYd+aLgs5LOPmBvMVK5HW?=
 =?us-ascii?Q?9hHC4B7QSYlHMN7cYYVVGkdv1g2gTj3p+3ns8elTX3FSJdHGRZlVPYhBy8zo?=
 =?us-ascii?Q?KMR/bKRx1csCLuHTc4yGdTEa9FDQasbDuuDC0x+W9FxDBOKWnMgaxyjK49t6?=
 =?us-ascii?Q?yZMvFjHkz0LirkidBtWVc9xHNhBbZCY+B5F4N3ztNH2J9FYEZsj6KqTCjMfx?=
 =?us-ascii?Q?eA0Q6P+dYBuE+7tSMeG35Ja3f2j5r/AP64ivPZxOG6zVJe0/58BCVtg6Unml?=
 =?us-ascii?Q?6t2y2OkO6DP/Jq0WUSS5LvTJ9cdsCAiP/KGbJxBK5LF2Km2UgH8rCqtX2aXz?=
 =?us-ascii?Q?D1pIpLkrQ0guS/V4V3/n5ozh+dboCjUFypGBOpKH8A6hL9hhQUzW29cecLy/?=
 =?us-ascii?Q?PbH+Do4OoE3lBRxJuchISZ7P/WN8PZ1C3u8Ac+N8TueLvcDbKtqmLIHXHc8C?=
 =?us-ascii?Q?iqFomKfb/I0Hk/q3H0DuSl+RjbNi8ndcIQI/9h/WhD2G3NhjwzIeALJiGL7M?=
 =?us-ascii?Q?fiCzU/h+eybGfYstApaineZe/wtFyH4t8G63/paCiwoBrIHtSgVS5fURThsI?=
 =?us-ascii?Q?CesYBfK8Jl06/9qJfpqyXSHl6XDz/TjTl+qWGsmY33TvIIvqYt/Wl4HU1Qmg?=
 =?us-ascii?Q?5lyaOp1mwNTtgn2j9EGMhihzoyfWw1jCdAjMeibOmu+QCM4IhrtYJcdRkdBD?=
 =?us-ascii?Q?N0NSy5sER8MyCnPdDxtBAWhq9NkHFcRusIdRjOBOwU2k7GF/DLRDo7ebWgtM?=
 =?us-ascii?Q?FA6neiKgfXj4jUV9ZxqkKt3g0qVBVgRrFxlZ9DCnXQ5SRiAegzgSmA2l2ys7?=
 =?us-ascii?Q?+4duEeFeg4R6nHkt4NHUjMbv+3/zBC9fVrt6ihk9/NG84F5Y36G+4uHZNK39?=
 =?us-ascii?Q?b5YS3NCRZNBkS9GGTJAw3PwmqWqJVu0TmsRO569++/3HkWcCIbQ3gx2bwwuU?=
 =?us-ascii?Q?Hg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9104b4ed-66cc-48af-a750-08da66d2881c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 02:26:04.1590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y4Y3BI8UYvN0NdI6DT7Y3I/jKMY5g62URSSww3Z+t305vhtZtu24NB7zS5CT4wwRQilcWpaIIxGPOzH/7Q0yw9B5s9sQyMeFc1YhPnQGIVo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ira.weiny@ wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> The CDAT data is protected by a checksum and should be the proper
> length.
> 
> Introduce cxl_cdat_valid() to validate the data.  While at it check and
> store the sequence number.

I am going to drop this one. Userspace can determine validity when it
parses it. When the kernel grows a CDAT parser it will rely on the
standard validation of ACPI-table-like structures from a future
__acpi_table_parse_entries() derivative for this purpose.