Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 16 Jul 2022 08:54:17 +0200
Message-ID: <87zgh9tuna.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition
In-Reply-To: <20220715205737.83076-1-andriy.shevchenko@linux.intel.com>
References: <20220715205737.83076-1-andriy.shevchenko@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 15 Jul 2022 22:57:37 +0200,
Andy Shevchenko wrote:
> 
> Use specific definition for invalid IRQ. It makes the
> code uniform in respect to the constant used for that.
> No functional change intended.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  sound/isa/sscape.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 0bc0025f7c19..9adaf91045e9 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -140,8 +140,7 @@ struct soundscape {
>  	unsigned char midi_vol;
>  };
>  
> -#define INVALID_IRQ  ((unsigned)-1)
> -
> +#define INVALID_IRQ  ((unsigned)INVALID_HWIRQ)
>  
>  static inline struct soundscape *get_card_soundscape(struct snd_card *c)
>  {

This seems failing to build on my local tree as is.
We need to include <linux/irq.h> explicitly.


thanks,

Takashi