Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] nvmem: core: Fix memleak in nvmem_register()
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <srinivas.kandagatla@linaro.org>, <linux-kernel@vger.kernel.org>,
        <gongruiqi1@huawei.com>, <wangweiyang2@huawei.com>
References: <20220716075352.2622809-1-cuigaosheng1@huawei.com>
 <YtJ1mthCP+4laqOn@kroah.com>
From:   cuigaosheng <cuigaosheng1@huawei.com>
Message-ID: <544cfbdb-9005-3d4d-58f9-258f875984dd@huawei.com>
Date:   Sat, 16 Jul 2022 17:59:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <YtJ1mthCP+4laqOn@kroah.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks for your time.

I have made the v2 patch and moving dev_set_name after nvmem_validate_keepouts
to fix the issue, hope you can provide some advice.

Thanks.

?? 2022/7/16 16:23, Greg KH д??:
> On Sat, Jul 16, 2022 at 03:53:52PM +0800, Gaosheng Cui wrote:
>> dev_set_name will alloc memory for nvmem->dev.kobj.name in
>> nvmem_register, when nvmem_validate_keepouts failed, nvmem's
>> memory will be freed and return, but nobody will free memory
>> for nvmem->dev.kobj.name, there will be memleak, so using
>> kfree_const(nvmem->dev.kobj.name) to fix it.
>>
>> Fixes: de0534df9347 ("nvmem: core: fix error handling while validating keepout regions")
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
>> ---
>>   drivers/nvmem/core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index 1e3c754efd0d..6c75c9afa5f3 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -833,6 +833,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>>   		rval = nvmem_validate_keepouts(nvmem);
>>   		if (rval) {
>>   			ida_free(&nvmem_ida, nvmem->id);
>> +			kfree_const(nvmem->dev.kobj.name);
>>   			kfree(nvmem);
> Something is really wrong, you should never be touching the name pointer
> of a kobject directly like this.  Also the device structure itself
> should be cleaning up the memory, not a kfree.  So this feels wrong...
>
> greg k-h
> .