Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1427517imw; Sat, 16 Jul 2022 06:26:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tSXT1emY0dVi/uDv+Y6aKE1wfRHrlgxBHpTpaSlSHOq0RWDmlbPVnMtre++vkuy3BRDdux X-Received: by 2002:a05:6402:34c1:b0:43a:bd7a:898a with SMTP id w1-20020a05640234c100b0043abd7a898amr25737951edc.426.1657978007401; Sat, 16 Jul 2022 06:26:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657978007; cv=none; d=google.com; s=arc-20160816; b=NTjtmOp1HGZBI6YXQiezpO1aajX8TGGL2+JeAcI+NNJuIuhbG0jg7as/QYYpNVTp2a ao9w4t3Muz9hSACim5kS6z6t9xocY+08OgCmZH0+FaCTKuG94Vg4wtrOUYG0wt8mocpv Wn78nV+rwWASLHZpi1/EWIn9ld3cuuyh5MnzJ4QmOfY1DqT02eQVRc/U2WtWXiVMPxs5 jYy9ItOdNRU/hcdZXdqJqxS4F28WoOWwvEOzS+8MI4pI7R6QAysCSiP8y04oqOhowtIU Vd2cwuzHL/TNFPR84VHySq4e8iwVfihCOZ6jXV9w1Imd0hy20cJVOKJfdqJFQtEJWckO GNkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gnHdMkzLi00tNGCUGHal6nCmNk9iiTh/Qem2M8JBxB0=; b=TSHTbUdiKujdLJVovFc+RhoBVjAFPAXAR/lrRPsb3OusBu8T3dvTUlCpG/lmCAKNfy i+JhleZ01/PKjvgBANm8uzKHjSuhJDJc2KmQ7JTIPnUESMttJgvUIzrWb8THzZERPian GHEL4jnyUTg5fa0Tfo4j3Xcn25VJejRZ8FH4eebviGJM7RFGMgNLiMBT3fwEh5Z32Qus MMt513TMjIo5SKcNMApFZ8N9ubFPT3vZYPrlL/lLdoZYIPtvfEmLCn8DgNnilRy52DPR AhDA3tlns58DM+9n+vgh378r9OPj3wVgGcaMtr26paGNWn/EvZ8A72Q5ujse9Ef/0vdW 1j+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EEAdtlOZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020aa7c2ca000000b0043abd4a6f50si2378091edp.134.2022.07.16.06.26.22; Sat, 16 Jul 2022 06:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EEAdtlOZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231575AbiGPNQF (ORCPT + 99 others); Sat, 16 Jul 2022 09:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231487AbiGPNQD (ORCPT ); Sat, 16 Jul 2022 09:16:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6DCD12127E for ; Sat, 16 Jul 2022 06:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657977361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gnHdMkzLi00tNGCUGHal6nCmNk9iiTh/Qem2M8JBxB0=; b=EEAdtlOZbGjluEvH2Eb8YISGCVz3+vXVNmpfDtbEfLztOeJT1ccdh7jTl21ohteHSAbj1b npsLLCHF3evgSgZzydyRy+srBIfU1k9sk6hb3wvvuQmeK+7awpc6TPPCtzbxfxoVwnAJNT LsXrnaBrrPf/Xs6qxjKgeZxjfMUPT2E= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-267-Q1blIeSZMZq6wadmOgf63g-1; Sat, 16 Jul 2022 09:16:00 -0400 X-MC-Unique: Q1blIeSZMZq6wadmOgf63g-1 Received: by mail-qk1-f200.google.com with SMTP id bj26-20020a05620a191a00b006b5c4e2dc77so5331136qkb.16 for ; Sat, 16 Jul 2022 06:16:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gnHdMkzLi00tNGCUGHal6nCmNk9iiTh/Qem2M8JBxB0=; b=4uvvyL6PR5GzpKYsWq9UA13Bv4GzPaP6dk81GgVJiF/knLSe21qD2DZ1pcDm32HIzw GoiYjrXd0MGeeSaVyJAc431sGez89lNMf6DRA9VfB2AsUrUUTGIlZE94YJ9WQ7j3nQC7 RpvUYRxHaXlq6DTEXvg1GKqT13wh7b7yxUqBzSWg84pHfpt1ESCOaBPy1x2H1ixJjFyu nnQw+stsmGxpCvzq9+8SUbvuFubroMZI0errbgXSVS1ZbserTRVq8XbRTlx+wLCsOrZi Gb1ICqI32eIeTnHwlRiV6jc0rKKIVWtvJKZ0qTrBigcN2UmbnLFD9O9CjROOHTNRROa9 whjw== X-Gm-Message-State: AJIora/qGZPll4nF+diSJRqBNiwfW25K1LWxi5cTzLJ8B1Hy40r84NAL 7tSd4Wgx8y9KTIBt71bK+DbvdHnz19CLT5+VCgxy0RMDWE8yTrOhdlDIUGLcP54helaDQaHpfJp 5WoGXI9k8DfAmGs8NSnwugo0D X-Received: by 2002:ac8:594e:0:b0:31d:410f:8b56 with SMTP id 14-20020ac8594e000000b0031d410f8b56mr15567516qtz.574.1657977359657; Sat, 16 Jul 2022 06:15:59 -0700 (PDT) X-Received: by 2002:ac8:594e:0:b0:31d:410f:8b56 with SMTP id 14-20020ac8594e000000b0031d410f8b56mr15567502qtz.574.1657977359393; Sat, 16 Jul 2022 06:15:59 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id q7-20020a05620a0d8700b006b5905999easm6122095qkl.121.2022.07.16.06.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 06:15:59 -0700 (PDT) From: Tom Rix To: axboe@kernel.dk, nathan@kernel.org, ndesaulniers@google.com, ming.lei@redhat.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] ublk_drv: initialize ret variable Date: Sat, 16 Jul 2022 09:15:55 -0400 Message-Id: <20220716131555.2014270-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang build fails with drivers/block/ublk_drv.c:1304:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] When the call to ublk_get_device_from_id() fails, ret is used without being initized. So initialize. Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Tom Rix --- drivers/block/ublk_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 52fd0af8a4f2..4d1199c98026 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1298,7 +1298,7 @@ static int ublk_ctrl_get_queue_affinity(struct io_uring_cmd *cmd) struct ublk_device *ub; unsigned long queue; unsigned int retlen; - int ret; + int ret = -ENODEV; ub = ublk_get_device_from_id(header->dev_id); if (!ub) -- 2.27.0